Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[User Settings] Add new Change Password view #1770

Merged
merged 10 commits into from
Mar 18, 2021
Merged

[User Settings] Add new Change Password view #1770

merged 10 commits into from
Mar 18, 2021

Conversation

Maftalion
Copy link
Contributor

@Maftalion Maftalion commented Mar 15, 2021 •
edited
Loading

Details

  • Created new change password form

Fixed Issues

Fixes https://github.com//issues/1710

Tests

  • Go to settings/changepassword page, attempt to change password using incorrect cred and confirm error message shows
  • Use valid credentials and confirm pw was changed
  • Enable 2FA in expensify.com and confirm new field required

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Success

Screen.Recording.2021-03-14.at.8.56.16.PM.mov

Error
Screen Shot 2021-03-14 at 8 55 12 PM

Web

Screen Shot 2021-03-14 at 8 39 17 PM

Mobile Web

Screen Shot 2021-03-14 at 8 40 49 PM

Desktop

Screen Shot 2021-03-14 at 8 46 32 PM

iOS

Screen Shot 2021-03-14 at 8 39 33 PM

Android

Screen Shot 2021-03-14 at 8 52 43 PM

@Maftalion Maftalion requested a review from a team as a code owner March 15, 2021 03:58
@botify botify requested review from francoisl and removed request for a team March 15, 2021 03:58
@NikkiWines NikkiWines linked an issue Mar 15, 2021 that may be closed by this pull request
[User Settings] Add new Change Password view #1710
Closed
francoisl
francoisl reviewed Mar 15, 2021
View reviewed changes
src/pages/settings/PasswordPage.js Outdated Show resolved Hide resolved
src/pages/settings/PasswordPage.js Outdated Show resolved Hide resolved
src/pages/settings/PasswordPage.js Outdated Show resolved Hide resolved
src/pages/settings/PasswordPage.js Outdated Show resolved Hide resolved
NikkiWines
NikkiWines previously approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both a 2FA account and non-2FA account. Works great!

@NikkiWines
Copy link
Contributor

@Maftalion just FYI you have some conflicts that are preventing this from getting merged

@Maftalion
Merge branch 'master' into matt-update-password-view
fd5ee9e 
# Conflicts:
#	src/pages/settings/PasswordPage.js
@Maftalion
Copy link
Contributor Author

@NikkiWines updated!

NikkiWines
NikkiWines previously approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@NikkiWines NikkiWines dismissed their stale review March 17, 2021 22:21

forgot that we had to add an extra line of text below the password input

francoisl
francoisl previously approved these changes Mar 17, 2021
View reviewed changes
NikkiWines
NikkiWines reviewed Mar 18, 2021
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Looks like Michelle had some comments on the sub-text so not approving but will do so as soon as that's updated!

@Maftalion
Copy link
Contributor Author

With the new formHint style:

Screen Shot 2021-03-18 at 8 39 46 AM

@michelle-thompson
Copy link
Contributor

Quick copy tweak -- it currently says 1 lowercase number and should be 1 lowercase letter

NikkiWines
NikkiWines previously approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks great!

francoisl
francoisl approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@francoisl francoisl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NikkiWines NikkiWines merged commit 52b5c33 into Expensify:master Mar 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawnborton shawnborton shawnborton left review comments

@francoisl francoisl francoisl approved these changes

@NikkiWines NikkiWines NikkiWines approved these changes

Assignees

@Maftalion Maftalion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[User Settings] Add new Change Password view
5 participants
@Maftalion @NikkiWines @michelle-thompson @francoisl @shawnborton