Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 2-factor authentication #18576
feat: add 2-factor authentication #18576
Changes from 13 commits
05bccf0
cb53f86
8174644
6a40c87
cf8c297
fc68b8f
ac00e92
a450dfb
4c59021
c6bdb52
9eaba25
a2c5cc5
0cd1361
35e8116
f0e7499
6c23b16
22af6ea
aaefecf
2675466
93d8367
3e8804c
b064454
465c78a
cec6a9a
28129b4
717dfde
8cc3b8b
aa7222c
18e8c39
1e02ef6
68c37b3
d774b88
1c57a73
9d68c57
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the logic, I wonder why this is a functional component that returns undefined, name of the function relates to Text Link but it's not displaying any UI which is misleading. Shouldn't it be just a simple function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. What do you think of renaming it to
ButtonFileLink
and making it always return aButton
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the thoughts - a functional component not rendering anything looks weird.
We can keep it is a simple function. I like that idea, but not sure where we'll have that function.
Making a ButtonLink component also looks like a good idea, but I wonder, we'll then be limited to have download functionality in other components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we go with the function approach, we could probably do something similar to
libs/fileDownload
because we will need different implementations for web, ios and android. And maybe call itlibs/localFileDownload
, since this is only for local files. wdyt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced
TextFileLink
with a simple function on/libs/localFileDownload