Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-retry cocoapods installation #1861

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Auto-retry cocoapods installation #1861

merged 2 commits into from
Mar 19, 2021

Conversation

roryabraham
Copy link
Contributor

Details

I had two iOS e2e test runs fail due to network errors during cocoapods installation.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/157765

Tests

Wait for E2E tests to pass on this PR.

Tested On

  • Github only :)

@roryabraham roryabraham requested a review from AndrewGable March 18, 2021 16:06
@roryabraham roryabraham requested a review from a team as a code owner March 18, 2021 16:06
@roryabraham roryabraham self-assigned this Mar 18, 2021
@botify botify requested review from robertjchen and removed request for a team March 18, 2021 16:06
@roryabraham
Copy link
Contributor Author

Interesting ... it seems like the cd command doesn't get persisted between steps (all shell commands are run from project root), which means I can safely add it back into the Install Cocoapods step.

robertjchen
robertjchen approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@robertjchen robertjchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robertjchen robertjchen merged commit d8f3764 into master Mar 19, 2021
@robertjchen robertjchen deleted the Rory-RetryCocoaPodsInstall branch March 19, 2021 04:37
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes

@robertjchen robertjchen robertjchen approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @robertjchen @AndrewGable