Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send the proper comment to the API when adding comments #1863

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Mar 18, 2021

Details

This returns the code back to what it was originally doing before I refactored it.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/157666

Tests

  1. Upload an attachment to a chat
  2. Refresh the page
  3. Verify there is no message for "Uploading attachment..." before the attachment

Tested On

  • Web

Only needs tested on one platform since it's related to the API

Screenshots

Web

image

@tgolen tgolen requested a review from a team March 18, 2021 16:27
@tgolen tgolen self-assigned this Mar 18, 2021
@botify botify requested review from sketchydroide and removed request for a team March 18, 2021 16:27
@tgolen
Copy link
Contributor Author

tgolen commented Mar 19, 2021

bump for review please @sketchydroide

Copy link
Contributor

@sketchydroide sketchydroide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sketchydroide sketchydroide merged commit 7fa7131 into master Mar 19, 2021
@sketchydroide sketchydroide deleted the tgolen-fix-upload branch March 19, 2021 15:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants