Update Details Page for Threads #18772

grgia · 2023-05-11T11:15:54Z

Details

Adds Leave Thread Button for threads.

Chat DM Thread	Workspace Room Thread

Fixed Issues

$ #18757

Tests

Verify that no errors appear in the JS console
Open a threaded report, open details, verify Members and Leave thread options show.
Click Leave Thread. Verify that thread is removed from LHN and user is sent to concierge chat.
Open a NON threaded report room, open details, verify Leave room option shows.

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

src/languages/es.js

src/pages/ReportDetailsPage.js

grgia · 2023-05-11T14:14:45Z

@chiragsalian @stitesExpensify could you help to define the QA for leaving threads?

melvin-bot · 2023-05-12T11:59:35Z

@stitesExpensify @fedirjh One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/Report.js

src/libs/ReportUtils.js

grgia · 2023-05-16T09:49:58Z

Also ready for review!

fedirjh · 2023-05-16T13:27:38Z

Reviewing shortly

fedirjh · 2023-05-16T16:54:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

WebThreds.mov

Screen.Recording.2023-05-16.at.5.14.07.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-05-16.at.5.43.56.PM.mov

Mobile Web - Safari

Screen.Recording.2023-05-16.at.5.25.53.PM.mov

Desktop

Screen.Recording.2023-05-16.at.5.14.07.PM.mov

iOS

Screen.Recording.2023-05-16.at.6.24.01.PM.mov

Android

Screen.Recording.2023-05-17.at.7.21.14.PM.mov

Screen.Recording.2023-05-16.at.6.14.22.PM.mov

fedirjh · 2023-05-16T17:32:34Z

cc @grgia There is a little bug on native , when you leave the thread , a not found view is shown for a brief moment before redirecting to concierge , not sure if that's related to this PR.

Screen.Recording.2023-05-16.at.6.28.12.PM.mov

grgia · 2023-05-16T18:51:38Z

@fedirjh potentially may be fixed with this PR? #19056

chiragsalian

Mentioned some bugs 1:1 to georgia to tackle.

grgia · 2023-05-17T16:40:20Z

@fedirjh done! Also, I think that bug has to do with our optimistic data more so than the details page, so I think we should fix it separately

fedirjh · 2023-05-17T16:43:27Z

@grgia Thanks for confirmation , PR looks good to , I will update PR checklist to include new screenshot

fedirjh · 2023-05-17T17:22:35Z

Member Page header doesn’t have a back button

Members	Setting	Share QR

There is a difference between Policy room and thread room for the member page

Thread Room	Policy Room

fedirjh · 2023-05-17T18:14:36Z

On native , on the details page , the header is displayed as the Thread title , however on web , the header is the participant display name

Native	Web

chiragsalian · 2023-05-17T18:34:12Z

Also members page header says "Details", it should instead say "Members"

grgia · 2023-05-17T19:14:33Z

@fedirjh @chiragsalian addressed those bugs

fedirjh · 2023-05-17T20:02:45Z

Looks good , there is weird bug where the header in not displayed for some threads and for concierge , not able to replicate constantly :

Screen.Recording.2023-05-17.at.8.56.48.PM.mov

chiragsalian

LGTM and it seems to work well for me

grgia · 2023-05-17T20:26:05Z

@fedirjh that's a known bug https://expensify.slack.com/archives/C049HHMV9SM/p1684222206427449

fedirjh

Thanks @grgia . Looks good to me and tests well

fedirjh · 2023-05-17T21:28:27Z

Screenshots/Videos

Web

Web.-.Policy.mov

Web.-.Thread.mov

Mobile Web - Chrome

mWebChrome.mov

Mobile Web - Safari

mWebSafari.mov

Desktop

Desktop.mov

iOS

IOS.mov

Android

Android.mov

Update Details Page for Threads (cherry picked from commit 33e637c)

…-18772 🍒 Cherry pick PR #18772 to staging 🍒

OSBotify · 2023-05-18T01:01:35Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.15-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-05-18T06:49:50Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.15-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:28:33Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:46:22Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Santhosh-Sellavel · 2023-07-13T17:37:38Z

I feel we could have captured this regression here, not an easy one though. Refer here, I know the code was not added here, but we could've caught this thanks!

Add leave thread to details page, move leaveRoom() to Report

4cc177b

grgia requested review from chiragsalian and stitesExpensify May 11, 2023 11:15

grgia self-assigned this May 11, 2023

grgia commented May 11, 2023

View reviewed changes

src/languages/es.js Show resolved Hide resolved

grgia commented May 11, 2023

View reviewed changes

src/pages/ReportDetailsPage.js Outdated Show resolved Hide resolved

stitesExpensify requested a review from fedirjh May 11, 2023 14:19

don't delete report actions (it could be a parent!)

53fc332

grgia changed the title ~~Update Details Page for Threads~~ [HOLD PR #18522] Update Details Page for Threads May 12, 2023

grgia added 3 commits May 12, 2023 12:49

if thread, use ReportDetails

746a1ce

Remove settings from threads for now.

b794f1e

Merge branch 'main' into georgia-threadDetails

b311830

grgia marked this pull request as ready for review May 12, 2023 11:59

grgia requested a review from a team as a code owner May 12, 2023 11:59

melvin-bot bot removed the request for review from a team May 12, 2023 11:59

fedirjh reviewed May 12, 2023

View reviewed changes

src/libs/actions/Report.js Show resolved Hide resolved

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

grgia added 2 commits May 15, 2023 13:28

Merge branch 'main' into georgia-threadDetails

d7b6eaf

Add description for LeaveRoom

bc299ec

grgia changed the title ~~[HOLD PR #18522] Update Details Page for Threads~~ Update Details Page for Threads May 15, 2023

grgia requested a review from fedirjh May 15, 2023 12:37

prettier

e5ca0ae

stitesExpensify previously approved these changes May 16, 2023

View reviewed changes

chiragsalian requested changes May 16, 2023

View reviewed changes

grgia added 3 commits May 17, 2023 20:09

Fix members section title + show back button

62b2e99

Fix title on web

d7e9755

prettier

419ec2f

stitesExpensify approved these changes May 17, 2023

View reviewed changes

chiragsalian approved these changes May 17, 2023

View reviewed changes

fedirjh approved these changes May 17, 2023

View reviewed changes

stitesExpensify merged commit 33e637c into main May 17, 2023

stitesExpensify deleted the georgia-threadDetails branch May 17, 2023 23:25

OSBotify pushed a commit that referenced this pull request May 17, 2023

Merge pull request #18772 from Expensify/georgia-threadDetails

4370582

Update Details Page for Threads (cherry picked from commit 33e637c)

OSBotify mentioned this pull request May 17, 2023

🍒 Cherry pick PR #18772 to staging 🍒 #19163

Merged

OSBotify added a commit that referenced this pull request May 17, 2023

Merge pull request #19163 from Expensify/mountiny-cherry-pick-staging…

5c6b531

…-18772 🍒 Cherry pick PR #18772 to staging 🍒

OSBotify mentioned this pull request May 18, 2023

Deploy Checklist: New Expensify 2023-05-16 #19088

Closed

71 tasks

melvin-bot bot mentioned this pull request May 18, 2023

[HOLD for payment 2023-05-29] Updating the Details Page #18757

Closed

OSBotify mentioned this pull request May 18, 2023

Deploy Checklist: New Expensify 2023-05-18 #19175

Closed

39 tasks

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Santhosh-Sellavel mentioned this pull request Jul 13, 2023

[HOLD for payment 2023-07-10] [$1000] Web- Chat - Unable to leave the Concierge "Welcome Message" thread #20197

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Details Page for Threads #18772

Update Details Page for Threads #18772

grgia commented May 11, 2023 •

edited

Loading

grgia commented May 11, 2023

melvin-bot bot commented May 12, 2023

grgia commented May 16, 2023

fedirjh commented May 16, 2023

fedirjh commented May 16, 2023 •

edited

Loading

fedirjh commented May 16, 2023

grgia commented May 16, 2023

chiragsalian left a comment

grgia commented May 17, 2023

fedirjh commented May 17, 2023

fedirjh commented May 17, 2023 •

edited

Loading

fedirjh commented May 17, 2023

chiragsalian commented May 17, 2023

grgia commented May 17, 2023

fedirjh commented May 17, 2023

chiragsalian left a comment

grgia commented May 17, 2023

fedirjh left a comment

fedirjh commented May 17, 2023

OSBotify commented May 18, 2023

OSBotify commented May 18, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Santhosh-Sellavel commented Jul 13, 2023

Update Details Page for Threads #18772

Update Details Page for Threads #18772

Conversation

grgia commented May 11, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

grgia commented May 11, 2023

melvin-bot bot commented May 12, 2023

grgia commented May 16, 2023

fedirjh commented May 16, 2023

fedirjh commented May 16, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

fedirjh commented May 16, 2023

grgia commented May 16, 2023

chiragsalian left a comment

Choose a reason for hiding this comment

grgia commented May 17, 2023

fedirjh commented May 17, 2023

fedirjh commented May 17, 2023 • edited Loading

fedirjh commented May 17, 2023

chiragsalian commented May 17, 2023

grgia commented May 17, 2023

fedirjh commented May 17, 2023

chiragsalian left a comment

Choose a reason for hiding this comment

grgia commented May 17, 2023

fedirjh left a comment

Choose a reason for hiding this comment

fedirjh commented May 17, 2023

Screenshots/Videos

OSBotify commented May 18, 2023

OSBotify commented May 18, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Santhosh-Sellavel commented Jul 13, 2023

grgia commented May 11, 2023 •

edited

Loading

fedirjh commented May 16, 2023 •

edited

Loading

fedirjh commented May 17, 2023 •

edited

Loading