UI MoneyRequestHeader Polish #18775

s77rt · 2023-05-11T14:15:05Z

Details

Set flex 1 to Views so the workspace name does not overflow.
Adjusted subscript avatar position, background color and border radius (more info in comment).
Adjusted MoneyRequestHeader bottom padding to meet the design mockup (20px).
The <ReportActionItemCreated /> (welcome message, avatars and bg art) will be rendered only if the report is a chat report.
Reduced section titles heights

Fixed Issues

$ #18773

Tests

Same as #18537 but request money from a workspace/user with a very long name

Verify name does not overflow and shows ellipsis instead
Verify there is no welcome message and that the background is blank

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

same as Tests ^

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

s77rt · 2023-05-11T19:14:36Z

src/components/AvatarWithDisplayName.js

                    {isExpenseReport ? (
                        <SubscriptAvatar
+                            backgroundColor={themeColors.highlightBG}


This is taken from MoneyRequestHeader

melvin-bot · 2023-05-12T00:10:24Z

@Julesssss @0xmiroslav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss

Looking good. I'm going to cc Shawn for a final design review.

Julesssss · 2023-05-12T08:23:39Z

I kicked off an automated builds run here. Once complete, I'll share the links with Shawn for review.

0xmiros · 2023-05-12T08:24:43Z

I will review and checklist in a few hrs

rushatgabhane · 2023-05-12T09:53:51Z

@Julesssss the automated build failed https://github.com/Expensify/App/actions/runs/4956770413

Julesssss · 2023-05-12T12:55:26Z

Forgot to add the label, re-running now.

src/styles/StyleUtils.js

0xmiros · 2023-05-12T15:42:43Z

Also, please pull from main

s77rt · 2023-05-12T15:53:26Z

@0xmiroslav

Also, please pull from main

This is based on main and there are no conflicts. Are you facing any issue here?

0xmiros · 2023-05-12T16:04:37Z

This is based on main and there are no conflicts. Are you facing any issue here?

No issue but just for safety (207 commits behind is not small diff). PR itself is fine but after merge, might conflict with another PR as I've seen a few cases recently.
If you don't, I can pull main locally and test.

s77rt · 2023-05-12T18:21:26Z

Key notes:

Added iconAdditionalStyles prop to Avatar to pass styles and avoid the double border radius. Previously there was 3 border radius values (20px for default avatar, 4px inner, 6px outer). Now we only have one which is 6px.
We can now pass imageStyles=null to clear the preset styles. This is needed to remove the 20px border radius and unset the unnecessary width and height for the subscript avatar.
StyleUtils.getAvatarBorderWidth will now return an object instead of a number.
Removed the extra View in SubscriptAvatar. Will be using the existing containerStyles prop.

I think the rest is self-explanatory.

Here are the results:

cc @shawnborton

s77rt · 2023-05-12T18:22:38Z

src/styles/StyleUtils.js

-        [CONST.AVATAR_SIZE.SMALL_SUBSCRIPT]: 2,
+        [CONST.AVATAR_SIZE.SMALL_SUBSCRIPT]: 1,


This was based on the removed border width from secondAvatarSubscriptCompact.

shawnborton · 2023-05-12T19:01:57Z

Looks good to me!

0xmiros · 2023-05-12T19:31:53Z

@s77rt is this ready for review?

s77rt · 2023-05-12T20:34:34Z

@0xmiroslav Yes. There are still 2 other enhancements but we may move those to a follow up PR. You can review this one as is.

luacmartins · 2023-05-16T16:58:03Z

@s77rt can you address @mountiny's comment above please?

0xmiros · 2023-05-16T16:58:48Z

Let's merge main into this branch and see if that still happens

luacmartins · 2023-05-16T17:00:10Z

I don't think we should merge it with failing tests.

mountiny · 2023-05-16T17:08:10Z

yeah we cannot merge this as then all PRs would be failing.

0xmiros · 2023-05-16T17:11:10Z

I don't think we should merge it with failing tests.

Oh I meant to pull main since this branch is 445 commits behind

s77rt · 2023-05-16T17:13:37Z

Sorry I thought the failing test was the old unread indicator one, it's another one. Fix is on the way.

s77rt · 2023-05-16T17:26:03Z

Ok we should be good to go 🚀

UI MoneyRequestHeader Polish (cherry picked from commit bd6743c)

…-18775 🍒 Cherry pick PR #18775 to staging 🍒

OSBotify · 2023-05-16T19:00:01Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.3.14-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-05-17T00:17:52Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:29:45Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:47:33Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rushatgabhane · 2023-07-23T15:27:58Z

src/components/SubscriptAvatar.js

-            </View>
+            <Tooltip text={props.secondaryTooltip}>
+                <Avatar
+                    imageStyles={null}


Hi this PR caused #19905

More details - #19905 (comment)

Thanks @rushatgabhane We didn't test with a real image indeed. Nice catch!

s77rt added 2 commits May 11, 2023 15:09

Truncate long names

f0b4058

fix avatar background, position and border radius

bf8240a

s77rt commented May 11, 2023

View reviewed changes

fix MoneyRequestHeader padding

ab5a6ff

s77rt marked this pull request as ready for review May 12, 2023 00:10

s77rt requested a review from a team as a code owner May 12, 2023 00:10

melvin-bot bot requested review from 0xmiros and Julesssss and removed request for a team May 12, 2023 00:10

Julesssss assigned s77rt May 12, 2023

Julesssss previously approved these changes May 12, 2023

View reviewed changes

Julesssss added the Ready To Build label May 12, 2023

0xmiros reviewed May 12, 2023

View reviewed changes

src/styles/StyleUtils.js Outdated Show resolved Hide resolved

s77rt added 2 commits May 12, 2023 17:19

Merge branch 'Expensify:main' into iou-header-polish

37e2038

Removed redundant border radius in Avatar

c554f5d

s77rt dismissed Julesssss’s stale review via c554f5d May 12, 2023 18:21

s77rt commented May 12, 2023

View reviewed changes

because consistency matters

a49b6b6

s77rt added 2 commits May 16, 2023 18:13

Merge branch 'Expensify:main' into iou-header-polish

22b0376

fix failing test

ff1d770

s77rt dismissed stale reviews from 0xmiros, mountiny, luacmartins, and Julesssss via ff1d770 May 16, 2023 17:16

Julesssss approved these changes May 16, 2023

View reviewed changes

luacmartins approved these changes May 16, 2023

View reviewed changes

luacmartins merged commit bd6743c into Expensify:main May 16, 2023

OSBotify mentioned this pull request May 16, 2023

🍒 Cherry pick PR #18775 to staging 🍒 #19052

Merged

OSBotify pushed a commit that referenced this pull request May 16, 2023

Merge pull request #18775 from s77rt/iou-header-polish

857d8c5

UI MoneyRequestHeader Polish (cherry picked from commit bd6743c)

OSBotify added a commit that referenced this pull request May 16, 2023

Merge pull request #19052 from Expensify/OSBotify-cherry-pick-staging…

7b022b6

…-18775 🍒 Cherry pick PR #18775 to staging 🍒

OSBotify mentioned this pull request May 16, 2023

Deploy Checklist: New Expensify 2023-05-15 #18938

Closed

67 tasks

melvin-bot bot mentioned this pull request May 16, 2023

[$1000] [HOLD for payment 2023-05-25] [HOLD for payment 2023-05-23] Improve UI for the LHN workspace request items #18773

Closed

6 tasks

OSBotify mentioned this pull request May 17, 2023

Deploy Checklist: New Expensify 2023-05-16 #19088

Closed

71 tasks

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

rushatgabhane reviewed Jul 23, 2023

View reviewed changes

rushatgabhane mentioned this pull request Jul 23, 2023

[HOLD for payment 2023-07-14] [$1000] The workspace logo disappears if changed the workspace picture on combined user/workspace chat #19905

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI MoneyRequestHeader Polish #18775

UI MoneyRequestHeader Polish #18775

s77rt commented May 11, 2023 •

edited

Loading

s77rt May 11, 2023

melvin-bot bot commented May 12, 2023

Julesssss left a comment

Julesssss commented May 12, 2023

0xmiros commented May 12, 2023 •

edited

Loading

rushatgabhane commented May 12, 2023

Julesssss commented May 12, 2023

0xmiros commented May 12, 2023

s77rt commented May 12, 2023

0xmiros commented May 12, 2023

s77rt commented May 12, 2023

s77rt May 12, 2023

shawnborton commented May 12, 2023

0xmiros commented May 12, 2023

s77rt commented May 12, 2023

luacmartins commented May 16, 2023

0xmiros commented May 16, 2023 •

edited

Loading

luacmartins commented May 16, 2023

mountiny commented May 16, 2023

0xmiros commented May 16, 2023

s77rt commented May 16, 2023

s77rt commented May 16, 2023

OSBotify commented May 16, 2023

OSBotify commented May 17, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

rushatgabhane Jul 23, 2023

s77rt Jul 23, 2023

		[CONST.AVATAR_SIZE.SMALL_SUBSCRIPT]: 2,
		[CONST.AVATAR_SIZE.SMALL_SUBSCRIPT]: 1,

UI MoneyRequestHeader Polish #18775

UI MoneyRequestHeader Polish #18775

Conversation

s77rt commented May 11, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

s77rt May 11, 2023

Choose a reason for hiding this comment

melvin-bot bot commented May 12, 2023

Julesssss left a comment

Choose a reason for hiding this comment

Julesssss commented May 12, 2023

0xmiros commented May 12, 2023 • edited Loading

rushatgabhane commented May 12, 2023

Julesssss commented May 12, 2023

0xmiros commented May 12, 2023

s77rt commented May 12, 2023

0xmiros commented May 12, 2023

s77rt commented May 12, 2023

s77rt May 12, 2023

Choose a reason for hiding this comment

shawnborton commented May 12, 2023

0xmiros commented May 12, 2023

s77rt commented May 12, 2023

luacmartins commented May 16, 2023

0xmiros commented May 16, 2023 • edited Loading

luacmartins commented May 16, 2023

mountiny commented May 16, 2023

0xmiros commented May 16, 2023

s77rt commented May 16, 2023

s77rt commented May 16, 2023

OSBotify commented May 16, 2023

OSBotify commented May 17, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

rushatgabhane Jul 23, 2023

Choose a reason for hiding this comment

s77rt Jul 23, 2023

Choose a reason for hiding this comment

s77rt commented May 11, 2023 •

edited

Loading

0xmiros commented May 12, 2023 •

edited

Loading

0xmiros commented May 16, 2023 •

edited

Loading