17017 migrate RadioButtonWithLabel to PressableWithFeedback #18847

robertKozik · 2023-05-12T16:43:07Z

Details

This PR migrates RadioButtonWithLabel to PressableWithFeedback. Before RedioButtonWithLabel was using the TouchableOpacity which will be deprecated in next version of react-native-web. In addition to migration, accessibility prop is now set to false to be in line with already preset focusable={false}. In terms of visuals, nothing should get changed.

Fixed Issues

$ #17017
PROPOSAL: #17017

Tests

For local testing I needed to mock the question

Access the Idiology question section inside Enable Payments Page
Click/Press the radio button either on radio button or it's label
Verify that clicked/Pressed option is properly selected and works as intended

Verify that no errors appear in the JS console

Offline tests

Same as Test steps

QA Steps

Same as Test steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-16.at.20.15.43.mov

Mobile Web - Chrome

android.-.web.mov

Mobile Web - Safari

iOS.-.web.mov

Desktop

Desktop.-.native.mov

iOS

iOS.-.native.mov

Android

android.-.native.mov

melvin-bot · 2023-05-16T12:11:35Z

@abdulrahuman5196 @dangrous One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2023-05-16T12:26:42Z

Will start on this.

src/components/RadioButtonWithLabel.js

abdulrahuman5196 · 2023-05-16T14:18:49Z

@robertKozik Added some questions on the implementation. It would be better to add some more information in the PR details section since the linked issue also doesn't have much information, so that it will be useful for future references.

abdulrahuman5196 · 2023-05-16T16:03:42Z

Hi, I did mock the questions page and tested out the changes

Current behaviour in main:

Screen.Recording.2023-05-16.at.9.08.54.PM.mov

Behaviour with the new code change:

Screen.Recording.2023-05-16.at.9.14.46.PM.mov

I have few concerns

With the new implementation the label is dimmed on hover itself and shows the text in grey, which seems odd. This opacity change behaviour would be good for button but seems odd just for label. Are we expecting this?
If we are expecting number one, the checkbox icon doesn't have the same behaviour(Assuming its due to the fact it still uses plain old Pressable). Do we have future plans to unify the behaviour for radio icon as well?
And more odder when you combine long press with it along with hover effect.

Screen.Recording.2023-05-16.at.9.28.21.PM.mov

Might be out of scope of this PR, but just calling out since I had noticied. The radio with the check box is selectable/unselectable even at the horizontal end of the page where the text is not even nearby. It could be due to the Pressable view extending till the end. I noticied this behaviour in main as well.

@robertKozik @dangrous I understand this PR is only concerned about the migration but would be good to understand the thoughts on the above issues. Are we fine with the behaviour?/ Do we need to fix it part of this PR or Do as a followup action.

robertKozik · 2023-05-16T16:24:16Z

@abdulrahuman5196 Both behaviour are easy to change, or remove. It comes from the implementation of PressableWithFeedback as it have out-of-the-box solution for dimming on both hover and presses.

That's why your third point occurred, different dimming is applied on the presses.

I agree with you that no visible changes should be introduced with the migration so I'll remove the hover dimming, press dimming is present on production so I'll left it.

Your last concern comes from the styling used on the view, as it styling the view with styles.w100 to span to the end.

abdulrahuman5196 · 2023-05-16T16:29:25Z

@robertKozik Great. Then lets go with not changing/regressing any behaviour now. Have migration changes in the same way.
Others concerns i posted which is also present in the main can be took as a follow-up( concern number 4) and should not block this migration IMO.

robertKozik · 2023-05-16T16:48:23Z

@abdulrahuman5196 I've disabled the hover dimming and removed doubling styles (this was unintentional). However I'll be able to test it once more in about an hour or so.

abdulrahuman5196 · 2023-05-16T16:50:15Z

@robertKozik Sure. Kindly update once you have done testing. I will continue testing tomorrow morning from my end.

robertKozik · 2023-05-16T18:18:50Z

Alright, I've filled out details PR section and change the video from web to indicate no hover effect

abdulrahuman5196 · 2023-05-16T19:11:40Z

@robertKozik one other difference I see is in the long press case. In main the option gets selected only when we release the press, but in the new code its gets selected after a while without release but the press dim is only gone after press release.

New implementation

Screen.Recording.2023-05-17.at.12.33.52.AM.mov

Current implementation

Screen.Recording.2023-05-17.at.12.33.02.AM.mov

…onLongPress is passed

robertKozik · 2023-05-16T22:36:50Z

I needed to rebase with main, but now options are selected when user releases the button. Also I have implemented the custom prop test in order to remove the AccessibilityLabel is required error when element is not accessible. I hope that new it works as it should be 🎸

src/components/Pressable/GenericPressable/PropTypes.js

abdulrahuman5196 · 2023-05-17T11:01:49Z

@robertKozik I tried in desktop and all seems to work fine. Can you take care of the above request alone - #18847 (comment)? So that I can start testing in other platforms and complete the reviewer's checklist?

src/components/Pressable/GenericPressable/PropTypes.js

abdulrahuman5196 · 2023-05-18T19:35:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
  -[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-19.at.2.32.38.AM.mov

Mobile Web - Chrome

az_recorder_20230519_023408.mp4

Mobile Web - Safari

Untitled.mov

Desktop

desktop.mov

iOS

ios.mov

Android

az_recorder_20230519_022740.mp4

…sibilityLabel

abdulrahuman5196 · 2023-05-18T21:13:16Z

Note: I see some console errors and issues with ideology page but none of those are required for this PR. I will file bugs in slack for those.

abdulrahuman5196

@dangrous All yours. I have completed reviewers checklist.

But could only verify by mocking the flow same as the author since it requires wallet flow. Kindly help and verify from your end on actual wallet flow.

dangrous

Two quick changes.

However, seeing it in action, I dislike how we make this work, and I'm wondering if we can sneak some improvements in here. To note - none of these are because of this code, it's pre existing decisions.

Is press dimming required for accessibility? If not, I think we should remove it - it's weird that the text dims but not the checkbox, and in usual usage if you're just tapping you only see it as a flash. I'd also be okay if we apply the dimming to the whole item (including the box) but I don't think that's possible within this component.
I think we should remove the checks from the options that aren't currently checked. I will sync with design to see if we can do that (very easy fix)

It's totally fine to just make a separate issue for those updates, and push this forward as a straight migration. If you'd prefer that to keep scope of this issue down, just let me know!

dangrous · 2023-05-19T16:04:36Z

src/components/Pressable/GenericPressable/PropTypes.js

+function requiredPropsCheck(props) {
+    if (props.accessible !== true || (props.accessibilityLabel !== undefined && typeof props.accessibilityLabel === 'string')) {
+        return;
+    }
+    return new Error(`Provide a valid string for accessibilityLabel prop when accessible is true`);
+}


Suggested change

function requiredPropsCheck(props) {

if (props.accessible !== true || (props.accessibilityLabel !== undefined && typeof props.accessibilityLabel === 'string')) {

return;

}

return new Error(`Provide a valid string for accessibilityLabel prop when accessible is true`);

}

function requiredPropsCheck(props) {

if (props.accessible === true && (props.accessibilityLabel === undefined || typeof props.accessibilityLabel !== 'string')) {

return new Error(`Provide a valid string for accessibilityLabel prop when accessible is true`);

}

}

Makes this shorter and a little easier to understand (also follows the pattern of those other ones I found

The one problem is that if we have only one statement lint gives us error: Prefer an early return to a conditionally-wrapped function body

Well that's annoying. Okay, fine to keep as is!

src/components/RadioButtonWithLabel.js

dangrous · 2023-05-19T16:17:40Z

Update - I think it makes the most sense to ignore the design changes I want to make and handle that separately. I'll make another issue for that. Just handle the requested changes, and we should be good to go!

And reading back in the comments I see you both talked about some of these issues I had as well (such as press dimming), so I'm glad we're pretty much on the same page. I think we can clean up the design of this significantly

Co-authored-by: Daniel Gale-Rosen <[email protected]>

robertKozik · 2023-05-19T16:54:41Z

Sure, generally the migration to PressableWithFeedback/PressableWithoutFeedback will be great platform to implement such a standardisation of the press/hover behaviours.

Let me know if we want to update therequirePropsCheck function even when it will need to supress eslint rule for this line.

abdulrahuman5196 · 2023-05-19T18:17:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
  -[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-19.at.11.33.15.PM.mov

Mobile Web - Chrome

az_recorder_20230519_233900.mp4

Mobile Web - Safari

ScreenRecording.mov

Desktop

Screen.Recording.2023-05-19.at.11.28.08.PM.mov

iOS

Screen.Recording.2023-05-19.at.11.31.04.PM.mov

Android

az_recorder_20230519_234859.mp4

abdulrahuman5196

Did another reviewer's checklist and all are good. Approving.
We should be good to merge, if this was verified from real page from your end as well.

@dangrous

dangrous · 2023-05-19T21:36:21Z

Yep, tested on the real flow and looks good!

OSBotify · 2023-05-19T21:43:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-22T23:50:36Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

mvtglobally · 2023-05-23T03:51:51Z

@robertKozik @dangrous Is there an easy way to navigate to this page in Staging?

dangrous · 2023-05-23T13:32:36Z

@mvtglobally can y'all do the Wallet Activation flow? If not, let me know and I can test quickly

mvtglobally · 2023-05-23T13:34:55Z

@dangrous isnt it behind the KYC wall? I don't think we were able to do it in the past, but if you can share a way it would be great

dangrous · 2023-05-23T14:26:22Z

I mean it sort of IS the KYC wall? I think you're right though, I can check this out shortly

dangrous · 2023-05-23T15:07:25Z

Man, took me forever to get there but looks good!

mvtglobally · 2023-05-23T20:22:57Z

@dangrous are we ok to check it off?

dangrous · 2023-05-24T12:13:39Z

Yes!

OSBotify · 2023-05-25T00:22:28Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.17-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2023-06-01T23:48:43Z

src/components/RadioButtonWithLabel.js

@@ -38,6 +39,8 @@ const defaultProps = {
    errorText: '',
 };

+const PressableWithFeedback = Pressables.PressableWithFeedback;


Not a good import. It should have been a named import and used directly on JSX.

parasharrajat · 2023-06-01T23:49:53Z

src/components/RadioButtonWithLabel.js

+                    hoverDimmingValue={1}
+                    pressDimmingValue={0.2}


About this, we disabled the hover dimming and I see that same is being applied on another PR but if we don't want to have that anywhere (currently app has none), then why is it not set to 1 as default?

ah that's a good point - @roryabraham do you have any thoughts? Any reason not to update this at some point?

I can agree with that. As this should be more focused on migration rather than changing the visuals (as this would likely need some design decisions) 1 as default suits this approach

Ok. Asked on slack https://expensify.slack.com/archives/C01GTK53T8Q/p1685741951521769

robertKozik mentioned this pull request May 12, 2023

[HOLD for payment 2023-06-01] [HOLD for payment 2023-05-30][$1000] [Group 2][Accessible Pressable] Migrate RadioButtonWithLabel #17017

Closed

robertKozik force-pushed the 17017-migrate-radio-with-label branch from 23d187a to 9ecda35 Compare May 16, 2023 12:02

robertKozik marked this pull request as ready for review May 16, 2023 12:11

robertKozik requested a review from a team as a code owner May 16, 2023 12:11

melvin-bot bot requested review from abdulrahuman5196 and dangrous and removed request for a team May 16, 2023 12:11

This comment was marked as outdated.

Sign in to view

abdulrahuman5196 reviewed May 16, 2023

View reviewed changes

src/components/RadioButtonWithLabel.js Show resolved Hide resolved

abdulrahuman5196 reviewed May 16, 2023

View reviewed changes

src/components/RadioButtonWithLabel.js Outdated Show resolved Hide resolved

robertKozik added 5 commits May 16, 2023 22:00

migrate RadioButtonWithLabel to PressableWithFeedback

a0b2e05

disable dimming RadioButtonWithLabel on hover, remove doubling styles

a33b4d1

use correct prop hoverDimmingValue

9e2d2ea

BaseGenericPressable should behave as react-native Pressable when no …

920c4d4

…onLongPress is passed

don't require accessibilityLabel when Pressable is not accessible

0a8c83e

robertKozik force-pushed the 17017-migrate-radio-with-label branch from cef0bd3 to 0a8c83e Compare May 16, 2023 22:32

robertKozik requested a review from abdulrahuman5196 May 16, 2023 22:36

abdulrahuman5196 reviewed May 17, 2023

View reviewed changes

src/components/Pressable/GenericPressable/PropTypes.js Outdated Show resolved Hide resolved

abdulrahuman5196 reviewed May 18, 2023

View reviewed changes

src/components/Pressable/GenericPressable/PropTypes.js Outdated Show resolved Hide resolved

change test function for Pressable proptypes to be specific for acces…

67321ee

…sibilityLabel

robertKozik force-pushed the 17017-migrate-radio-with-label branch from 58f19d0 to 67321ee Compare May 18, 2023 20:23

abdulrahuman5196 previously approved these changes May 18, 2023

View reviewed changes

dangrous requested changes May 19, 2023

View reviewed changes

robertKozik dismissed abdulrahuman5196’s stale review via d591c7b May 19, 2023 16:39

set press dim to 0.2 for RadioButtonWithLabel

d591c7b

Co-authored-by: Daniel Gale-Rosen <[email protected]>

dangrous approved these changes May 19, 2023

View reviewed changes

abdulrahuman5196 approved these changes May 19, 2023

View reviewed changes

dangrous merged commit 123a86f into Expensify:main May 19, 2023

OSBotify mentioned this pull request May 22, 2023

Deploy Checklist: New Expensify 2023-05-22 #19422

Closed

62 tasks

parasharrajat reviewed Jun 1, 2023

View reviewed changes

parasharrajat mentioned this pull request Jun 1, 2023

17036 — migrate InitialSettingsPage to PressableWithFeedback #19882

Merged

57 tasks

17017 migrate RadioButtonWithLabel to PressableWithFeedback #18847

17017 migrate RadioButtonWithLabel to PressableWithFeedback #18847

Conversation

robertKozik commented May 12, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 16, 2023

abdulrahuman5196 commented May 16, 2023

This comment was marked as outdated.

abdulrahuman5196 commented May 16, 2023 • edited Loading

abdulrahuman5196 commented May 16, 2023

robertKozik commented May 16, 2023 • edited Loading

abdulrahuman5196 commented May 16, 2023 • edited Loading

robertKozik commented May 16, 2023

abdulrahuman5196 commented May 16, 2023

robertKozik commented May 16, 2023

abdulrahuman5196 commented May 16, 2023 • edited Loading

robertKozik commented May 16, 2023

abdulrahuman5196 commented May 17, 2023

abdulrahuman5196 commented May 18, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 commented May 18, 2023 • edited Loading

abdulrahuman5196 left a comment • edited Loading

Choose a reason for hiding this comment

dangrous left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dangrous commented May 19, 2023

robertKozik commented May 19, 2023

abdulrahuman5196 commented May 19, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

dangrous commented May 19, 2023

OSBotify commented May 19, 2023

OSBotify commented May 22, 2023

mvtglobally commented May 23, 2023

dangrous commented May 23, 2023

mvtglobally commented May 23, 2023

dangrous commented May 23, 2023

dangrous commented May 23, 2023

mvtglobally commented May 23, 2023

dangrous commented May 24, 2023

OSBotify commented May 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

robertKozik commented May 12, 2023 •

edited

Loading

abdulrahuman5196 commented May 16, 2023 •

edited

Loading

robertKozik commented May 16, 2023 •

edited

Loading

abdulrahuman5196 commented May 16, 2023 •

edited

Loading

abdulrahuman5196 commented May 16, 2023 •

edited

Loading

abdulrahuman5196 commented May 18, 2023 •

edited

Loading

abdulrahuman5196 commented May 18, 2023 •

edited

Loading

abdulrahuman5196 left a comment •

edited

Loading

abdulrahuman5196 commented May 19, 2023 •

edited

Loading