add some margin between amount and tick mark in ReportPreview.js

[ahmedGaber93]

Details

Fixed Issues

$ #19049
$ #19049 (comment)

Tests

1. Send a money request from account A to account B.
2. Settle the requested amount from account B.
3. Verify that there is enough margin between the "settled up [amount]" and tick mark.

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests step.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-18.at.11.24.52.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-05-18.at.11.30.29.PM.mov

Mobile Web - Safari

Screen.Recording.2023-05-18.at.11.51.41.PM.mov

Desktop

Screen.Recording.2023-05-18.at.11.32.54.PM.mov

iOS

Screen.Recording.2023-05-18.at.11.48.35.PM.mov

Android

Screen.Recording.2023-05-18.at.11.28.11.PM.mov

[melvin-bot]

@jasperhuangg @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[jasperhuangg]

ez pz

[Santhosh-Sellavel]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Desktop

Mobile Web - Chrome

Mobile Web - Safari

iOS

Android

[Santhosh-Sellavel]

@jasperhuangg Are we okay with this overlapping of ticks & right arrow button, check all 4 ticks.

cc: @Expensify/design

[shawnborton]

I am super confused about this design - @JmillsExpensify @trjExpensify do you know what's going on here with the green checkmarks?

[ahmedGaber93]

@Santhosh-Sellavel what is the next step?

[shawnborton]

Also, separately, what device is on the left here? Can you raise a bug report in the bugs room about the chat composer being incorrect?

[Santhosh-Sellavel]

@shawnborton I'll check again and report it.

[trjExpensify]

I am super confused about this design - @JmillsExpensify @trjExpensify do you know what's going on here with the green checkmarks?

Hm, not sure what's going on there. I haven't spotted the misaligned checkmarks on the report preview message before. It should look like this:

Seems like that's the case in the PR OP though? Just not in @Santhosh-Sellavel's testing here.

Also, that empty line in the report preview message we can see is being handled elsewhere by @luacmartins, as well as overlaying the workspace avatar.

[Santhosh-Sellavel]

@shawnborton we have an issue for this.

[Santhosh-Sellavel]

@trjExpensify Here is a recording

Screen.Recording.2023-05-23.at.2.52.12.AM.mov

As you can notice in the video green tick is too close to the settled-up message. We are trying to address this here.

Postfix

Here there is one more issue that is discussed here. I thought this was introduced here but it happens on the main as also. In fact, the video above itself was recorded from running on the main branch!

After settling up a transaction the new settled message is not updated properly not sure how long it takes but as far I see it needs a refresh. Also, there is one more issue I can see, For the account [email protected], we have theBeta 1 Test as the user name. But we still show the mail id in the IOU message.

Immediately after settling up

In a new session(Close and open the app) or refresh the page

cc: @shawnborton @jasperhuangg

[luacmartins]

LGTM @Santhosh-Sellavel can you complete the checklist please?

[Santhosh-Sellavel]

@luacmartins Thanks for the bump, assuming we are not gonna hold this PR for any issues discussed here

[Santhosh-Sellavel]

LGTM, thanks!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[trjExpensify]

Sorry guys, I've been away. Where did we land with this? #19222 (comment)

It seems broken to me that. Minimally we need a follow-up if that hasn't been addressed elsewhere.

[Santhosh-Sellavel]

Should create a new issue then if not already!

[luacmartins]

@trjExpensify @Santhosh-Sellavel I think that issue was fixed here, no?

[Santhosh-Sellavel]

No, it's not fixed here. Issues described here will need a follow-up

[luacmartins]

Hmm maybe I didn't understand the bug reported here then. Could you clarify?

[OSBotify]

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.18-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[Santhosh-Sellavel]

Hmm maybe I didn't understand the bug reported here then. Could you clarify?
@luacmartins

Here is the recording

Screen.Recording.2023-05-23.at.2.52.12.AM.mov

After settling up a transaction the new settled message is not updated properly not sure how long it takes but as far I see, we need to refresh. Also, there is one more issue I can see for the account [email protected], we have theBeta 1 Test as the user name. But we still show the mail id in the IOU message.

Immediately after settling up

In a new session(Close and open the app) or refresh the page

There are multiple issues here

1. Settled up preview is not updated properly
2. And 1 causes overlapping tick (✅ ) with disclosure Indicator (arrow)
3. We show email id when already have a name

[luacmartins]

AH I see the problem now. Yea, we should create a new issue for it. @Santhosh-Sellavel do you wanna post it in Slack?

[Santhosh-Sellavel]

@luacmartins There are multiple issues here, So can you just create an issue from the above and assign me as C+ I will clarify any doubt and move this forward from there. Do you want them reported separately?

Issues are

1. After sending a Money Request IOU Messages are wrong on Both Sender & Receiver chats. Email is shown instead of the name

2. Settled up preview is not updated properly
3. (2) Causes overlapping tick (✅ ) with disclosure Indicator (arrow)

[luacmartins]

Created #19907