fix: 19920 image opens always with loading spinner #20545

tienifr · 2023-06-09T19:02:09Z

Details

Fixed Issues

$ #19920
PROPOSAL: #19920 (comment)

Tests

Open the App
Login with any account
Go to any chat
Send a jpg image
Open the image you just sent in the preview
Verify jpg image opens the first time with the loading spinner, but the next times without it

Verify that no errors appear in the JS console

Offline tests

same as above

QA Steps

Open the App
Login with any account
Go to any chat
Send a jpg image
Open the image you just sent in the preview
Verify jpg image opens the first time with the loading spinner, but the next times without it

Note When opening the images on Android native, the previews keep loading forever, this issue will be fixed after the PR is merged, so we can ignore testing on Android native

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-06-10.at.01.32.20.mp4

Mobile Web - Chrome

original-B2DCCE09-20C5-48D9-95AD-C2D9B24B42B8.mp4

Mobile Web - Safari

original-64045AF2-C94C-420F-B3AA-FBDE10477EAB.mp4

Desktop

Screen.Recording.2023-06-10.at.01.44.24.mp4

iOS

Screen.Recording.2023-06-07.at.14.54.20.mov

Android

Screen.Recording.2023-06-10.at.02.00.55.mov

s77rt · 2023-06-09T23:42:59Z

Is this ready for review?

melvin-bot · 2023-06-11T17:20:33Z

@bondydaa @s77rt One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2023-06-11T17:21:00Z

@s77rt Yes, can you help review? Thanks

s77rt · 2023-06-12T15:15:09Z

I think this creates the forever preview bug. Probably same as #16046 but now it happens even without cycling. @bondydaa Do you think we should move ahead anyway? This bug will be handled on #16046

Kooha-2023-06-12-16-11-38.mp4

bondydaa · 2023-06-12T15:54:21Z

Umm with not a lot of context it seems like it's the same problem, we could either hold until #18997 is merged or just test this PR against that by pulling in the changes to confirm it's not something else.

bondydaa

i think just remove the outdated comment then we'll be 👍 .

bondydaa · 2023-06-12T15:55:26Z

src/components/ImageView/index.native.js

@@ -104,23 +104,21 @@ class ImageView extends PureComponent {
     */
    configureImageZoom({nativeEvent}) {
        // Wait till animations are over to prevent stutter in navigation animation


I think this is now outdated right, it was the reason for why were using InteractionManager?

s77rt · 2023-06-12T17:00:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

mweb-chrome.mp4

Mobile Web - Safari

mweb-safari.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

This is bugged at the moment, will be fixed separately
https://github.com/Expensify/App/assets/16493223/9a2fc091-a240-4e51-a429-1b59b7209664

s77rt · 2023-06-13T12:24:21Z

@tienifr Did you check if the mentioned bug would be fixed after #18997

s77rt · 2023-06-13T17:06:52Z

Also please add a note for the QA team that the android test here is broken and can be skipped

tienifr · 2023-06-14T08:50:55Z

@s77rt I think #18997 will fix the loading forever on Android. Here's my result

Screen.Recording.2023-06-14.at.15.43.13.mov

s77rt · 2023-06-14T11:19:32Z

The android bug may need further work, the bug is probably coming from the patch https://github.com/Expensify/App/blob/main/patches/react-native-fast-image%2B8.6.3.patch
Either way not a regression so I think we can get this merged.

Edit: I think the plan is to remove the patch and have our own forked repo.

s77rt

LGTM! 🚀

cc @bondydaa

OSBotify · 2023-06-14T13:27:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-14T21:25:41Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.28-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

OSBotify · 2023-06-16T18:40:48Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: 19920 image opens always with loading spinner

a856f9e

tienifr mentioned this pull request Jun 9, 2023

[HOLD for payment 2023-06-23] [$1000] Android/iOS - Chat - jpg image opens always with loading spinner in preview #19920

Closed

6 tasks

tienifr marked this pull request as ready for review June 11, 2023 17:20

tienifr requested a review from a team as a code owner June 11, 2023 17:20

melvin-bot bot requested review from bondydaa and s77rt and removed request for a team June 11, 2023 17:20

bondydaa assigned tienifr Jun 12, 2023

bondydaa suggested changes Jun 12, 2023

View reviewed changes

fix: remove outdated comment

58b6e2e

s77rt approved these changes Jun 14, 2023

View reviewed changes

bondydaa approved these changes Jun 14, 2023

View reviewed changes

bondydaa merged commit 78145cf into Expensify:main Jun 14, 2023

OSBotify mentioned this pull request Jun 14, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 19920 image opens always with loading spinner #20545

fix: 19920 image opens always with loading spinner #20545

tienifr commented Jun 9, 2023 •

edited

Loading

s77rt commented Jun 9, 2023

melvin-bot bot commented Jun 11, 2023

tienifr commented Jun 11, 2023

s77rt commented Jun 12, 2023

bondydaa commented Jun 12, 2023

bondydaa left a comment

bondydaa Jun 12, 2023

s77rt commented Jun 12, 2023 •

edited

Loading

s77rt commented Jun 13, 2023

s77rt commented Jun 13, 2023

tienifr commented Jun 14, 2023

s77rt commented Jun 14, 2023 •

edited

Loading

s77rt left a comment

OSBotify commented Jun 14, 2023

OSBotify commented Jun 14, 2023

OSBotify commented Jun 16, 2023

fix: 19920 image opens always with loading spinner #20545

fix: 19920 image opens always with loading spinner #20545

Conversation

tienifr commented Jun 9, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

s77rt commented Jun 9, 2023

melvin-bot bot commented Jun 11, 2023

tienifr commented Jun 11, 2023

s77rt commented Jun 12, 2023

bondydaa commented Jun 12, 2023

bondydaa left a comment

Choose a reason for hiding this comment

bondydaa Jun 12, 2023

Choose a reason for hiding this comment

s77rt commented Jun 12, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

s77rt commented Jun 13, 2023

s77rt commented Jun 13, 2023

tienifr commented Jun 14, 2023

s77rt commented Jun 14, 2023 • edited Loading

s77rt left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 14, 2023

OSBotify commented Jun 14, 2023

OSBotify commented Jun 16, 2023

tienifr commented Jun 9, 2023 •

edited

Loading

s77rt commented Jun 12, 2023 •

edited

Loading

s77rt commented Jun 14, 2023 •

edited

Loading