Theme switching: Create theme/styling hooks and context components #21667

chrispader · 2023-06-27T11:05:24Z

@grgia

Details

Fixed Issues

$ #21019
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Verify that no errors appear in the JS console

Use demo code from this branch to test these changes.
Start NewDot
Check if theme for Sidebaris changing in an interval of 3 seconds

Offline tests

Not needed.

QA Steps

No QA

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-05.at.15.21.08.mov

Mobile Web - Chrome

Screen_Recording_20230705_153108_Chrome.mp4

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.Pro.16.2.-.2023-07-05.at.15.23.49.mp4

Desktop

Screen.Recording.2023-07-05.at.15.34.20.mov

iOS

Simulator.Screen.Recording.-.iPhone.14.Pro.16.2.-.2023-07-05.at.15.04.46.mp4

Android

Screen_Recording_20230705_153756_New.Expensify.mp4

chrispader · 2023-07-13T06:37:59Z

@Santhosh-Sellavel i resolved your change requests :)

shawnborton · 2023-07-13T12:02:45Z

I noticed some of the colors seem off. Where is the best place to provide that feedback?

grgia · 2023-07-13T12:15:15Z

@shawnborton we haven't added the theme yet, I'll get a PR up for that next week so we can QA the new theme

shawnborton · 2023-07-13T12:16:42Z

Sounds good!

Santhosh-Sellavel

LGTM!

Santhosh-Sellavel · 2023-07-13T17:18:35Z

@grgia wait

Santhosh-Sellavel

Otherwise Fine, cc: @grgia. Feel free to merge post this change

src/styles/themes/useThemePreference.js

Santhosh-Sellavel

LGTM, all yours @grgia!

grgia

ALRIGHT let's goooo

Santhosh-Sellavel · 2023-07-14T11:50:23Z

@grgia Assign me issue for tracking

OSBotify · 2023-07-14T11:53:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-14T15:00:38Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.41-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-17T19:38:23Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-07-17T19:39:23Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.42-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	cancelled 🔪

OSBotify · 2023-07-17T22:04:15Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-19T18:01:08Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

c3024 · 2024-02-04T16:43:53Z

src/styles/themes/useThemePreference.js

+import {PreferredThemeContext} from '../../components/OnyxProvider';
+
+function useThemePreference() {
+    const [themePreference, setThemePreference] = useState(CONST.THEME.DEFAULT);


Setting a default value for themePreference as a state variable and then updating it in useEffect caused an unnecessary (and then cancelled) network request here #34669

Christoph Pader and others added 30 commits March 28, 2023 10:20

Implement ThemeProvider with only one animated color (WIP)

7d538de

Wrap app with ThemeProvider

92b9835

use animated color for app background

7aa60de

add change listener to useIsLightMode

288160e

Removing shouldKeyReportActionsByID

81f2f94

Merge branch 'main' into @chrispader/theme-switching

fb3b662

fix: wrong imports

564e5b0

move hooks to actual function body

774856d

fix: missing React import

866344a

add flex 1

63e8323

fix: move ThemeProvider into ComposeProviders

1d9c20c

Merge branch 'main' into @chrispader/theme-switching

55b04f7

subscribe to system color theme and add ONYXKEY

5c2ad33

update ThemeProvider

fc0c32d

chore: update reanimated

6122a37

add missing useEffect dependency

1a20110

remove color animation from NavigationRoot

9d8aafd

move reanimated babel plugin to last position

bf67d21

Add theme switching button to Expensify main component

8adeef7

Add color animation to ReportScreen

698ae62

update reanimated again

5f0c824

downgrade rea to 3.0.0

26d12a1

move animation test to Expensify component

a4d11b0

update REA

71d6744

add patch for reanimated bug (react-navigation/react-navigation#11289)

1b7a1a9

add random view with animated color

f340e6f

downgrade cocoapods version

798f57a

use ComposeProviders for ThemeProvider

fb722f2

extract theme color interpolation into hook

d294ea7

use default dark colors as ThemeContext default value

cd481d5

chrispader added 2 commits July 13, 2023 08:32

add PreferredThemeProvider

51ab4d4

remove Onyx.connect and add comment

74ec10f

grgia previously approved these changes Jul 13, 2023

View reviewed changes

Santhosh-Sellavel approved these changes Jul 13, 2023

View reviewed changes

melvin-bot bot requested a review from grgia July 13, 2023 17:17

Santhosh-Sellavel suggested changes Jul 13, 2023

View reviewed changes

src/styles/themes/useThemePreference.js Outdated Show resolved Hide resolved

chrispader added 2 commits July 14, 2023 11:37

Merge branch 'main' into @chrispader/theme-switching

fa306fc

remove unused import

73935f0

chrispader dismissed grgia’s stale review via 73935f0 July 14, 2023 09:38

Santhosh-Sellavel approved these changes Jul 14, 2023

View reviewed changes

grgia approved these changes Jul 14, 2023

View reviewed changes

grgia merged commit 12d8a3f into Expensify:main Jul 14, 2023

OSBotify mentioned this pull request Jul 14, 2023

Deploy Checklist: New Expensify 2023-07-14 #22896

Closed

45 tasks

OSBotify mentioned this pull request Jul 17, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

melvin-bot bot mentioned this pull request Jul 17, 2023

[HOLD for payment 2023-07-24] Create theme/styling hooks and context components #21019

Closed

c3024 reviewed Feb 4, 2024

View reviewed changes

c3024 mentioned this pull request Feb 4, 2024

[HOLD for payment 2024-02-07] [$500] Web - Chat - There is a cancelled request where isDarkMode=true is present #34669

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Theme switching: Create theme/styling hooks and context components #21667

Theme switching: Create theme/styling hooks and context components #21667

chrispader commented Jun 27, 2023 •

edited

Loading

chrispader commented Jul 13, 2023

shawnborton commented Jul 13, 2023

grgia commented Jul 13, 2023

shawnborton commented Jul 13, 2023

Santhosh-Sellavel left a comment

Santhosh-Sellavel commented Jul 13, 2023

Santhosh-Sellavel left a comment

Santhosh-Sellavel left a comment

grgia left a comment

Santhosh-Sellavel commented Jul 14, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

c3024 Feb 4, 2024

Theme switching: Create theme/styling hooks and context components #21667

Theme switching: Create theme/styling hooks and context components #21667

Conversation

chrispader commented Jun 27, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

chrispader commented Jul 13, 2023

shawnborton commented Jul 13, 2023

grgia commented Jul 13, 2023

shawnborton commented Jul 13, 2023

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Santhosh-Sellavel commented Jul 13, 2023

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

grgia left a comment

Choose a reason for hiding this comment

Santhosh-Sellavel commented Jul 14, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

c3024 Feb 4, 2024

Choose a reason for hiding this comment

chrispader commented Jun 27, 2023 •

edited

Loading