Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signin page layout #2196

Merged
merged 49 commits into from
Apr 12, 2021
Merged
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
1ed958a
added flex: 1 to set password page
jasperhuangg Mar 19, 2021
91580d5
Make set password page UI more similar to sign in page UI
jasperhuangg Mar 22, 2021
c2d8015
fix eslint
jasperhuangg Mar 22, 2021
f6b1ef6
dry up and reduce the number of components
jasperhuangg Mar 23, 2021
12b3938
fix styles
jasperhuangg Mar 23, 2021
fc2808e
fix jsx style
jasperhuangg Mar 23, 2021
de2ab03
remove accidentally committed files
jasperhuangg Mar 24, 2021
09678ef
Revert "remove accidentally committed files"
jasperhuangg Mar 24, 2021
451bb16
revert to master versions
jasperhuangg Mar 24, 2021
47cf198
refactor based on PR comments
jasperhuangg Mar 24, 2021
61a0a2f
Update WelcomeText.js
jasperhuangg Mar 24, 2021
436cfd1
remove unused eslint-disable
jasperhuangg Mar 24, 2021
42ca8e8
revert SetPasswordPage.js
jasperhuangg Mar 24, 2021
8ebaf84
Merge branch 'jasper-fixSetPasswordPageFlex' of github.com:Expensify/…
jasperhuangg Mar 24, 2021
6d56db5
move SetPasswordPage.js to new folder
jasperhuangg Mar 24, 2021
f9e1fe6
modify SetPasswordPage.js with new refactor
jasperhuangg Mar 24, 2021
9491840
fix exporting component
jasperhuangg Mar 24, 2021
9a362da
remove unused onyx
jasperhuangg Mar 24, 2021
8db75cc
put with onyx back
jasperhuangg Mar 24, 2021
6b6c43f
Refactor everything into a single component
jasperhuangg Mar 25, 2021
88733cd
Merge branch 'master' into jasper-fixSetPasswordPageFlex
jasperhuangg Mar 25, 2021
ea5b973
Eslint fix
jasperhuangg Mar 25, 2021
3330380
Merge remote-tracking branch 'origin/jasper-fixSetPasswordPageFlex' i…
jasperhuangg Mar 25, 2021
461aef6
Fix import
jasperhuangg Mar 25, 2021
8dc41d2
Use compose
jasperhuangg Mar 26, 2021
5bef9a1
Add displayName
jasperhuangg Mar 26, 2021
f534f06
Use ...windowDimensionsPropTypes
jasperhuangg Mar 26, 2021
ade55fb
Revert stuff changed by --fix
jasperhuangg Mar 26, 2021
c7382e1
Revert stuff changed by --fix
jasperhuangg Mar 26, 2021
a658b53
Revert back into multiple components to fix layout on wide native dev…
jasperhuangg Mar 31, 2021
cc0ebcd
Fix ESLint
jasperhuangg Mar 31, 2021
e6a3604
Revert "Fix ESLint"
jasperhuangg Apr 1, 2021
951f4fb
Revert "Revert back into multiple components to fix layout on wide na…
jasperhuangg Apr 1, 2021
5b48bd0
Refactored back into single components, change SigninPageLayout so it…
jasperhuangg Apr 1, 2021
19684a4
Fix indent
jasperhuangg Apr 1, 2021
c265e20
Remove duplicate text
jasperhuangg Apr 1, 2021
772c92a
Refactor SigninPageLayout to be used with single component forms (wit…
jasperhuangg Apr 1, 2021
4a33ff8
Revert changes unrelated to PR
jasperhuangg Apr 1, 2021
02888dc
Revert changes unrelated to PR
jasperhuangg Apr 1, 2021
8b4b649
Merge branch 'master' of github.com:Expensify/Expensify.cash into jas…
jasperhuangg Apr 1, 2021
7770bd3
Refactor SignInPageLayout
jasperhuangg Apr 1, 2021
13547df
Merge master to use WelcomeText component
jasperhuangg Apr 2, 2021
16398f2
Rename props, remove unused HOC/props, rename style
jasperhuangg Apr 5, 2021
636437e
remove unused wrapper
jasperhuangg Apr 5, 2021
0e3d526
Merge branch 'master' of github.com:Expensify/Expensify.cash into jas…
jasperhuangg Apr 8, 2021
636f241
Add padding for iOS set password views
jasperhuangg Apr 8, 2021
77abbcc
style
jasperhuangg Apr 8, 2021
dfb9a98
Merge branch 'master' of github.com:Expensify/Expensify.cash into jas…
jasperhuangg Apr 9, 2021
ad5f871
Fix PropType usage
jasperhuangg Apr 12, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Eslint fix
  • Loading branch information
jasperhuangg committed Mar 25, 2021
commit ea5b9734bf43795715e9a40b4c7bc3ae3f1cb119
1 change: 0 additions & 1 deletion src/pages/SetPasswordPage.js
Original file line number Diff line number Diff line change
@@ -54,7 +54,6 @@ const defaultProps = {
};

class SetPasswordPage extends React.Component {

constructor(props) {
super(props);
this.submitForm = this.submitForm.bind(this);