Add action for anonymous user #22321

dukenv0307 · 2023-07-06T04:02:28Z

Details

We accept some actions for anonymous user

Fixed Issues

$ #21977
PROPOSAL: #21977 (comment)

Tests

Login with any account
Create a public room
Go to share code and copy the link of the room
Sign out and open the public room with the link above
Click on the header
Go to share code
Verify that the share code page appears instead of redirecting to sign in page
Hover any message and click on copy to clipboard
Verify that the user can copy this message to clipboard and not redirect to sign page
Hover on an attachment and click on download
Verify that the user can download successfully

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Login with any account
Create a public room
Go to share code and copy the link of the room
Sign out and open the public room with the link above
Click on the header
Go to share code
Verify that the share code page appears instead of redirecting to sign in page
Hover any message and click on copy to clipboard
Verify that the user can copy this message to clipboard and not redirect to sign page
Hover on an attachment and click on download
Verify that the user can download successfully

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.from.12-07-2023.10.31.49.webm

Mobile Web - Chrome

Record_2023-07-12-11-10-46.mp4

Mobile Web - Safari

safari.mp4

Desktop

desktop.2.mp4

iOS

ios.2.mp4

Android

21977.mp4

melvin-bot · 2023-07-06T08:49:10Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-07-06T08:55:04Z

Oh, I was under the impression that adding isAnonymousAction = false would make sure this logic wouldn't break anything,

@Santhosh-Sellavel I think we don't need to update the test steps for other pages that use checkIfActionIsAllowed function, because isAnonymousAction prop has default is false, the result of the condition doesn't change in checkIfActionIsAllowed function if we decide the action of other pages still are not anonymous action.

Santhosh-Sellavel · 2023-07-06T16:33:03Z

@dukenv0307 I think you don't understand.
What are the other pages that use checkIfActionIsAllowed, please gather that!

We don't need to make sure that the action can be performed by the anonymous user or not. And handle it where we can allow it.

Here is another similar duplicate issue. It does not use the checkIfActionIsAllowed, a similar method is written in the file there.

Do you get it?

cc: @PauloGasparSv

dukenv0307 · 2023-07-06T16:58:40Z

@Santhosh-Sellavel Thank you for your explanation. I got it for now. So we should discuss to decide whether we want to allow it or not for now, right? Correct me if I missed something.

Santhosh-Sellavel · 2023-07-06T17:10:07Z

Yes please investigate give us a list of such actions. We can decide and proceed

Santhosh-Sellavel · 2023-07-06T17:10:51Z

Also if you run into any similar issues please tag and ask them to hold for this.

dukenv0307 · 2023-07-06T17:34:45Z

@Santhosh-Sellavel Here is the list of actions that an anonymous user can perform. Please help to check again if I miss some actions.

Copy to clipboard
Mark as unread
reaction
reply in thread
flag as offensive
Open share code page
Leave room
Pin the room
Start a call
Setting room
Go to search page
New chat
New group
New workspace
Request money
Split bill
Send money
Assign task

Santhosh-Sellavel · 2023-07-06T17:37:02Z

Anywhere else a related check is used? @dukenv0307

Santhosh-Sellavel · 2023-07-06T17:38:39Z

Thanks @dukenv0307

l Here is the list of actions that an anonymous user can perform. Please help to check again if I miss some actions.

Copy to clipboard

Mark as unread

reaction

reply in thread

flag as offensive

Open share code page

Leave room

Pin the room

Start a call

Setting room

Go to search page

cc: @PauloGasparSv Let me know what is allowed and what is not, thanks!

dukenv0307 · 2023-07-06T17:40:58Z

Anywhere else a related check is used? @dukenv0307

The actions in FAB also use the check, but I think we don't need to take care of this because it must sign in to create action.

Santhosh-Sellavel · 2023-07-06T18:43:39Z

Anywhere else a related check is used? @dukenv0307

The actions in FAB also use the check, but I think we don't need to take care of this because it must sign in to create action.

Cool just list all places we do the check so we don't miss anything, and let's wait for @PauloGasparSv and proceed with changes, thanks!

dukenv0307 · 2023-07-07T02:14:30Z

@Santhosh-Sellavel Updated it here.

Santhosh-Sellavel · 2023-07-07T18:14:44Z

@PauloGasparSv Please review this when you got a chance so we can moveforward, thanks!

PauloGasparSv · 2023-07-07T18:32:05Z

@PauloGasparSv Please review #22321 (comment) when you got a chance so we can moveforward, thanks!

Sure thing, I have to focus on a couple of other issues first so I may only have time to review this on Monday though

PauloGasparSv · 2023-07-10T13:49:12Z

Thks so much for this @dukenv0307 (and @Santhosh-Sellavel too)

I'll try to review the list today and maybe tag some people that first worked on the anonymous user logic to review this too.

Btw, sorry for the delay but now we have some conflicts here. Can you please resolve them when you get the chance @dukenv0307?

dukenv0307 · 2023-07-10T14:18:35Z

@PauloGasparSv I just updated, please help to review

dukenv0307 · 2023-07-11T03:16:06Z

@PauloGasparSv That makes sense to me. For now, I think we can fix this issue and fix it #22307 too.

dukenv0307 · 2023-07-11T13:27:23Z

@Santhosh-Sellavel We have another issue about anonymous action here #22638.

PauloGasparSv · 2023-07-11T13:34:15Z

@PauloGasparSv That makes sense to me. For now, I think we can fix this issue and fix it #22307 too.

@Santhosh-Sellavel We have another issue about anonymous action here #22638.

Thks so much for catching those, I think @Santhosh-Sellavel already commented in one of them so I'll do the same for #22638

Can you add a fix for those 2 here? (I don't think we fixed them already right?)

@Santhosh-Sellavel bump on this for fixing the original issue + #22638 and #22307 this time since these are the reported issues so far.

dukenv0307 · 2023-07-11T13:39:46Z

I will add the fix for this soon.

dukenv0307 · 2023-07-11T14:08:26Z

@PauloGasparSv I updated the fix for #22638 and #22307. I will complete the test steps and screenshots for this tomorrow.

dukenv0307 · 2023-07-12T09:46:20Z

@Santhosh-Sellavel I updated the test steps and screenshots for other issues completely. Please help me to continue reviewing the PR when you have a chance.

Santhosh-Sellavel · 2023-07-12T19:14:28Z

@PauloGasparSv @dukenv0307 Can we also include the option to copy the URL from the share code page as it makes more sense?

Santhosh-Sellavel · 2023-07-12T19:14:50Z

Screen.Recording.2023-07-13.at.12.42.51.AM.mov

PauloGasparSv · 2023-07-12T19:26:36Z

@PauloGasparSv @dukenv0307 Can we also include the option to copy the URL from the share code page as it makes more sense?

Yesss! I thought this was fixed already since it was mentioned here btw : )

dukenv0307 · 2023-07-13T02:48:46Z

@Santhosh-Sellavel Do you think we should accept the option to download the QR on native?

dukenv0307 · 2023-07-13T02:51:59Z

@Santhosh-Sellavel I updated, please help to check again.

Santhosh-Sellavel · 2023-07-14T12:48:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-14.at.6.11.11.PM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-07-14.at.6.13.39.PM.mov

Desktop

Screen.Recording.2023-07-14.at.6.20.29.PM.mov

iOS & Android

Screen.Recording.2023-07-14.at.6.11.48.PM.mov

Santhosh-Sellavel

LGTM, thanks @dukenv0307!

All yours @PauloGasparSv!

PauloGasparSv

LGTM!

Had a lot of problems testing in other platforms because of my setup here so skipped most.

Web

Web.mov

Mobile Web - Safari

mweb.ios.mov

OSBotify · 2023-07-14T18:56:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-17T19:38:53Z

🚀 Deployed to staging by https://github.com/PauloGasparSv in version: 1.3.42-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	cancelled 🔪

OSBotify · 2023-07-19T18:00:38Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

sobitneupane · 2023-10-09T08:26:13Z

src/pages/home/report/ContextMenu/ContextMenuActions.js

@@ -130,6 +133,7 @@ export default [
        getDescription: () => {},
    },
    {
+        isAnonymousAction: false,


In this issue, we decided to allow anonymous user to copy url and email.

dukenv0307 added 6 commits July 5, 2023 10:09

accept the anonymous user go to share code page

89d3363

Merge branch 'main' into fix/21977

e54bcde

add anonymous action

238bbc7

fix lint

0979f31

add JSDoc for parameter isAnonymousAction

20e1b08

format code

62d61aa

dukenv0307 marked this pull request as ready for review July 6, 2023 08:49

dukenv0307 requested a review from a team as a code owner July 6, 2023 08:49

melvin-bot bot removed the request for review from a team July 6, 2023 08:49

melvin-bot bot requested a review from Santhosh-Sellavel July 6, 2023 08:49

dukenv0307 mentioned this pull request Jul 6, 2023

[HOLD for payment 2023-07-26] [$1000] Public room bug- Page redirects to sign in page instead of relevant page (on button click) #21977

Closed

6 tasks

merge main

2d8fb6d

PauloGasparSv self-requested a review July 7, 2023 18:31

merge main

3dceed4

PauloGasparSv mentioned this pull request Jul 11, 2023

[HOLD - #21977] Web - Users can download attachments when viewing attachment previews as anonymous users #22638

Closed

6 tasks

dukenv0307 added 3 commits July 11, 2023 20:50

merge main

a089c5f

merge branch

9a98272

add anonymous action for context menu

f985777

dukenv0307 added 2 commits July 12, 2023 11:05

fix anonymous action on native

0afd55b

add default prop

e6007ea

accept action in share code page for anonymous user

a61d7b0

fix lint

76d0f63

Santhosh-Sellavel approved these changes Jul 14, 2023

View reviewed changes

PauloGasparSv approved these changes Jul 14, 2023

View reviewed changes

PauloGasparSv merged commit fe4df5d into Expensify:main Jul 14, 2023

OSBotify mentioned this pull request Jul 17, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

sobitneupane reviewed Oct 9, 2023

View reviewed changes

sobitneupane mentioned this pull request Oct 9, 2023

[HOLD for payment 2023-10-10] [$500] Public room - Unable to copy link as an anonymous user #27039

Closed

6 tasks

dukenv0307 mentioned this pull request Nov 3, 2023

[$500] Public Room-Anonymous user can download images #30806

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add action for anonymous user #22321

Add action for anonymous user #22321

dukenv0307 commented Jul 6, 2023 •

edited

Loading

melvin-bot bot commented Jul 6, 2023

dukenv0307 commented Jul 6, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 6, 2023

dukenv0307 commented Jul 6, 2023

Santhosh-Sellavel commented Jul 6, 2023

Santhosh-Sellavel commented Jul 6, 2023

dukenv0307 commented Jul 6, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 6, 2023

Santhosh-Sellavel commented Jul 6, 2023

dukenv0307 commented Jul 6, 2023

Santhosh-Sellavel commented Jul 6, 2023

dukenv0307 commented Jul 7, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 7, 2023

PauloGasparSv commented Jul 7, 2023

PauloGasparSv commented Jul 10, 2023

dukenv0307 commented Jul 10, 2023

dukenv0307 commented Jul 11, 2023

dukenv0307 commented Jul 11, 2023

PauloGasparSv commented Jul 11, 2023 •

edited

Loading

dukenv0307 commented Jul 11, 2023

dukenv0307 commented Jul 11, 2023

dukenv0307 commented Jul 12, 2023

Santhosh-Sellavel commented Jul 12, 2023

Santhosh-Sellavel commented Jul 12, 2023

PauloGasparSv commented Jul 12, 2023

dukenv0307 commented Jul 13, 2023

dukenv0307 commented Jul 13, 2023

Santhosh-Sellavel commented Jul 14, 2023 •

edited

Loading

Santhosh-Sellavel left a comment

PauloGasparSv left a comment

OSBotify commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

sobitneupane Oct 9, 2023

Add action for anonymous user #22321

Add action for anonymous user #22321

Conversation

dukenv0307 commented Jul 6, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 6, 2023

dukenv0307 commented Jul 6, 2023 • edited Loading

Santhosh-Sellavel commented Jul 6, 2023

dukenv0307 commented Jul 6, 2023

Santhosh-Sellavel commented Jul 6, 2023

Santhosh-Sellavel commented Jul 6, 2023

dukenv0307 commented Jul 6, 2023 • edited Loading

Santhosh-Sellavel commented Jul 6, 2023

Santhosh-Sellavel commented Jul 6, 2023

dukenv0307 commented Jul 6, 2023

Santhosh-Sellavel commented Jul 6, 2023

dukenv0307 commented Jul 7, 2023 • edited Loading

Santhosh-Sellavel commented Jul 7, 2023

PauloGasparSv commented Jul 7, 2023

PauloGasparSv commented Jul 10, 2023

dukenv0307 commented Jul 10, 2023

dukenv0307 commented Jul 11, 2023

dukenv0307 commented Jul 11, 2023

PauloGasparSv commented Jul 11, 2023 • edited Loading

dukenv0307 commented Jul 11, 2023

dukenv0307 commented Jul 11, 2023

dukenv0307 commented Jul 12, 2023

Santhosh-Sellavel commented Jul 12, 2023

Santhosh-Sellavel commented Jul 12, 2023

PauloGasparSv commented Jul 12, 2023

dukenv0307 commented Jul 13, 2023

dukenv0307 commented Jul 13, 2023

Santhosh-Sellavel commented Jul 14, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

PauloGasparSv left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

sobitneupane Oct 9, 2023

Choose a reason for hiding this comment

dukenv0307 commented Jul 6, 2023 •

edited

Loading

dukenv0307 commented Jul 6, 2023 •

edited

Loading

dukenv0307 commented Jul 6, 2023 •

edited

Loading

dukenv0307 commented Jul 7, 2023 •

edited

Loading

PauloGasparSv commented Jul 11, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 14, 2023 •

edited

Loading