Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix change language also trigger submit Sign in validation form when magic codes are fullfilled #22781

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Fix change language also trigger submit Sign in validation form when magic codes are fullfilled #22781

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0535891
Avoid magic code submit when onFulfill prop change
hoangzinh Jul 12, 2023
ec2fd2e
Update comment
hoangzinh Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/MagicCodeInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,11 @@ function MagicCodeInput(props) {
useEffect(() => {
validateAndSubmit();

// We have not added the editIndex as the dependency because we don't want to run this logic after focusing on an input to edit it after the user has completed the code.
// We have not added:
// + the editIndex as the dependency because we don't want to run this logic after focusing on an input to edit it after the user has completed the code.
// + the props.onFulfill as the dependency because props.onFulfill is changed when the preferred locale changed => avoid auto submit form when preferred locale changed.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [props.value, props.shouldSubmitOnComplete, props.onFulfill]);
}, [props.value, props.shouldSubmitOnComplete]);

useEffect(() => {
if (!props.autoFocus) {
Expand Down