Properly pass Android version code to fastlane #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGable
approved these changes
Apr 8, 2021
|
All yours @thienlnam ! |
thienlnam
approved these changes
Apr 8, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We weren't properly passing the version code to fastlane for the Android production deploy. It's pretty unclear how the Android production deploys were ever working, but we updated Fastlane so our best guess is that we were always passing
''as the version code, and Fastlane was just defaulting to the latest version. But now in their newer update they are type-checking the version code, so it's failing.Fixed Issues
Failed workflow run: https://github.com/Expensify/Expensify.cash/commit/2b3d906b8309142aa8a0d6edea876cc693171c4d/checks
Tests
Can only test by running a production deploy.