Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild GH actions #2300

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Rebuild GH actions #2300

merged 1 commit into from
Apr 8, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Fix failing workflow runs on master:

Example

What happened?

  1. @deetergp wrote a couple new actions
  2. Meanwhile, I made changes to the GithubUtils library
  3. His change was merged, and very soon after mine was merged. Neither PR had a failing check, because the PR that introduced the new actions was merged before the library code was changed. My PR didn't have a failing check because at the time the checks ran the new actions didn't exist.
  4. The result is that master has his new actions w/o the updated library code

@roryabraham roryabraham requested a review from a team as a code owner April 8, 2021 16:14
@roryabraham roryabraham self-assigned this Apr 8, 2021
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team April 8, 2021 16:14
@roryabraham
Copy link
Contributor Author

I don't really have any ideas for how to prevent this from happening in the future.

@AndrewGable
Copy link
Contributor

Merging to fix broken GitHub builds.

@AndrewGable AndrewGable merged commit 99a1a32 into master Apr 8, 2021
@AndrewGable AndrewGable deleted the Rory-FixGHActionsDiff branch April 8, 2021 17:32
@OSBotify OSBotify mentioned this pull request Apr 8, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes

@deetergp deetergp Awaiting requested review from deetergp

@joelbettner joelbettner Awaiting requested review from joelbettner

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roryabraham @AndrewGable