Fix magic code input border bottom does not turn red after receiving error from server #23101

bernhardoj · 2023-07-18T16:13:38Z

Details

The magic code input on secondary login does not turn the bottom border to red when receiving an error from the server.

Fixed Issues

$ #22187
PROPOSAL: #22187 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Requires internet connection

QA Steps

Prerequisite: have an unverified secondary login

Open Settings > Profile > Contact method
Select your unverified secondary login
Enter the wrong magic code in the input. Wait until the request/loading completes.
Verify an error text shows and the magic code input bottom border all turns to red.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-18.at.23.52.20.mov

Mobile Web - Chrome

Chrome.mp4

Mobile Web - Safari

Screen.Recording.2023-07-18.at.23.59.17.mov

Desktop

Screen.Recording.2023-07-19.at.00.00.55.mov

iOS

Screen.Recording.2023-07-18.at.23.57.14.mov

Android

Expensify.Chat.mp4

…error

melvin-bot · 2023-07-18T16:13:43Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2023-07-19T14:33:19Z

src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js

@@ -133,7 +135,8 @@ function BaseValidateCodeForm(props) {
                name="validateCode"
                value={validateCode}
                onChangeText={onTextInput}
-                errorText={formError.validateCode ? props.translate(formError.validateCode) : ErrorUtils.getLatestErrorMessage(props.account)}
+                errorText={formError.validateCode ? props.translate(formError.validateCode) : ''}


Do you confirm that there's no case of backend error coming from props.account?

Yes, there are no errors for props.account from BE

I checked and it's possible the backend sets an error in props.account in some edge cases, so let's keep it as it was before please

aimane-chnaif · 2023-07-21T00:08:10Z

2 odd behaviors:

Screen.Recording.2023-07-21.at.1.03.19.AM.mov

After wrong code input, input borders always red even though close and reopen this page, until delete error message.
No way to hide Link has been re-sent after click Didn't receive a magic code?

aimane-chnaif · 2023-07-21T00:19:52Z

I don't think those are blockers. Going ahead checklist

aimane-chnaif · 2023-07-21T00:21:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

Android

android.mov

aimane-chnaif

LGTM
@flodnv all yours!

flodnv · 2023-07-24T13:04:43Z

src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js

@@ -133,7 +135,8 @@ function BaseValidateCodeForm(props) {
                name="validateCode"
                value={validateCode}
                onChangeText={onTextInput}
-                errorText={formError.validateCode ? props.translate(formError.validateCode) : ErrorUtils.getLatestErrorMessage(props.account)}
+                errorText={formError.validateCode ? props.translate(formError.validateCode) : ''}


I checked and it's possible the backend sets an error in props.account in some edge cases, so let's keep it as it was before please

bernhardoj · 2023-07-24T13:09:22Z

@flodnv thanks for checking it! Added it back.

melvin-bot · 2023-07-24T13:20:33Z

@flodnv looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

flodnv · 2023-07-24T13:22:41Z

Hmmm, everything is passing

OSBotify · 2023-07-24T13:24:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-25T01:43:33Z

🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-26T15:53:04Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix magic code input border bottom does not turn red after receiving …

fe4396c

…error

bernhardoj requested a review from a team as a code owner July 18, 2023 16:13

melvin-bot bot requested review from aimane-chnaif and removed request for a team July 18, 2023 16:13

aimane-chnaif reviewed Jul 19, 2023

View reviewed changes

aimane-chnaif approved these changes Jul 21, 2023

View reviewed changes

melvin-bot bot requested a review from flodnv July 21, 2023 00:22

flodnv requested changes Jul 24, 2023

View reviewed changes

bernhardoj added 2 commits July 24, 2023 21:08

add back account error

ba6ce53

Merge branch 'main' into fix/22187-magic-code-error

3c2d469

flodnv approved these changes Jul 24, 2023

View reviewed changes

flodnv merged commit 4362a88 into Expensify:main Jul 24, 2023

melvin-bot bot added the Emergency label Jul 24, 2023

flodnv removed the Emergency label Jul 24, 2023

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

melvin-bot bot mentioned this pull request Jul 26, 2023

[Awaiting Checklist Completion] [$1000] Web – Contact Method – Dashes are not changing to red upon entering invalid magic code. #22187

Closed

6 tasks

aimane-chnaif mentioned this pull request Jul 28, 2023

[HOLD for payment 2023-08-21] [$1000] Contact Method – Input dashes remain red, instead turning to grey upon deletion of any number. #23756

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix magic code input border bottom does not turn red after receiving error from server #23101

Fix magic code input border bottom does not turn red after receiving error from server #23101

bernhardoj commented Jul 18, 2023

melvin-bot bot commented Jul 18, 2023

aimane-chnaif Jul 19, 2023

bernhardoj Jul 19, 2023

flodnv Jul 24, 2023

aimane-chnaif commented Jul 21, 2023

aimane-chnaif commented Jul 21, 2023

aimane-chnaif commented Jul 21, 2023

aimane-chnaif left a comment

flodnv Jul 24, 2023

bernhardoj commented Jul 24, 2023

melvin-bot bot commented Jul 24, 2023

flodnv commented Jul 24, 2023

OSBotify commented Jul 24, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

Fix magic code input border bottom does not turn red after receiving error from server #23101

Fix magic code input border bottom does not turn red after receiving error from server #23101

Conversation

bernhardoj commented Jul 18, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 18, 2023

aimane-chnaif Jul 19, 2023

Choose a reason for hiding this comment

bernhardoj Jul 19, 2023

Choose a reason for hiding this comment

flodnv Jul 24, 2023

Choose a reason for hiding this comment

aimane-chnaif commented Jul 21, 2023

aimane-chnaif commented Jul 21, 2023

aimane-chnaif commented Jul 21, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

flodnv Jul 24, 2023

Choose a reason for hiding this comment

bernhardoj commented Jul 24, 2023

melvin-bot bot commented Jul 24, 2023

flodnv commented Jul 24, 2023

OSBotify commented Jul 24, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023