-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Make text on native platforms non-selectable #2342
Conversation
Okay, fixed the font error ... I was doing |
Is this still being worked on? Should I review it even though it is a WIP? |
Honestly, this is pretty decayed at this point and never really worked on mWeb. Since this can be worked on externally, I'm actually going to close it out and we can get the original issue exported to Upwork. Hopefully the work in this PR can still be a reference for the contributor that's hired. |
Details
ReportActionItemCommentFragment
andReportActionItemTextFragment
, which are the same on web/desktop and native, with one difference. Native text is not selectable, while web/desktop text is selectable. This fixes the bug linked in the description, without breaking native copy/paste functionality on web/desktop, where most users would use a mouse instead of the context menu to copy/paste text anyways.longPress
would open theReportActionContextMenu
. I was able to fix this so that the firstlongPress
closes the keyboard and opens theReportActionContextMenu
in one go, using thekeyboardShouldPersistTaps
prop ofFlatList
(inherited fromScrollView
I believe).Fixed Issues
Fixes #2279
Tests / QA Steps (Web/Desktop)
ReportActionContextMenu
.ReportActionContextMenu
closes it.Tests / QA Steps (iOS/Android)
ReportActionContextMenu
opensReportActionContextMenu
ReportActionContextMenu
opens. You should not see the native platform's "copy" popup, as shown in the linked issue.ReportActionContextMenu
opens. You should not see the native platform's "copy" popup, as shown in the linked issue.Tests / QA Steps (mWeb)
On mobile web, this PR should cause no notable difference.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android