-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Fix: console warning by making innerRef optional to PressableWithDelayToggle #23717
[NoQA] Fix: console warning by making innerRef optional to PressableWithDelayToggle #23717
Conversation
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@@ -13,7 +13,7 @@ import useThrottledButtonState from '../../hooks/useThrottledButtonState'; | |||
|
|||
const propTypes = { | |||
/** Ref passed to the component by React.forwardRef (do not pass from parent) */ | |||
innerRef: PropTypes.oneOfType([PropTypes.func, PropTypes.shape({current: PropTypes.instanceOf(React.Component)})]).isRequired, | |||
innerRef: PropTypes.oneOfType([PropTypes.func, PropTypes.shape({current: PropTypes.instanceOf(React.Component)})]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jayeshmangwani could you please help me understand in which case React.forwardRef
won't pass a ref
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rushatgabhane Yes sure, the CopyTextToClipboard component uses the PressableWithDelayToggle Component as a child. And here, no ref passed to the PressableWithDelayToggle from CopyTextToClipboard so that the child component is getting the null value for innerRef And React.forwardRef
will pass null
value to ref
App/src/components/CopyTextToClipboard.js
Lines 23 to 32 in 6a38341
function CopyTextToClipboard(props) { | |
const copyToClipboard = useCallback(() => { | |
Clipboard.setString(props.text); | |
}, [props.text]); | |
return ( | |
<PressableWithDelayToggle | |
text={props.text} | |
tooltipText={props.translate('reportActionContextMenu.copyToClipboard')} | |
tooltipTextChecked={props.translate('reportActionContextMenu.copied')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Reviewer Checklist
Screenshots/Videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.51-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀
|
🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.52-0 🚀
|
🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.52-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀
|
Details
Fixed Issues
$ #23093
PROPOSAL: #23093 (comment)
Tests
Offline tests
Same As Tests
QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
mWeb-chrome.mp4
Mobile Web - Safari
mWeb-safari.mov
Desktop
desktop.mov
iOS
iOS.mov
Android
Android.mp4