Add SCREENS constants. Navigate without linkTo from drawer component. #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gonna throw this back into draft actually I think maybe the important bit is that we are not using the |
marcaaron
changed the title
undo a few things simplify solution add missing return
marcaaron
force-pushed
the
marcaaron-fixMobileWebUrl
branch
from
ffc443b to
81f5858
Compare
marcaaron
commented
Apr 14, 2021
|
This one is ready for a review. |
|
There are no visual changes but I will go test this on various platforms. |
roryabraham
approved these changes
Apr 14, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 [Deployed](https://github.com/Expensify/Expensify.cash
|
|
🚀 Deployed to production in version: 1.0.39-5🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Pretty weird issue, but starting to think
the navigation reflinkTo()is in some cases unreliable (at least when navigating from within the drawer). Switched topassing ausingnavigationobject to the drawer componentnavigationRef.navigate(screen, params)and URL handling works as intended on mobile web.Push state issue still remains.
Fixed Issues
Fixes #2188
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android