Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let parent component handle defaultValue and value in TextInputFocusable #2398

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

marcaaron
Copy link
Contributor

cc @stitesExpensify

Details

Fixing a regression with the TextInputFocusable

Fixed Issues (Comment)

#2203 (comment)

Tests

QA Steps

  1. Verify that report compose input works normally

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Apr 14, 2021
@marcaaron marcaaron requested a review from a team as a code owner April 14, 2021 19:25
@marcaaron marcaaron requested review from stitesExpensify and removed request for a team April 14, 2021 19:25
@marcaaron
Copy link
Contributor Author

Sorry @AndrewGable @sketchydroide PullerBear is drunk

@stitesExpensify
Copy link
Contributor

Tested 🟢

@stitesExpensify
Copy link
Contributor

waiting for tests

@marcaaron marcaaron merged commit 9fe5f57 into master Apr 14, 2021
@marcaaron marcaaron deleted the marcaaron-fixTextInputDefaultValue branch April 14, 2021 20:13
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants