Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure report appears for deep links that are not the Home route #2399

Merged
merged 5 commits into from
Apr 14, 2021
Merged

Make sure report appears for deep links that are not the Home route #2399

merged 5 commits into from
Apr 14, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Apr 14, 2021 •
edited
Loading

Details

Fixed Issues

Regression from code removed in https://github.com/Expensify/Expensify.cash/pull/2346/files

Tests

QA Steps

  1. Navigate directly to /settings
  2. Verify that the report + home screen is loaded in the background

Tested On

  • Web
  • Mobile Web
  • Desktop // No deep linking on Desktop so there's no need to test
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Apr 14, 2021
@marcaaron marcaaron marked this pull request as ready for review April 14, 2021 22:00
@marcaaron marcaaron requested a review from a team as a code owner April 14, 2021 22:00
@MelvinBot MelvinBot requested review from roryabraham and removed request for a team April 14, 2021 22:01
@marcaaron marcaaron changed the title Parse custom state for deep links that are not the Home route Make sure report appears for deep links that are not the Home route Apr 14, 2021
@marcaaron
Copy link
Contributor Author

This is ready for a review.

roryabraham
roryabraham approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and passed testing on (desktop) web

@roryabraham roryabraham merged commit a4aa60a into master Apr 14, 2021
@roryabraham roryabraham deleted the marcaaron-fixInitialState branch April 14, 2021 23:08
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@tugbadogan tugbadogan mentioned this pull request Apr 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcaaron @OSBotify @roryabraham