Disable Drag & Drop by default #24536

ginsuma · 2023-08-14T14:06:47Z

Details

Disable Drag & Drop by default.

Fixed Issues

$ #22218
PROPOSAL: #22218 (comment)

Tests

Open a report.
Drag an image to the browser and drag it to various places.
Verify that only the report actions view shows the copy (plus) cursor.
Click on the profile avatar to open RHP.
Drag an image to the browser and drag it to various places.
Verify that the cursor doesn't have copy (plus) style.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

6a53cdb9-17cd-4a2a-9a76-d7ea2aece48e.mp4

Mobile Web - Safari

original-17D3F1F9-832F-47C5-9CE5-F8B4CFD377F7.mp4

Mobile Web - Chrome

Screen.Recording.2023-08-14.at.8.35.09.PM.mov

Desktop

Screen.Recording.2023-08-14.at.7.58.06.PM.mov

iOS

Not support drag & drop on the native app.

Android

Not support drag & drop on the native app.

melvin-bot · 2023-08-14T14:06:52Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ginsuma · 2023-08-14T14:09:20Z

@allroundexperts Drag & Drop doesn't work in Android Chrome.

Screen.Recording.2023-08-14.at.8.35.09.PM.mov

allroundexperts · 2023-08-15T06:28:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-16.at.12.10.29.AM.mov

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

Screen.Recording.2023-08-16.at.12.16.34.AM.mov

iOS

N/A

Android

N/A

allroundexperts · 2023-08-15T17:11:47Z

web/index.html

+    function dropDragListener(){
+        event.preventDefault();
+        event.dataTransfer.dropEffect = 'none';
+    }
+    document.addEventListener('dragover', dropDragListener);
+    document.addEventListener('dragenter', dropDragListener);
+    document.addEventListener('dragleave', dropDragListener);
+    document.addEventListener('drop', dropDragListener);


@ginsuma Instead of here, can't we add it inside our App file? This would be more of a react way.

@allroundexperts We should add it for the web platform only.

Create a platform specific hook?

@allroundexperts I moved it to inside App.js file.

allroundexperts · 2023-08-15T17:54:22Z

src/App.js

+    useEffect(() => {
+        const platform = getPlatform();
+        if (platform !== CONST.PLATFORM.WEB && platform !== CONST.PLATFORM.DESKTOP) {
+            return;
+        }
+        document.addEventListener('dragover', dropDragListener);
+        document.addEventListener('dragenter', dropDragListener);
+        document.addEventListener('dragleave', dropDragListener);
+        document.addEventListener('drop', dropDragListener);
+    }, []);


We never use platform specific code inline like this @ginsuma. Please create separate files for each platform.

allroundexperts · 2023-08-15T18:15:02Z

src/App.js

    useEffect(() => {
-        const platform = getPlatform();
-        if (platform !== CONST.PLATFORM.WEB && platform !== CONST.PLATFORM.DESKTOP) {
-            return;
-        }
-        document.addEventListener('dragover', dropDragListener);
-        document.addEventListener('dragenter', dropDragListener);
-        document.addEventListener('dragleave', dropDragListener);
-        document.addEventListener('drop', dropDragListener);
+        setDefaultDragDropEvent();
    }, []);


How about creating a hook instead?

@allroundexperts I created useDefaultDragAndDrop hook.

allroundexperts · 2023-08-15T18:46:36Z

src/hooks/useDefaultDragAndDrop/index.js

+    useEffect(() => {
+        document.addEventListener('dragover', dropDragListener);
+        document.addEventListener('dragenter', dropDragListener);
+        document.addEventListener('dragleave', dropDragListener);
+        document.addEventListener('drop', dropDragListener);


Don't forget to unsubscribe these listeners.

allroundexperts · 2023-08-15T18:47:27Z

src/hooks/useDefaultDragAndDrop/index.js

+    const dropDragListener = (event) => {
+        event.preventDefault();
+        // eslint-disable-next-line no-param-reassign
+        event.dataTransfer.dropEffect = 'none';
+    };


Would be good to define this inside the effect as well.

allroundexperts · 2023-08-15T19:45:10Z

@ginsuma I'm encountering the following bug sometimes when I'm dragging over a no drop zone and then opening the LHN.

Screen.Recording.2023-08-16.at.12.42.21.AM.mov

Can you please confirm / fix?

allroundexperts · 2023-08-15T19:47:41Z

It would also be good if you can add more comprehensive test steps!

ginsuma · 2023-08-16T01:47:16Z

@ginsuma I'm encountering the following bug sometimes when I'm dragging over a no drop zone and then opening the LHN.

@allroundexperts I'm sorry. Could you tell me clearly what the bug is in the video?

Screen.Recording.2023-08-16.at.1.33.21.PM.mov

allroundexperts · 2023-08-16T09:03:22Z

@ginsuma Check the video from 38s onwards. Notice that after dragging, opening RHN closes it automatically.

ginsuma · 2023-08-16T09:16:19Z

@allroundexperts I can't reprocedure it 😥.

allroundexperts · 2023-08-16T09:17:04Z

I wasn't able to reproduce accurately as well. But it happens only some times.

allroundexperts · 2023-08-16T09:17:16Z

Seems like a race condition to me.

ginsuma · 2023-08-16T18:29:49Z

@allroundexperts Does it happen only for RHP? Have you tried to open an attachment modal instead? We need more clues.

allroundexperts · 2023-08-20T22:57:25Z

@ginsuma Can you merge main? I'll test this once more.

ginsuma · 2023-08-21T06:02:51Z

@ginsuma Can you merge main? I'll test this once more.

@allroundexperts I merged it and did a test one more time but couldn't reprocedure.

Screen.Recording.2023-08-21.at.12.57.12.PM.mp4

allroundexperts · 2023-08-22T00:04:01Z

@ginsuma Can you please merge main again? Thanks!

ginsuma · 2023-08-22T00:12:50Z

@ginsuma Can you please merge main again? Thanks!

@allroundexperts I merged.

allroundexperts · 2023-08-22T09:29:18Z

@ginsuma You need to sync your fork's main with Expensify's main and then merge your fork's main into this PR. I see that this PR is still not in sync with main.

ginsuma · 2023-08-22T09:38:45Z

@allroundexperts That's what I did, but there was an issue with Mapbox config a few hours ago. Now it's okay.

allroundexperts

Looks good.

allroundexperts · 2023-08-22T09:41:58Z

@ginsuma Can you merge main? I'll test this once more.

@allroundexperts I merged it and did a test one more time but couldn't reprocedure.

Screen.Recording.2023-08-21.at.12.57.12.PM.mp4

It's still happening but I was able to reproduce it on main as well. So we're good here!

deetergp

Code looks good and tests well on web.

melvin-bot · 2023-08-22T23:12:30Z

@deetergp looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2023-08-22T23:19:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-24T03:35:37Z

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.57-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-28T18:52:38Z

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-29T00:07:18Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.57-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:21:41Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ginsuma added 3 commits August 4, 2023 14:57

Fix drop drag zone

ca83e13

Merge branch 'main' into fix/22218

01c7776

Clean import

abb3964

ginsuma requested a review from a team as a code owner August 14, 2023 14:06

melvin-bot bot requested review from allroundexperts and removed request for a team August 14, 2023 14:06

ginsuma mentioned this pull request Aug 14, 2023

[HOLD for payment 2023-09-04] [$1000] Not allowed sign does not show when an attachment is drag and dropped #22218

Closed

6 tasks

allroundexperts reviewed Aug 15, 2023

View reviewed changes

Move to App.js

b7be1f2

allroundexperts reviewed Aug 15, 2023

View reviewed changes

Add setDefaultDragDropEvent

018a53d

allroundexperts reviewed Aug 15, 2023

View reviewed changes

Add useDefaultDragAndDrop

ced727a

ginsuma changed the title ~~Disable Drag & Drop everywhere~~ Disable Drag & Drop by default Aug 15, 2023

allroundexperts reviewed Aug 15, 2023

View reviewed changes

Update useDefaultDragAndDrop

7db1ba6

Merge branch 'main' into fix/22218

2c5d079

Merge branch 'main' into fix/22218

4c3fcce

ginsuma added 2 commits August 22, 2023 07:36

Merge branch 'main' into fix/22218

647017d

Merge branch 'main' into fix/22218

12cb0ac

Merge branch 'main' into fix/22218

2fd78bf

allroundexperts approved these changes Aug 22, 2023

View reviewed changes

melvin-bot bot requested a review from deetergp August 22, 2023 09:41

deetergp approved these changes Aug 22, 2023

View reviewed changes

deetergp merged commit 51d55de into Expensify:main Aug 22, 2023

melvin-bot bot added the Emergency label Aug 22, 2023

deetergp removed the Emergency label Aug 23, 2023

OSBotify mentioned this pull request Aug 24, 2023

Deploy Checklist: New Expensify 2023-08-24 #25813

Closed

73 tasks

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

Disable Drag & Drop by default #24536

Disable Drag & Drop by default #24536

Conversation

ginsuma commented Aug 14, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 14, 2023

ginsuma commented Aug 14, 2023

allroundexperts commented Aug 15, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

allroundexperts commented Aug 15, 2023

allroundexperts commented Aug 15, 2023

ginsuma commented Aug 16, 2023 • edited Loading

allroundexperts commented Aug 16, 2023

ginsuma commented Aug 16, 2023

allroundexperts commented Aug 16, 2023

allroundexperts commented Aug 16, 2023

ginsuma commented Aug 16, 2023

allroundexperts commented Aug 20, 2023

ginsuma commented Aug 21, 2023 • edited Loading

allroundexperts commented Aug 22, 2023

ginsuma commented Aug 22, 2023

allroundexperts commented Aug 22, 2023

ginsuma commented Aug 22, 2023

allroundexperts left a comment

Choose a reason for hiding this comment

allroundexperts commented Aug 22, 2023

deetergp left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 22, 2023

OSBotify commented Aug 22, 2023

OSBotify commented Aug 24, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

ginsuma commented Aug 14, 2023 •

edited

Loading

allroundexperts commented Aug 15, 2023 •

edited

Loading

ginsuma commented Aug 16, 2023 •

edited

Loading

ginsuma commented Aug 21, 2023 •

edited

Loading