[No QA] Allow distance requests to be viewed #24556

tgolen · 2023-08-14T20:52:06Z

Held on Display receipts in chat #24235 since it's the base branch for my changes

Details

This PR adds the ability to view distance requests.

Fixed Issues

$ #22712

Tests

This can only be tested by an internal engineer.

Log into NewDot and request money from another user. This will create a transaction
Log into OldDot and find that transaction and add a receipt to it
Find the transactionID (eg. while editing the expense, inspect g_megaEdit.expense.transactionID in the JS console)
From the CLI run scripts/sql.sh
Run the following query, substituting the transactionID from above in order to turn that transaction into a distance request

UPDATE transactions SET comment = '{"customUnit":{"customUnitID":"63601da0a9e55","customUnitRateID":"63601da0a9e58","quantity":"3.41","name":"Distance"},"type":"customUnit","comment":"The description of this distance request.", "waypoints":{"waypoint0":{"lat":37.7886378,"lng":-122.4055329,"address":"ExpensifyLounge,KearnyStreet,SanFrancisco,CA"},"waypoint1":{"lat":37.8040257,"lng":-122.4675914,"address":"CrissyField,1199EBeach,SanFrancisco,CA94129"}}}' WHERE transactionID = '<TRANSACTION_ID>';

Refresh/reload NewDot and view the transaction
Verify that it indicates it's a distance request as denoted by the word "Distance" above the amount

Verify that no errors appear in the JS console

Offline tests

You can do all of the above tests offline and it should work

QA Steps

This cannot be QAed yet.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

…requests

tgolen · 2023-08-17T21:09:12Z

I feel like I've got this PR in a good place, but there are too many conflicts with the base branch to keep it updated.

Once the base branch's PR is merged, this can be cleaned up and be ready to go really quickly.

tgolen · 2023-08-18T16:37:37Z

Still on hold for the upstream PR

…requests

allroundexperts

Needs to address some anomalies.

tgolen

@allroundexperts Thank you for the review!

I found an existing transactionPropTypes.js module that had all those other props that you noticed were missing. I've cleaned everything up now so that the transactionPropTypes.js are used in the four components. This should solve a lot of the issues you found. Let me know if I missed any!

tgolen · 2023-08-22T20:54:25Z

src/components/ReportActionItem/MoneyRequestPreview.js

@@ -196,7 +227,6 @@ function MoneyRequestPreview(props) {
    const childContainer = (
        <View>
            <OfflineWithFeedback
-                pendingAction={props.pendingAction}


I removed this because there is no pendingAction prop ever getting passed to this component and I figured it was a cleanup someone didn't catch.

allroundexperts

Code looks good to me!

Deferring the actual testing and the checklist to the internal engineers!

melvin-bot · 2023-08-22T21:52:33Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

arosiclair · 2023-08-23T13:29:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

arosiclair

Looks good just need to address conflicts

OSBotify · 2023-08-23T15:49:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-24T03:35:25Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.57-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-28T18:52:11Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-29T00:07:06Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.57-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:21:14Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2024-01-25T09:47:01Z

src/components/ReportActionItem/MoneyRequestPreview.js

@@ -186,6 +197,10 @@ function MoneyRequestPreview(props) {
    };

    const getDisplayAmountText = () => {
+        if (isDistanceRequest) {
+            return CurrencyUtils.convertToDisplayString(TransactionUtils.getAmount(props.transaction), props.transaction.currency);


We should've used requestCurrency here, otherwise we're always getting the currency set when the transaction was created. This caused #34066.

tgolen added 9 commits August 14, 2023 13:55

Remove unused prop

3225650

Add transaction subscription

648c9c2

Add a method to determine transaction type

d91b694

Add method for getting a receipt URL

8461763

Display header and amount

8600f5c

Remove duplicate method

613e662

Use the right description

f1a0e8e

Add receipt image component

58d7fe2

Merge branch 'main' into tgolen-surface-distance-requests

c56e962

tgolen mentioned this pull request Aug 16, 2023

[HOLD for payment 2023-09-04] Surface distance requests in App #22712

Closed

6 tasks

tgolen added 5 commits August 15, 2023 20:51

Properly format currency and images

d4b812e

Merge branch 'andrewli-displayreceipts' into tgolen-surface-distance-…

a652e3b

…requests

Fix whitespace

1817b39

Fix bad merge

c40ebae

Remove duplicate receipt image

49d669c

tgolen changed the title ~~Tgolen surface distance requests~~ [HOLD App/pull/24235] Tgolen surface distance requests Aug 18, 2023

tgolen self-assigned this Aug 18, 2023

neil-marcellini changed the base branch from main to andrewli-displayreceipts August 18, 2023 17:32

tgolen added 2 commits August 18, 2023 12:01

Merge branch 'andrewli-displayreceipts' into tgolen-surface-distance-…

87dffc8

…requests

Merge branch 'main' into tgolen-surface-distance-requests

a1a2f6a

tgolen changed the title ~~[HOLD App/pull/24235] Tgolen surface distance requests~~ [HOLD App/pull/24235] Allow distance requests to be viewed Aug 18, 2023

tgolen changed the title ~~[HOLD App/pull/24235] Allow distance requests to be viewed~~ [HOLD App/pull/24235] [No QA] Allow distance requests to be viewed Aug 18, 2023

Remove unused import

e442866

tgolen changed the base branch from andrewli-displayreceipts to main August 21, 2023 15:43

tgolen changed the base branch from main to andrewli-displayreceipts August 21, 2023 15:44

Merge branch 'andrewli-displayreceipts' into tgolen-surface-distance-…

49ddb10

…requests

tgolen marked this pull request as ready for review August 21, 2023 15:46

tgolen requested a review from a team as a code owner August 21, 2023 15:46

allroundexperts suggested changes Aug 22, 2023

View reviewed changes

This comment was marked as duplicate.

Sign in to view

tgolen added 3 commits August 22, 2023 14:36

Merge branch 'main' into tgolen-surface-distance-requests

33ff6dc

DRY up the transaction proptypes

784dbf2

Cleanup distance request check

e563349

tgolen commented Aug 22, 2023

View reviewed changes

allroundexperts approved these changes Aug 22, 2023

View reviewed changes

melvin-bot bot requested a review from arosiclair August 22, 2023 21:52

Expensify deleted a comment from allroundexperts Aug 23, 2023

arosiclair previously approved these changes Aug 23, 2023

View reviewed changes

Merge branch 'main' into tgolen-surface-distance-requests

b5cb79d

tgolen dismissed arosiclair’s stale review via b5cb79d August 23, 2023 15:24

Add error fields to proptypes

9fb9a1a

arosiclair previously approved these changes Aug 23, 2023

View reviewed changes

tgolen dismissed arosiclair’s stale review via 50599fe August 23, 2023 15:35

Remove extra export

50599fe

arosiclair approved these changes Aug 23, 2023

View reviewed changes

arosiclair merged commit ebb6d33 into main Aug 23, 2023

arosiclair deleted the tgolen-surface-distance-requests branch August 23, 2023 15:44

OSBotify mentioned this pull request Aug 24, 2023

Deploy Checklist: New Expensify 2023-08-24 #25813

Closed

73 tasks

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

jjcoffee reviewed Jan 25, 2024

View reviewed changes

jjcoffee mentioned this pull request Jan 25, 2024

[PAID] [$500] Distance- Expense preview does not show the updated currency when distance currency is changed #34066

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Allow distance requests to be viewed #24556

[No QA] Allow distance requests to be viewed #24556

tgolen commented Aug 14, 2023 •

edited

Loading

tgolen commented Aug 17, 2023

tgolen commented Aug 18, 2023

allroundexperts left a comment

This comment was marked as duplicate.

tgolen left a comment

tgolen Aug 22, 2023

allroundexperts left a comment

melvin-bot bot commented Aug 22, 2023

arosiclair commented Aug 23, 2023 •

edited

Loading

arosiclair left a comment

OSBotify commented Aug 23, 2023

OSBotify commented Aug 24, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

jjcoffee Jan 25, 2024

[No QA] Allow distance requests to be viewed #24556

[No QA] Allow distance requests to be viewed #24556

Conversation

tgolen commented Aug 14, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

tgolen commented Aug 17, 2023

tgolen commented Aug 18, 2023

allroundexperts left a comment

Choose a reason for hiding this comment

This comment was marked as duplicate.

tgolen left a comment

Choose a reason for hiding this comment

tgolen Aug 22, 2023

Choose a reason for hiding this comment

allroundexperts left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 22, 2023

arosiclair commented Aug 23, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

arosiclair left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 23, 2023

OSBotify commented Aug 24, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

jjcoffee Jan 25, 2024

Choose a reason for hiding this comment

tgolen commented Aug 14, 2023 •

edited

Loading

arosiclair commented Aug 23, 2023 •

edited

Loading