Remove step ID as it's not needed and causing errors #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luke9389
approved these changes
Apr 19, 2021
roryabraham
approved these changes
Apr 19, 2021
66 tasks
|
🚀 [Deployed](https://github.com/Expensify/Expensify.cash
|
|
🚀 Deployed to production in version: 1.0.39-5🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
There was a startup error with our new deployment commenting code as seen here https://github.com/Expensify/Expensify.cash/actions/runs/764799755
The workflow is not valid. .github/workflows/platformDeploy.yml (Line: 281, Col: 13): The identifier 'getReleasePRList' may not be used more than once within the same scope.I removed the duplicate ID as it's not required for this step, just a copy paste mistake.
Fixed Issues
Fixes startup error here: https://github.com/Expensify/Expensify.cash/actions/runs/764799755
Tests