Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline status support for reportActionComposer #2478

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Offline status support for reportActionComposer #2478

merged 2 commits into from
Apr 20, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Apr 19, 2021 •
edited
Loading

Please review.

Details

  1. Added opacity to the report actions until they are uploaded to the server.
  2. Added text You appear to be Offline under the Report Action Composer.

Fixed Issues

Fixes #2432

Tests / ### QA Steps

  1. Try to send messages in any chat and observe the gray text until they are uploaded to the server.
  2. Put on airplane mode, and send few messages, observe the text appearances.
  3. You should also see a status You appear to be Offline under the composer.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web / Desktop

output.mp4

localhost_8080_r_68438375

Android

Screenshot 2021-04-20 04:35:55

@parasharrajat parasharrajat requested a review from a team as a code owner April 19, 2021 22:48
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team April 19, 2021 22:48
thienlnam
thienlnam approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@thienlnam thienlnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Changes look good 👍

@thienlnam thienlnam merged commit fb5bbfe into Expensify:main Apr 20, 2021
@OSBotify OSBotify mentioned this pull request Apr 20, 2021
Closed
66 tasks
@parasharrajat
Copy link
Member Author

@thienlnam Thanks for merging it but let's make double-check on the designs.

@shawnborton Could you please take a look?

@OSBotify
Copy link
Contributor

🚀 Deployed to staging 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thienlnam thienlnam thienlnam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@parasharrajat @OSBotify @thienlnam