-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Create triggerWorkflowAndWait action #2495
Conversation
Took some tweeking (and has some hardcoded params to work in Public-Test-Repo atm), but here's a pretty successful POC test run: https://github.com/Andrew-Test-Org/Public-Test-Repo/runs/2415274704?check_suite_focus=true Next I need to test it with a couple inputs |
Okay, got inputs working, and by happy accident confirmed that error propagation is working as expected: https://github.com/Andrew-Test-Org/Public-Test-Repo/runs/2422716796?check_suite_focus=true |
Nice, got this working https://github.com/Andrew-Test-Org/Public-Test-Repo/actions/runs/821452629 |
Okay, sorry for the delay on this one, ready for review! |
@pecanoro In case you do end up reviewing this, just know that all the |
.github/actions/triggerWorkflowAndWait/triggerWorkflowAndWait.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few questions
I'm heading OOO and might have a chance to review this but don't block on my reivew 👍 |
Updated and ready for re-review 👍 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.42-1🚀
|
🚀 Deployed to production in version: 1.0.44-0🚀
|
Details
Creates a new GitHub Action to trigger another workflow and wait for its execution to complete. The other workflow must be triggerable by the
workflow_dispatch
event. Similar to this action, except better because:Fixed Issues
Related to #2329
Tests
Manually tested using another repo:
QA Steps
No QA
Tested On
GitHub :)