[CP staging] Request money - The app crashes when user deleted the request money #25468

pradeepmdk · 2023-08-18T11:18:29Z

Details

Fixed Issues

$ #25451
PROPOSAL: #25451

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Launch app
Tap Fab
Tap request money
Tap enter any amount
Tap next
Select any user
Tap Request money
Tap last transaction to open the last requested money page
Tap the money requested
In IOU details page, tap 3 dots to select "delete request"
Tap delete request

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Screen.Recording.2023-08-18.at.10.35.57.AM.mov

melvin-bot · 2023-08-18T11:18:33Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2023-08-18T12:11:22Z

@abdulrahuman5196 ready for a review, can you please treat it with urgency as this is a deploy blocker? Thanks!

abdulrahuman5196 · 2023-08-18T12:26:30Z

Yes starting to review now

abdulrahuman5196 · 2023-08-18T12:48:36Z

@pradeepmdk is the issue only present in android?
And author's checklist is failing, can you check on the same?

pradeepmdk · 2023-08-18T12:57:40Z

@abdulrahuman5196 yes android only I updated the checklist

mountiny · 2023-08-18T13:53:21Z

@abdulrahuman5196 bump on this one, it seems to be one of the last things holding deploy

abdulrahuman5196 · 2023-08-18T13:55:56Z

Hi @mountiny Yes. I am trying to build android, but its taking too much time to build. Just give me 10 - 20 mins. And also the new mapbox thing is slowing the build process.

mountiny · 2023-08-18T14:00:42Z

Ah damn, thanks!

abdulrahuman5196 · 2023-08-18T14:09:15Z

@mountiny #25481 could be dupe of this?

Meanwhile @pradeepmdk this is not android specific code right? It should also crash in other platforms, in the other issue its crashing in web as well

tranvantoan-qn · 2023-08-18T14:18:19Z

@abdulrahuman5196 @mountiny
I tried this one too but couldn't see the crash on the Web, #25481 only crashes in OFFLINE mode so I think they are different issues.
And the crash log looks totally different:

The crash log I got:

TypeError: Cannot read properties of null (reading 'reportID')
    at main-426150f61736a9bd57d7.bundle.js:1:3040782
    at vendors-3db7fcdc0b1c4dcfe55f.bundle.js:1:16283362
    at Xt (vendors-3db7fcdc0b1c4dcfe55f.bundle.js:1:16282859)
    at Function.qt (vendors-3db7fcdc0b1c4dcfe55f.bundle.js:1:16283340)
    at Object.P (main-426150f61736a9bd57d7.bundle.js:1:3040751)
    at Object.m (main-426150f61736a9bd57d7.bundle.js:1:1269288)
    at jn (main-426150f61736a9bd57d7.bundle.js:1:1470777)
    at fA (vendors-3db7fcdc0b1c4dcfe55f.bundle.js:1:9865482)
    at Bs (vendors-3db7fcdc0b1c4dcfe55f.bundle.js:1:9922584)
    at bl (vendors-3db7fcdc0b1c4dcfe55f.bundle.js:1:9911745)

abdulrahuman5196 · 2023-08-18T14:26:16Z

Thanks for the information @tranvantoan-qn . I think the crash log is different here. Then it might be a different issue after all

tranvantoan-qn · 2023-08-18T14:27:34Z

Another thing is, in my case, the delete action was performed in the main request, not in the request details - so there is no accessibilityLabel 😀

pradeepmdk · 2023-08-18T14:29:47Z

@abdulrahuman5196 for this crash only for android because in android strict data type check in the native that's its failing. other platform works well.

OSBotify · 2023-08-18T14:54:17Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/25468/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/25468/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/25468/NewExpensify.dmg	https://25468.pr-testing.expensify.com

abdulrahuman5196 · 2023-08-18T14:59:24Z

Downloading the android build for testing.

abdulrahuman5196 · 2023-08-18T15:17:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

N/A

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

N/A

iOS

N/A

Android

az_recorder_20230818_203834.mp4

abdulrahuman5196 · 2023-08-18T15:23:56Z

@mountiny I am assuming, since you had assigned the contributor, the root cause has been verified by you in the proposal. Because I am unable to test if the root cause is correct given the time constraint and android builds taking too long to build. If you want me to verify that, I can do that as well, but might need some time to repro the crash

But I tested in the new build, we are not seeing the mentioned crash.

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @mountiny

🎀 👀 🎀
C+ Reviewed

mountiny

Thanks @abdulrahuman5196

OSBotify · 2023-08-18T15:54:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Request money - The app crashes when user deleted the request money (cherry picked from commit 6e80fb4)

OSBotify · 2023-08-18T18:45:58Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.55-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

pradeepmdk added 2 commits August 18, 2023 16:29

add type case

269e084

update type error in MoneyRequestView

2d8772e

pradeepmdk requested a review from a team as a code owner August 18, 2023 11:18

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team August 18, 2023 11:18

mountiny assigned pradeepmdk Aug 18, 2023

Julesssss added the Ready To Build label Aug 18, 2023

abdulrahuman5196 approved these changes Aug 18, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny August 18, 2023 15:26

mountiny approved these changes Aug 18, 2023

View reviewed changes

mountiny merged commit 6e80fb4 into Expensify:main Aug 18, 2023

mountiny changed the title ~~Request money - The app crashes when user deleted the request money~~ [CP staging] Request money - The app crashes when user deleted the request money Aug 18, 2023

OSBotify pushed a commit that referenced this pull request Aug 18, 2023

Merge pull request #25468 from pradeepmdk/fix/25451-app-crash-fix

52eb617

Request money - The app crashes when user deleted the request money (cherry picked from commit 6e80fb4)

melvin-bot bot mentioned this pull request Aug 21, 2023

[HOLD for payment 2023-08-28] [$500] Request money - The app crashes when user deleted the request money #25451

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP staging] Request money - The app crashes when user deleted the request money #25468

[CP staging] Request money - The app crashes when user deleted the request money #25468

pradeepmdk commented Aug 18, 2023 •

edited

Loading

melvin-bot bot commented Aug 18, 2023

mountiny commented Aug 18, 2023

abdulrahuman5196 commented Aug 18, 2023

abdulrahuman5196 commented Aug 18, 2023

pradeepmdk commented Aug 18, 2023

mountiny commented Aug 18, 2023

abdulrahuman5196 commented Aug 18, 2023

mountiny commented Aug 18, 2023

abdulrahuman5196 commented Aug 18, 2023

tranvantoan-qn commented Aug 18, 2023 •

edited

Loading

abdulrahuman5196 commented Aug 18, 2023

tranvantoan-qn commented Aug 18, 2023 •

edited

Loading

pradeepmdk commented Aug 18, 2023

OSBotify commented Aug 18, 2023

abdulrahuman5196 commented Aug 18, 2023

abdulrahuman5196 commented Aug 18, 2023 •

edited

Loading

abdulrahuman5196 commented Aug 18, 2023 •

edited

Loading

abdulrahuman5196 left a comment

mountiny left a comment

OSBotify commented Aug 18, 2023

OSBotify commented Aug 18, 2023

[CP staging] Request money - The app crashes when user deleted the request money #25468

[CP staging] Request money - The app crashes when user deleted the request money #25468

Conversation

pradeepmdk commented Aug 18, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 18, 2023

mountiny commented Aug 18, 2023

abdulrahuman5196 commented Aug 18, 2023

abdulrahuman5196 commented Aug 18, 2023

pradeepmdk commented Aug 18, 2023

mountiny commented Aug 18, 2023

abdulrahuman5196 commented Aug 18, 2023

mountiny commented Aug 18, 2023

abdulrahuman5196 commented Aug 18, 2023

tranvantoan-qn commented Aug 18, 2023 • edited Loading

abdulrahuman5196 commented Aug 18, 2023

tranvantoan-qn commented Aug 18, 2023 • edited Loading

pradeepmdk commented Aug 18, 2023

OSBotify commented Aug 18, 2023

abdulrahuman5196 commented Aug 18, 2023

abdulrahuman5196 commented Aug 18, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 commented Aug 18, 2023 • edited Loading

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 18, 2023

OSBotify commented Aug 18, 2023

pradeepmdk commented Aug 18, 2023 •

edited

Loading

tranvantoan-qn commented Aug 18, 2023 •

edited

Loading

tranvantoan-qn commented Aug 18, 2023 •

edited

Loading

abdulrahuman5196 commented Aug 18, 2023 •

edited

Loading

abdulrahuman5196 commented Aug 18, 2023 •

edited

Loading