Use the normal pin icon for the LHN

[tgolen]

cc @shawnborton

Details

Just swapping out the icon and decreasing their size a little bit.

Fixed Issues

Fixes #2666

Tests / QA

1. Have a draft message on one report, have another report pinned, and another report pinned with a draft
2. Verify the pin icon in the LHN does not have the circle behind it anymore and the icons are slightly smaller

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[OSBotify]

🚀 Deployed to staging in version: 1.0.37-1🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[kavimuru]

Pen icon not displayed for the draft message in LHN

Expected Result:

Pen for a draft message in the LHN should be present

Actual Result:

Pen for a draft message in the LHN isn't present

Actions Performed:

1. Go to https://staging.expensify.cash
2. Log in with any account
3. Select any user and pinned it
4. Have another user pinned
5. Go back to the first user and write the message, but don't send it
6. Go back to LHN

Platform:

iOS ✔️
mWeb ✔️
Android ✔️

Build:

1.0.38-0

Notes/Images/Video:

20210505_145128.mp4

RPReplay_Final1620242271.mp4

[tgolen]

I think I've seen this. The icon does show up if you select another chat, right? It just doesn't show for the current chat?

…

On Wed, May 5, 2021 at 4:12 PM Kavi ***@***.***> wrote: Pen icon not displayed for the draft message in LHN Expected Result: Pen for a draft message in the LHN should be present Actual Result: Pen for a draft message in the LHN isn't present Actions Performed: 1. Go to https://staging.expensify.cash 2. Log in with any account 3. Select any user and pinned it 4. Have another user pinned 5. Go back to the first user and write the message, but don't send it 6. Go back to LHN Platform: iOS ✔️ mWeb ✔️ Android ✔️ Build: 1.0.38-0 ##Notes/Images/Video: https://user-images.githubusercontent.com/43996225/117216036-22485a00-adcd-11eb-8f79-4704d680e6fd.mp4 https://user-images.githubusercontent.com/43996225/117216086-3a1fde00-adcd-11eb-9253-1f988928b622.mp4 — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#2686 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB5GVYIN3HUO5STIN4TTMG7FJANCNFSM44DODOVQ> .

[isagoico]

Oh I see the issue here.

So for the draft icon to appear you have to write something in chat > got to LHN > then navigate to another chat, if I follow these steps the PR is a PASS. If you simply navigate to LHN the conversation is still "open" and draft icon will not appear.

This is the expected behavior at the moment right?

[tgolen]

I think that's what is expected at this point, yeah. The reason being that if you are writing a draft on the currently open chat, there isn't any need to show the draft icon in the LHN.

However, I was confused about this as well when I first saw it and so I think just displaying the draft icon in the LHN (regardless if it is the currently selected chat or not) would be a better user experience.

If you also agree that would be more intuitive, then I think we should move forward with making that change.

[isagoico]

I agree that it would be more intuitive for the mobile app. When I tested it on my side it did felt like the draft icon should appear when navigating to the LHN.

[tgolen]

All right, I'll create an issue for it! Thanks.

[tgolen]

Created it over here: https://github.com/Expensify/Expensify/issues/163084

[OSBotify]

🚀 Deployed to production in version: 1.0.39-5🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅