Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web proxy when accessing staging API #2717

Merged
merged 2 commits into from
May 6, 2021
Merged

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented May 6, 2021

Details

Testing against the staging API doesn't seem to work with the web proxy.

Fixed Issues

No Issue just something random I noticed while trying to Internal QA something

Tests

  1. Set USE_WEB_PROXY=true in .env
  2. Verify that when running npm run web you see that the host is www.expensify.com in npm log output e.g.
Creating proxy with host: www.expensify.com
Proxy server listening at http://localhost:9000
  1. Change the EXPENSIFY_URL_COM url in .env to https://staging.expensify.com/
  2. Verify that when running npm run web you see that the host is staging.expensify.com in npm log output e.g.
Creating proxy with host: staging.expensify.com
Proxy server listening at http://localhost:9000
  1. Verify you are accessing the staging server by inspecting network requests

QA Steps

No QA

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this May 6, 2021
@marcaaron marcaaron requested a review from a team as a code owner May 6, 2021 17:05
@MelvinBot MelvinBot requested review from NikkiWines and removed request for a team May 6, 2021 17:05
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well!

@NikkiWines NikkiWines merged commit 84ad169 into main May 6, 2021
@NikkiWines NikkiWines deleted the marcaaron-fixProxyStaging branch May 6, 2021 21:11
@OSBotify
Copy link
Contributor

OSBotify commented May 6, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented May 7, 2021

🚀 Deployed to staging in version: 1.0.39-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants