-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attach receipt #27224
Merged
Merged
Attach receipt #27224
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
f7c72f1
add three dot menu to confirmation page
luacmartins 5ca20ac
add attachment picker support
luacmartins 513c5fc
fix dropdown position anchor
luacmartins 37d9bc2
add logic to select receipt file
luacmartins 05a4da1
use only add receipt option
luacmartins 2875666
create edit receipt route, navigator
luacmartins ef7fb9e
create edit receipt page, navigate to edit page
luacmartins 0ab130c
update logic in navigateToNextPage
luacmartins 63e92ee
update native implementation
luacmartins 2ba6f18
use correct optimistic receipt state
luacmartins 4cf4ffd
pass receipt state to API
luacmartins b3df1cb
rm attachmentpicker
luacmartins c85695b
fix condition to display threeDotMenu
luacmartins d38feb4
add receipt state
luacmartins abd801c
update whisper logic
luacmartins db82a3e
add safe object access
luacmartins 0836a75
add attach option to transaction thread
luacmartins 1650f19
resolve conflicts
luacmartins 698a17a
fix style
luacmartins 492c4a5
fix whisper for report preview
luacmartins dcf2bb6
fix undefined variable
luacmartins 076f7c8
fix tests
luacmartins ba0232c
add useCallback dependency
luacmartins 9fdd47f
resolve conflicts
luacmartins 7bcf78a
resolve conflicts
luacmartins 3f5b814
pass missing param, add comment
luacmartins fabdca5
fix propTypes
luacmartins 8cc320d
fix crash
luacmartins 56a6d2d
fix style
luacmartins d6c18c8
only allow attaching receipts to dms
luacmartins fcc5441
address comments
luacmartins 2c9910c
use receipt instead of transaction
luacmartins ccd13d3
use ioutype
luacmartins a9c157f
resolve conflicts
luacmartins 3e75e28
resolve conflicts again
luacmartins 32221ae
fix route conflicts
luacmartins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BE: This is redundant. We are sending duplicate data, receipt already have state, the backend should extract it from there instead of us having to send it again separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I was trying to avoid that too, but our backend seems to strip away any custom properties from files. Since we were losing this data, I ended up having to send this as a separate param.