[No QA] Small refactors. #2744
Merged
[No QA] Small refactors. #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcaaron
requested changes
May 7, 2021
| @@ -155,7 +155,7 @@ class ReportActionsView extends React.Component { | |||
| const previousLastSequenceNumber = lodashGet(lastItem(prevProps.reportActions), 'sequenceNumber'); | |||
| const currentLastSequenceNumber = lodashGet(lastItem(this.props.reportActions), 'sequenceNumber'); | |||
| const shouldRecordMaxAction = Visibility.isVisible() | |||
| && !(this.props.isDrawerOpen && this.props.isSmallScreenWidth); | |||
| && (!this.props.isSmallScreenWidth || !this.props.isDrawerOpen); | |||
There was a problem hiding this comment.
Can we please add a comment here and list out every situations where we will record the max action?
src/components/Tooltip/index.js
Outdated
| @@ -174,7 +160,7 @@ class Tooltip extends PureComponent { | |||
| tooltipTextStyle, | |||
| pointerWrapperStyle, | |||
| pointerStyle, | |||
| } = getTooltipStyles( | |||
| } = this.state.isReady ? getTooltipStyles( | |||
There was a problem hiding this comment.
Is this necessary? We are not using any of these styles anyway unless this.state.isReady === true.
There was a problem hiding this comment.
I think it's better to just move this style calculations to TooltipRenderedOnPageBody as they are only used there.
cead22
reviewed
May 7, 2021
|
Updated. Thanks |
marcaaron
approved these changes
May 10, 2021
|
🚀 Deployed to staging in version: 1.0.43-9🚀
|
|
🚀 Deployed to production in version: 1.0.44-0🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marcaaron Please review.
Details
Tested On