Fix/26431: Web focus border is not disappearing on click #27733

DylanDylann · 2023-09-19T03:17:19Z

Details

Web - Focus Border is not disappearing on Click

Fixed Issues

$ #26431
PROPOSAL: #26431 (comment)

Tests

For web/desktop

Open chat, and hover over a chat to get a popup with menu items.
Use Tab/f11 to navigate to that element.
Once it's on Focus click on it, Click multiple times, Click on neighbouring elements,
Observe that the Border should be disappeared after clicking

For other devices

Open chat, click on the composer to bring it into focus
Long press on any report to get the menu items
Choose any emoji
Observe that it works as normal

Verify that no errors appear in the JS console

Offline tests

QA Steps

For web/desktop

Open chat, and hover over a chat to get a popup with menu items.
Use Tab/f11 to navigate to that element.
Once it's on Focus click on it, Click multiple times, Click on neighbouring elements,
Observe that the Border should be disappeared after clicking

For other devices

Open chat, click on the composer to bring it into focus
Long press on any report to get the menu items
Choose any emoji
Observe that it works as normal

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.from.19-09-2023.22.09.00.webm

Mobile Web - Chrome

7472343893078392094.mp4

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

melvin-bot · 2023-09-19T15:11:41Z

@ArekChr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2023-09-20T09:55:16Z

@ArekChr please help review this one

ArekChr · 2023-09-20T11:15:05Z

src/libs/ReportActionComposeFocusManager.ts

@@ -56,11 +57,16 @@ function clear(isMainComposer = false) {
 function isFocused(): boolean {
    return !!composerRef.current?.isFocused();
 }
+function isEditFocused(): boolean {


add comment for this function

ArekChr · 2023-09-20T11:24:23Z

@DylanDylann Overall, it works, but there is another edge case: when pressing the same emoji which is bordered, the border does not disappear

web.mov

DylanDylann · 2023-09-20T11:58:02Z

@DylanDylann Overall, it works, but there is another edge case: when pressing the same emoji which is bordered, the border does not disappear

web.mov

We can update the onMouseDown listener to:

   onMouseDown={(e) => {
                    if (!ReportActionComposeFocusManager.isFocused() && !ReportActionComposeFocusManager.isEditFocused()) {
                        DomUtils.getActiveElement().blur();
                        return;
                    }

                    e.preventDefault();
                }}

ArekChr · 2023-09-21T08:13:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mweb.chrome.mov

Mobile Web - Safari

mweb.safari.mov

Desktop

desktop.mov

iOS

Android

ArekChr

All works, thanks!

DylanDylann · 2023-09-21T23:15:18Z

@jasperhuangg any problem here? Let's merge it

OSBotify · 2023-09-25T06:36:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-25T10:03:42Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.74-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-28T18:46:03Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

DylanDylann added 2 commits September 19, 2023 10:15

fix web focus border is not disappearing on click

e5c1033

fix lint issue

927d1a7

DylanDylann marked this pull request as ready for review September 19, 2023 15:11

DylanDylann requested a review from a team as a code owner September 19, 2023 15:11

melvin-bot bot requested review from ArekChr and removed request for a team September 19, 2023 15:11

DylanDylann mentioned this pull request Sep 19, 2023

[HOLD for payment 2023-10-05] [$500] Web - Focus Border is not disappearing on Click #26431

Closed

6 tasks

ArekChr reviewed Sep 20, 2023

View reviewed changes

fix add comment to function isEditFocused

4f88426

fix edge case clicking on current active emoji

7070dfe

ArekChr approved these changes Sep 21, 2023

View reviewed changes

melvin-bot bot requested a review from jasperhuangg September 21, 2023 08:14

jasperhuangg approved these changes Sep 21, 2023

View reviewed changes

jasperhuangg merged commit 271059b into Expensify:main Sep 25, 2023

This was referenced Sep 25, 2023

Deploy Checklist: New Expensify DUPE 2023-09-25 #28118

Closed

Deploy Checklist: New Expensify 2023-09-25 #28119

Closed

fedirjh mentioned this pull request Jan 10, 2024

[TS migration] Migrate 'ReportActionItemMessageEdit.js' component to TypeScript #34091

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/26431: Web focus border is not disappearing on click #27733

Fix/26431: Web focus border is not disappearing on click #27733

DylanDylann commented Sep 19, 2023 •

edited

Loading

melvin-bot bot commented Sep 19, 2023

DylanDylann commented Sep 20, 2023

ArekChr Sep 20, 2023

DylanDylann Sep 20, 2023

ArekChr commented Sep 20, 2023

DylanDylann commented Sep 20, 2023

ArekChr commented Sep 21, 2023

ArekChr left a comment

DylanDylann commented Sep 21, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 28, 2023

Fix/26431: Web focus border is not disappearing on click #27733

Fix/26431: Web focus border is not disappearing on click #27733

Conversation

DylanDylann commented Sep 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 19, 2023

DylanDylann commented Sep 20, 2023

ArekChr Sep 20, 2023

Choose a reason for hiding this comment

DylanDylann Sep 20, 2023

Choose a reason for hiding this comment

ArekChr commented Sep 20, 2023

DylanDylann commented Sep 20, 2023

ArekChr commented Sep 21, 2023

Reviewer Checklist

Screenshots/Videos

ArekChr left a comment

Choose a reason for hiding this comment

DylanDylann commented Sep 21, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 28, 2023

DylanDylann commented Sep 19, 2023 •

edited

Loading