Implement more flexible regex parsing of StagingDeployCash issues #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGable
approved these changes
May 11, 2021
|
Self-merging this so I can add PRs that are missing from the checklist! |
36 tasks
|
🚀 Deployed to staging in version: 1.0.41-11🚀
|
|
🚀 Deployed to production in version: 1.0.44-0🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
As discussed 1:1, this small improvement to the regex parsing of StagingDeployCash issues should make them more flexible and allow me to easily edit it to add missing pull requests without breaking the parsing.
Fixed Issues
n/a
Tests
Added a unit test that duplicates a success case, except w/o any carriage returns.
QA Steps
No QA.
Tested On
Unit tested only. Will be live tested on GitHub.