Add ability to get the current operating system, display subset of emojis if on Windows #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stitesExpensify
approved these changes
May 11, 2021
stitesExpensify
requested changes
May 11, 2021
|
@stitesExpensify Replied your comment, I decided it's better to split it into two files to keep things more consistent with other library functions that have web and native counterparts. We should be good for another review! |
stitesExpensify
approved these changes
May 12, 2021
36 tasks
|
🚀 Deployed to staging in version: 1.0.42-8🚀
|
|
It's a pass! no flag category. |
marcaaron
reviewed
May 13, 2021
| * @return {String | null} | ||
| */ | ||
| export default () => { | ||
| switch (Platform.OS) { |
There was a problem hiding this comment.
We usually split stuff like this into an index.android.js and index.ios.js files instead of use Platform + index.native.js.
| const {userAgent, platform} = window.navigator; | ||
| const macosPlatforms = ['Macintosh', 'MacIntel', 'MacPPC', 'Mac68K']; | ||
| const windowsPlatforms = ['Win32', 'Win64', 'Windows', 'WinCE']; | ||
| const iosPlatforms = ['iPhone', 'iPad', 'iPod']; |
There was a problem hiding this comment.
NAB, if we only needed to know that we're on windows we could have created an isUsingWindows helper instead.
|
🚀 Deployed to production in version: 1.0.44-0🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Windows doesn't support flag emojis (and just displays country codes instead), so let's prevent those emojis from displaying in the emoji picker if we're on Windows.
To do this, I added a function
getOperatingSystemthat reads the current operating system.Fixed Issues
Fixes #2761
Tests
For the
getOperatingSystemfunction, I logged its results for all operating systems and verified that they were correct.I then verified that flag emojis don't appear in the emoji picker on Windows.
QA Steps
Tested On
Screenshots
Web
1620717907646955.mp4