Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed text-wrapping with Markup #2826

Merged
merged 1 commit into from
May 12, 2021
Merged

fixed text-wrapping with Markup #2826

merged 1 commit into from
May 12, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented May 12, 2021 •
edited
Loading

Please review @roryabraham

Details

Fixed Issues

Fixes #2790

Tests / QA Steps

  1. Open staging.expensify.cash
  2. Sign in if not already
  3. Enter a chat with anybody
  4. Send the message:
*Lorem ipsum dolor sit amet*, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum

5 This should wrap the text perfectly.
6. Send the message:

www.expensify.com Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum

7. This should wrap in the next lines.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

text-wrap

Mobile Web

text-wrap-mw

Desktop

text-wrap-d

iOS

Android

Screenshot_2021-05-13-00-39-05-631_com expensify chat

@parasharrajat parasharrajat requested a review from a team as a code owner May 12, 2021 19:06
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team May 12, 2021 19:06
@roryabraham roryabraham self-requested a review May 12, 2021 19:16
roryabraham
roryabraham approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests well 👍

@Jag96 Jag96 merged commit c72e8f8 into Expensify:main May 12, 2021
@OSBotify OSBotify mentioned this pull request May 12, 2021
Closed
36 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.42-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.44-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@tienifr tienifr mentioned this pull request Aug 22, 2023
Closed
56 tasks
@parasharrajat parasharrajat deleted the text-wrap branch November 20, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

@roryabraham roryabraham roryabraham approved these changes

@MonilBhavsar MonilBhavsar Awaiting requested review from MonilBhavsar

Assignees

@parasharrajat parasharrajat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pay 5/19] Wrap text when it includes markup
4 participants
@parasharrajat @OSBotify @Jag96 @roryabraham