Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we show the compose box on login #2860

Merged
merged 1 commit into from
May 13, 2021
Merged

Conversation

yuwenmemon
Copy link
Contributor

@Jag96 please review
h/t @parasharrajat for the suggestion here, looks like that was exactly it!

Details

Make sure we show the compose box on login. We were setting at part of the ONYX session here: https://github.com/Expensify/Expensify.cash/blob/e1185d2e0037ac09538706dec8778e075a7d212b/src/Expensify.js#L26

But not in this other spot.

Fixed Issues

Fixes #2804

Tests

  1. Uninstall the app
  2. Reinstall the app
  3. Log in and navigate to a conversation
  4. Make sure the compose input shows at the bottom
    Kapture 2021-05-13 at 10 50 33

@yuwenmemon yuwenmemon requested a review from Jag96 May 13, 2021 17:51
@yuwenmemon yuwenmemon self-assigned this May 13, 2021
@yuwenmemon yuwenmemon requested a review from a team as a code owner May 13, 2021 17:51
@MelvinBot MelvinBot requested review from timszot and removed request for a team May 13, 2021 17:51
@roryabraham
Copy link
Contributor

@yuwenmemon What do you mean by uninstall and reinstall the app?

@parasharrajat
Copy link
Member

I think only sign out and sign in again will be enough.

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce on main by signing out and signing back in, but on this branch it worked as expected.

@yuwenmemon yuwenmemon merged commit a3e29ba into main May 13, 2021
@yuwenmemon yuwenmemon deleted the yuwen=showCompose branch May 13, 2021 18:45
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.43-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.44-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat - Compose box doesn't appear after fresh installing the app
5 participants