Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo-sync/pull-request ref to version that outputs pr_number #2873

Merged
merged 1 commit into from
May 13, 2021

Conversation

roryabraham
Copy link
Contributor

Fixing https://github.com/Expensify/Expensify/issues/157916
Follow-up to #2329
Failed workflow run: https://github.com/Expensify/Expensify.cash/commit/e16252f47640d5ba5328d979a3f3c4bea746545d/checks

What happened? I was relying on an output from the repo-sync/pull-request action that didn't exist in the commit hash we were pointing to. So this PR just updates our action to point at the latest commit hash: https://github.com/repo-sync/pull-request/commits/master

@roryabraham roryabraham requested a review from Jag96 May 13, 2021 20:33
@roryabraham roryabraham requested a review from a team as a code owner May 13, 2021 20:33
@roryabraham roryabraham self-assigned this May 13, 2021
@MelvinBot MelvinBot requested review from alex-mechler and removed request for a team May 13, 2021 20:34
@roryabraham
Copy link
Contributor Author

This is exactly the kind of thing you just won't catch without actual testing.

@Jag96 Jag96 removed the request for review from alex-mechler May 13, 2021 20:35
@Jag96 Jag96 merged commit 531f152 into main May 13, 2021
@Jag96 Jag96 deleted the Rory-UpdateRepoSyncPR branch May 13, 2021 20:36
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.43-9🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.44-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants