Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update roryabraham/auto-approve-action ref #2881

Merged
merged 1 commit into from
May 13, 2021

Conversation

roryabraham
Copy link
Contributor

Fixing https://github.com/Expensify/Expensify/issues/157916
Follow-up for #2329
Failed workflow: https://github.com/Expensify/Expensify.cash/runs/2578898948?check_suite_focus=true

What happened? There was a code error in my forked version of the auto-approve-action repo.

Testing: There was a stupid JS error which wasn't caught by my unit testing, but I tested the fix in another repo and it worked.

@roryabraham roryabraham requested a review from Jag96 May 13, 2021 21:16
@roryabraham roryabraham requested a review from a team as a code owner May 13, 2021 21:16
@roryabraham roryabraham self-assigned this May 13, 2021
@MelvinBot MelvinBot requested review from robertjchen and removed request for a team May 13, 2021 21:16
@Jag96 Jag96 merged commit 2e3d799 into main May 13, 2021
@Jag96 Jag96 deleted the Rory-UpdateAutoApproveActionRef branch May 13, 2021 21:20
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.43-9🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.44-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants