feat(27641): Performance tests of LHN with Reassure #29083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add svg transformer for jest
Feat/27641/reassure lhn
fix: add timeout
melvin-bot
bot
requested review from
Santhosh-Sellavel
and removed request for
a team
|
@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mountiny FYI first batch of testing, unblocking LHN. You can see the new logs in the GH Actions output; we'll finally start collecting real regression results after merging this PR, 40+ rerenders is definitely something to improve on! :) |
mountiny
approved these changes
Oct 10, 2023
| const participants = ReportUtils.getDisplayNamesWithTooltips(participantsPersonalDetails, false); | ||
| expect(participants).toHaveLength(5); | ||
|
|
||
| expect(participants[0].avatar).toBeInstanceOf(Function); |
There was a problem hiding this comment.
Is the object in this case considered as Function? Why is that?
There was a problem hiding this comment.
I think @koko57 you can shed some light on it? If i recall correctly from our sessions it doesn't always come as an object, especially in this Jest environment and Function was valid.
There was a problem hiding this comment.
As we use this svg transformer for jest, we're loading svgs like in the app, we no longer get this object {testUri: ...}. And looking on proptypes this is what we actually expect here (string or function) 🙂
Reviewer Checklist
Screenshots/VideosCI changes, N/A WebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
|
@adhorodyski Could you fix the typo in the output: Changes look good to me, thank you! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
mountiny
removed
the
DeployBlockerCash
|
False positive, CI change |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.81-0 🚀
|
97 tasks
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.83-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR introduces correctly rendered Reassure tests for LHN together with interactions - scrolling & pressing.
What we've observed is that LHN's test was passing but the list wasn't in fact getting rendered. This resulted in a count of
1and a low duration of0.3msno matter the implementation which wasn't measuring any regressions.Please see an updated result measured locally:
Fixed Issues
$ #27641
PROPOSAL: N/A
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Not applicable as this PR includes only performance tests.
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android