-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inserted zero width character for emoji selection prevention #29686
Merged
Li357
merged 6 commits into
Expensify:main
from
ayazalavi:ayaz/GH-29021_am_pm_selection_bug
Oct 18, 2023
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b259693
inserted zero width character for emoji selection prevention
ayazalavi 8ad8f96
linting/pretter fixes
ayazalavi 49144c1
updated comments
ayazalavi 2ad6677
fixed typo
ayazalavi 2f8dd62
updated methods
ayazalavi 816fa87
prettier fix
ayazalavi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,7 @@ import CONST from '../../../CONST'; | |
import editedLabelStyles from '../../../styles/editedLabelStyles'; | ||
import UserDetailsTooltip from '../../../components/UserDetailsTooltip'; | ||
import avatarPropTypes from '../../../components/avatarPropTypes'; | ||
import * as Browser from '../../../libs/Browser'; | ||
|
||
const propTypes = { | ||
/** Users accountID */ | ||
|
@@ -66,6 +67,9 @@ const propTypes = { | |
|
||
/** localization props */ | ||
...withLocalizePropTypes, | ||
|
||
/** Should the comment have the appearance of being grouped with the previous comment? */ | ||
displayAsGroup: PropTypes.bool, | ||
}; | ||
|
||
const defaultProps = { | ||
|
@@ -82,9 +86,28 @@ const defaultProps = { | |
delegateAccountID: 0, | ||
actorIcon: {}, | ||
isThreadParentMessage: false, | ||
displayAsGroup: false, | ||
}; | ||
|
||
function ReportActionItemFragment(props) { | ||
/** | ||
* Checks text element for presence of emoji as first character | ||
* and insert Zero-Width character to avoid selection issue | ||
* mentioned here https://github.com/Expensify/App/issues/29021 | ||
* | ||
* @param {String} text | ||
* @param {Boolean} displayAsGroup | ||
* @returns {ReactNode | null} Text component with zero width character | ||
*/ | ||
|
||
function checkForEmojiForSelection(text, displayAsGroup) { | ||
const firstLetterIsEmoji = EmojiUtils.firstLetterIsEmoji(text); | ||
if (firstLetterIsEmoji && !displayAsGroup && !Browser.isMobile()) { | ||
return <Text>​</Text>; | ||
} | ||
return null; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would prefer this as an arrow function There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done, please check. |
||
|
||
switch (props.fragment.type) { | ||
case 'COMMENT': { | ||
const {html, text} = props.fragment; | ||
|
@@ -116,6 +139,7 @@ function ReportActionItemFragment(props) { | |
|
||
return ( | ||
<Text style={[containsOnlyEmojis ? styles.onlyEmojisText : undefined, styles.ltr, ...props.style]}> | ||
{checkForEmojiForSelection(text, props.displayAsGroup)} | ||
<Text | ||
selectable={!DeviceCapabilities.canUseTouchScreen() || !props.isSmallScreenWidth} | ||
style={[containsOnlyEmojis ? styles.onlyEmojisText : undefined, styles.ltr, ...props.style, isPendingDelete ? styles.offlineFeedback.deleted : undefined]} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer this as
isFirstLetterEmoji
orisFirstCharacterEmoji
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, please check.