-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating some IOU styles #3014
Updating some IOU styles #3014
Conversation
@iwiznia or @Julesssss can you help me take this over the finish line? I am having a pretty rough time getting this set up for local testing on iOS and Android. Will keep digging into it tomorrow. |
Sorry @shawnborton, I'm completely overrun and haven't been able to help with this today 😕 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code change looks good
Sure, what do you need? |
I just need to test this on iOS and Android to provide screenshots. I can't get the iOS app or Android app to run locally. |
ok, tested Android, I am still struggling to set up iOS. |
I've been struggling to make ios work locally (follow this if you want to laugh/cry with me). |
Not urgent at all but any luck @iwiznia ? |
Hey @shawnborton do you just want someone to build to each mobile platform and provide the screenshot, or to help you build? I have some time for this now. |
I think at this point it would be easiest if you could just pull my branch, test on Android and iOS to wrap up the screenshots above, and then we can get this merged. Hopefully for my next PR I'll have some time to troubleshoot my local apps but I probably won't get to it this week. |
Sorry @shawnborton, I tested Android (and included the screenshots above), but I could not manage to make ios work 😞 |
Wow, just browsing that troubleshooting thread gives me a headache. I was luckier and was able to verify iOS/mobile web. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cool, everyone approved so going to merge. Thanks for the help! |
Details
This adds a white background to the IOU preview component and gives it a larger maxWidth so it looks nicer in the sideDocked modal.
Fixed Issues
N/A
Tests / QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android