Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating some IOU styles #3014

Merged
merged 1 commit into from
May 27, 2021
Merged

Updating some IOU styles #3014

merged 1 commit into from
May 27, 2021

Conversation

shawnborton
Copy link
Contributor

@shawnborton shawnborton commented May 19, 2021

Details

This adds a white background to the IOU preview component and gives it a larger maxWidth so it looks nicer in the sideDocked modal.

Fixed Issues

N/A

Tests / QA Steps

  1. Request money from someone in order to create the IOU preview component
  2. Hover over the preview component, and make sure the preview component has a white background
  3. Click on the "View Details" link above the component. When the IOU detailed view launches, makes sure the preview box stretches to the full width of the detailed view.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

Screenshot 2021-05-27 at 11 34 10

Desktop

image

iOS

Simulator Screen Shot - iPhone 11 - 2021-05-27 at 10 59 55

Android

image
image

@shawnborton shawnborton self-assigned this May 19, 2021
@shawnborton shawnborton marked this pull request as ready for review May 19, 2021 22:37
@shawnborton shawnborton requested a review from a team as a code owner May 19, 2021 22:37
@MelvinBot MelvinBot requested review from sketchydroide and removed request for a team May 19, 2021 22:37
@shawnborton
Copy link
Contributor Author

@iwiznia or @Julesssss can you help me take this over the finish line? I am having a pretty rough time getting this set up for local testing on iOS and Android. Will keep digging into it tomorrow.

@Julesssss
Copy link
Contributor

Sorry @shawnborton, I'm completely overrun and haven't been able to help with this today 😕

Copy link
Contributor

@sketchydroide sketchydroide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change looks good

@iwiznia
Copy link
Contributor

iwiznia commented May 20, 2021

@iwiznia or @Julesssss can you help me take this over the finish line?

Sure, what do you need?

@shawnborton
Copy link
Contributor Author

I just need to test this on iOS and Android to provide screenshots. I can't get the iOS app or Android app to run locally.

@iwiznia
Copy link
Contributor

iwiznia commented May 20, 2021

ok, tested Android, I am still struggling to set up iOS.

@iwiznia
Copy link
Contributor

iwiznia commented May 21, 2021

I've been struggling to make ios work locally (follow this if you want to laugh/cry with me).

@shawnborton
Copy link
Contributor Author

Not urgent at all but any luck @iwiznia ?

@Julesssss
Copy link
Contributor

Hey @shawnborton do you just want someone to build to each mobile platform and provide the screenshot, or to help you build? I have some time for this now.

@shawnborton
Copy link
Contributor Author

I think at this point it would be easiest if you could just pull my branch, test on Android and iOS to wrap up the screenshots above, and then we can get this merged. Hopefully for my next PR I'll have some time to troubleshoot my local apps but I probably won't get to it this week.

@iwiznia
Copy link
Contributor

iwiznia commented May 26, 2021

Sorry @shawnborton, I tested Android (and included the screenshots above), but I could not manage to make ios work 😞

@Julesssss
Copy link
Contributor

Sorry @shawnborton, I tested Android (and included the screenshots above), but I could not manage to make ios work 😞

Wow, just browsing that troubleshooting thread gives me a headache.

I was luckier and was able to verify iOS/mobile web.

Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawnborton
Copy link
Contributor Author

Cool, everyone approved so going to merge. Thanks for the help!

@shawnborton shawnborton merged commit 4d6ce57 into main May 27, 2021
@shawnborton shawnborton deleted the shawn-IOU branch May 27, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants