Add server-side report searching for task destination and money requests

[marcaaron]

cc @puneetlath @mountiny

Details

Looked over the OptionsSelector we have in use in the App and these are the only two I think we need to update.

The others are either non report options or just personal details or lack a text input.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/328369

Tests

1. Create a new account User A
2. Create a new account User B
3. As User A create a workspace with a name "Hawaii"
4. As User A invite User B to workspace
5. Navigate to workspace chat as User A
6. Navigate to workspace chat as User B
7. Ensure User B account has "read" the report
8. Set User B from "Most recent" to "#focus" mode in the preferences
9. Sign out as User B
10. Sign in as User B
11. Tap the green FAB icon (+)
12. Select "Request money" option
13. Switch to "Manual" in tab nav
14. Enter amount
15. Search "Hawaii" and verify that the spinner appears and the workspace chat option eventually shows.
16. Go offline and verify the text about limit search results appears
17. Repeat steps 9 - 11
18. Select "Assign task" option
19. Give title and press Next
20. Select assignee
21. Tap "Share somewhere"
22. Search "Hawaii" and verify that the spinner appears and the workspace chat option eventually shows.
23. Go offline and verify the text about limit search results appears

• Verify that no errors appear in the JS console

Offline tests

See test steps for details.

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native


Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[fedirjh]

Go offline and verify the text about limit search results appears

@marcaaron This test seems to fail for me.

CleanShot.2023-10-27.at.20.18.21.mp4

It just appears In "start a new chat" and "search"

[marcaaron]

Sorry were some commits that I did not push apparently. Should be in the latest.

[fedirjh]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2023-10-28.at.19.16.21.mp4

Android: mWeb Chrome

CleanShot.2023-10-28.at.18.11.09.mp4

iOS: Native

CleanShot.2023-10-28.at.18.12.17.mp4

iOS: mWeb Safari

CleanShot.2023-10-28.at.18.04.18.mp4

MacOS: Chrome / Safari

CleanShot.2023-10-28.at.18.00.36.mp4

MacOS: Desktop

CleanShot.2023-10-28.at.18.19.12.mp4

[fedirjh]

LGTM

[melvin-bot]

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

🎯 @fedirjh, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #30551.

[mountiny]

Thanks! Looks good to me, all yours @srikarparsi

[mountiny]

@marcaaron Conflicts

[marcaaron]

Updated!

[srikarparsi]

lgtm!

[melvin-bot]

@srikarparsi looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[srikarparsi]

all tests passed

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
App start TTI	1108.545 ms → 1224.428 ms (+115.883 ms, +10.5%) 🔴

Show details

Name

Duration

App start TTI

Baseline Mean: 1108.545 ms Stdev: 26.858 ms (2.4%) Runs: 1041.9466619999148 1042.6096479999833 1054.7126029999927 1055.14978899993 1056.9009120000992 1057.6672320000362 1060.7146689998917 1070.8699960000813 1071.841936999932 1071.889043000061 1073.0597969999071 1083.5899219999555 1086.6009949999861 1088.6312800000887 1088.9732570000924 1090.6656889999285 1091.798053999897 1091.9907289999537 1093.5509450000245 1094.226268999977 1094.9197639999911 1095.5891990000382 1096.6970699999947 1096.9571839999408 1097.2518039999995 1097.314463000046 1097.352927000029 1098.445790000027 1101.0663860000204 1101.2943369999994 1101.5090759999584 1101.9466649999376 1103.5058840001002 1105.417308999924 1105.9611559999175 1106.3075119999703 1106.3436620000284 1106.7824689999688 1108.2304410000797 1110.8268160000443 1112.4052569998894 1112.797554000048 1112.8076849998906 1114.4442249999847 1115.4245390000287 1116.7712399999145 1116.8026980001014 1118.117615000112 1120.776954999892 1120.7783200000413 1122.26111400011 1124.5938430000097 1125.0526759999339 1125.8547519999556 1126.3806419998873 1126.4829679999966 1127.0936799999326 1127.1640550000593 1127.522106999997 1130.0377070000395 1130.7834250000305 1131.1190700000152 1131.6013279999606 1133.6668620000128 1135.1735060000792 1135.8385850000195 1136.4326110000256 1136.77686299989 1139.9996750000864 1141.0499529999215 1141.324988000095 1143.6500550000928 1144.9986930000596 1146.4386609999929 1148.1849330000114 1149.197187999962 1153.1682619999629 1162.413547999924 Current Mean: 1224.428 ms Stdev: 45.991 ms (3.8%) Runs: 1130.568605999928 1137.122997000115 1141.7104480001144 1146.19266099995 1148.850424000062 1149.153234000085 1161.4156700000167 1167.1623120000586 1169.1145109999925 1171.514167000074 1177.2456279997714 1179.441247999901 1180.7946550000925 1183.8181570000015 1185.1739610000513 1185.8532529999502 1185.8705080000218 1189.1875299999956 1191.6958469999954 1192.0332650002092 1192.728327000048 1193.1645130000543 1196.5753100002185 1197.4262260000687 1198.3353639999405 1199.2798230000772 1202.4672360001132 1204.2640669997782 1206.8199310000055 1212.2032479997724 1212.2449479999486 1213.3678240000736 1214.6685259998776 1215.5444609997794 1215.7822750001214 1215.9575730001088 1218.886708999984 1219.272660000017 1221.0630570000503 1223.2727160002105 1224.7542920000851 1225.6004909998737 1229.3016180000268 1231.2082219999284 1232.0346150000114 1232.3538210000843 1232.41709800018 1235.818024000153 1240.1368490001187 1244.4014809997752 1244.5372890001163 1245.99185199989 1246.3582100002095 1248.8380189999007 1248.854871999938 1250.0869189999066 1250.3125189999118 1250.7180339999031 1256.4342880002223 1257.0700889998116 1257.47559799999 1261.35990400007 1263.1606530002318 1265.1476400000975 1273.9490290000103 1281.0080289999023 1283.3239899999462 1284.6315549998544 1285.4656150001101 1287.531163000036 1288.8004580000415 1289.8894139998592 1293.8261469998397 1301.0956689999439 1318.5405640001409 1331.8237490002066 1339.4325749999844

Meaningless Changes To Duration

Show entries

Name	Duration
App start runJsBundle	785.013 ms → 856.577 ms (+71.564 ms, +9.1%)
Open Search Page TTI	706.660 ms → 718.966 ms (+12.306 ms, +1.7%)
App start regularAppStart	0.014 ms → 0.015 ms (+0.001 ms, +6.6%)
App start nativeLaunch	22.320 ms → 21.203 ms (-1.117 ms, -5.0%)

Show details

Name	Duration
App start runJsBundle	Baseline Mean: 785.013 ms Stdev: 24.396 ms (3.1%) Runs: 725 725 736 741 745 750 751 754 755 756 759 760 761 764 766 766 768 769 769 769 770 771 771 772 773 774 775 775 775 777 777 777 778 778 778 778 779 779 781 782 785 785 787 787 789 790 791 794 794 795 797 798 799 799 799 799 801 801 802 803 803 803 803 805 805 805 806 806 807 808 810 816 816 816 817 823 833 837 837 841 Current Mean: 856.577 ms Stdev: 40.594 ms (4.7%) Runs: 761 784 790 796 800 804 804 805 806 807 808 812 813 816 817 820 823 828 829 830 831 831 831 833 834 834 835 835 838 839 840 840 845 847 848 849 849 850 852 855 856 856 856 860 862 863 863 864 865 867 871 872 872 876 876 882 883 886 889 890 891 891 895 897 898 898 904 905 905 914 917 917 920 924 929 936 938 956
Open Search Page TTI	Baseline Mean: 706.660 ms Stdev: 42.033 ms (5.9%) Runs: 627.4803059999831 635.886921999976 639.2818199996836 645.7028000000864 646.4634599997662 647.2034110000823 648.9579680000897 652.5294190000277 656.0137940000277 656.585286999587 656.7883710002061 658.526002000086 661.4123140000738 662.346760999877 663.4864100001287 665.6956390000414 667.6365149999037 670.6505130000878 670.8693039999343 672.2902430000249 675.487712000031 678.8863119999878 680.2767739999108 681.7902430000249 682.1015629998874 684.0115970000625 684.1358239999972 685.2551680000033 685.4376219999976 685.6479499998968 686.4751389999874 686.8403319998179 688.7014979999512 692.4175619999878 692.4176440001465 692.940837000031 694.4049480000976 694.5300290002488 695.6102700000629 696.8251139998902 697.5998949999921 705.1518959999084 707.1968189999461 708.5136319999583 709.46822099993 710.5961519998964 712.8175869998522 714.1361489999108 719.3513999998104 720.3382569998503 720.9967859999742 721.2611489999108 721.8582760000136 723.3035069999751 723.9350180001929 724.5539560001343 730.9467370000202 731.3557950002141 732.9291179999709 734.337362000253 736.2400719998404 737.1206460001413 742.2074379997794 744.2991939999629 744.5533449999057 746.2446289998479 749.4064129998442 751.9791670001578 754.1608890001662 757.9031990002841 761.6845699998084 762.1914469997864 763.9943849998526 765.616049000062 771.1224370000418 773.5351569999475 773.8182379999198 777.4498700001277 798.7952069998719 800.8735770001076 805.6058360000607 Current Mean: 718.966 ms Stdev: 39.987 ms (5.6%) Runs: 646.6217450001277 651.9472250002436 652.9864509999752 660.1769199999981 660.9336759997532 661.7764489999972 664.1231689997949 666.0259189996868 669.2230220003985 674.1501059997827 674.9717199997976 676.7049969998188 677.1393639999442 679.3619790002704 681.6099450001493 681.6289470000193 689.33174699964 690.1388759999536 691.0952559998259 691.6210130001418 692.21875 692.5124109997414 692.8532310002483 694.0681970003061 694.277994999662 694.7762050000019 697.5995279997587 698.3566080001183 698.3749589999206 698.7143149999902 700.5908209998161 700.6714280000888 703.4891360001639 706.6628819997422 708.229127000086 712.4685069997795 715.7832029997371 715.9046640000306 716.0174159999005 716.0389410001226 716.3759359996766 719.0673829996958 719.4431969998404 719.9117850000039 720.0989989996888 721.6516519999132 724.2654220000841 724.4671629997902 724.6847740001976 725.8533129999414 728.390909999609 731.7674569999799 732.0200199997053 734.6867270004004 736.0582679999061 736.078409999609 742.1501059997827 742.8260099999607 743.5067950002849 747.0931400000118 748.6365150003694 749.8284920002334 750.131550999824 750.3787439996377 750.9714770000428 758.9332280000672 759.5423179999925 762.2614750000648 767.0239669997245 773.3761809999123 775.5359709998593 775.6900229998864 781.3217779998668 787.2245279997587 790.0752360001206 794.3302410002798 806.9765219995752 814.2368169999681 820.2889810004272
App start regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.001 ms (4.9%) Runs: 0.0125730000436306 0.012574000051245093 0.012736000120639801 0.012898999964818358 0.012980000115931034 0.013061000034213066 0.013061000034213066 0.013061999808996916 0.01306200004182756 0.013101999880746007 0.01310200011357665 0.013142999960109591 0.013143000192940235 0.013223999878391623 0.013224000111222267 0.013224999886006117 0.013264999957755208 0.013264999957755208 0.013386999955400825 0.013427000027149916 0.013428000034764409 0.013508999953046441 0.013508999953046441 0.013550000032410026 0.013550000032410026 0.013589999871328473 0.013589999871328473 0.013590000104159117 0.013590999878942966 0.01359100011177361 0.013631000183522701 0.013712999876588583 0.013713000109419227 0.013713000109419227 0.013752999948337674 0.013752999948337674 0.0138349998742342 0.013835000107064843 0.013835000107064843 0.01387499994598329 0.01387499994598329 0.013875999953597784 0.013916000025346875 0.013916000025346875 0.013956000097095966 0.013956999871879816 0.013998000184074044 0.014038000022992492 0.014038000022992492 0.014078000094741583 0.014119999948889017 0.014160000020638108 0.014160000020638108 0.014161000028252602 0.01424099993892014 0.014241999946534634 0.014322999864816666 0.01432300009764731 0.014404000015929341 0.014444999862462282 0.014445000095292926 0.014485999941825867 0.014527000021189451 0.014771000016480684 0.014771000016480684 0.014851000159978867 0.014851999934762716 0.014973999932408333 0.015137000009417534 0.015177000081166625 0.015177999855950475 0.015666000079363585 0.015746999997645617 Current Mean: 0.015 ms Stdev: 0.001 ms (5.7%) Runs: 0.013223999878391623 0.01334599987603724 0.013347000116482377 0.013387000188231468 0.013428000034764409 0.013550000032410026 0.013713000109419227 0.013752999948337674 0.013793999794870615 0.013793999794870615 0.01383400009945035 0.0138349998742342 0.0138349998742342 0.01387499994598329 0.013875999953597784 0.014038000255823135 0.014160000253468752 0.014161000028252602 0.014200999867171049 0.014201000332832336 0.014282000018283725 0.014282000018283725 0.014282000018283725 0.014282000018283725 0.014282000251114368 0.014283000025898218 0.014322999864816666 0.014322999864816666 0.01432300009764731 0.014403999783098698 0.014403999783098698 0.014404000015929341 0.014404000248759985 0.014527000021189451 0.014566999860107899 0.014566999860107899 0.014607999939471483 0.014648000244051218 0.014689000090584159 0.0147299999371171 0.014770000241696835 0.01477099978365004 0.014810999855399132 0.014851000159978867 0.014851999934762716 0.014933000318706036 0.014973999932408333 0.015014000004157424 0.015015000011771917 0.015177000313997269 0.015217999927699566 0.015217999927699566 0.015218000393360853 0.015298999845981598 0.015339999925345182 0.01534100016579032 0.015422000084072351 0.015422000084072351 0.015461999922990799 0.01550199999473989 0.015503000002354383 0.015583999920636415 0.015625 0.0157880000770092 0.0157880000770092 0.015910000074654818 0.015910000074654818 0.015950999688357115 0.01611399999819696 0.01615400006994605 0.016234999988228083 0.01623600022867322 0.01623600022867322 0.016276000067591667 0.016276000067591667 0.0166830001398921
App start nativeLaunch	Baseline Mean: 22.320 ms Stdev: 2.111 ms (9.5%) Runs: 19 19 19 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 25 25 25 26 26 26 27 28 28 28 Current Mean: 21.203 ms Stdev: 1.461 ms (6.9%) Runs: 18 18 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 24 24 24 24 24 25

[github-actions]

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

[OSBotify]

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[marcaaron]

TBH I do not really see how it can introduce a performance regression. The two pages altered are not open when we start the app and the test that failed is TTI so I am removing that blocker.

Also, looks like it also did not get to iOS @Beamanator

[Beamanator]

@marcaaron I bet this change made it into 1.3.94-2, but -0 and -1 were borked for iOS

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅