Restrict room rename for Task #30886

esh-g · 2023-11-04T17:34:47Z

Details

this PR will disable room rename and write capability editing in the settings of any thread (including tasks especially)

Fixed Issues

$ #30001
PROPOSAL: #30001 (comment)

Tests

Create a workspace.
Go to the #admins room of the workspace.
Create a task in the #admins room.
Go to the task report.
Click on the task report header.
Click on settings
Make sure we are not able to edit room name and who can post settings.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a workspace.
Go to the #admins room of the workspace.
Create a task in the #admins room.
Go to the task report.
Click on the task report header.
Click on settings
Make sure we are not able to edit room name and who can post settings.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-04.at.9.59.19.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-11-04.at.10.53.04.PM.mov

iOS: Native

Screen.Recording.2023-11-04.at.11.00.18.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-11-04.at.11.04.10.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-04.at.9.41.50.PM.mov

MacOS: Desktop

Screen.Recording.2023-11-04.at.11.01.44.PM.mov

melvin-bot · 2023-11-04T17:34:52Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2023-11-07T13:57:58Z

src/libs/ReportUtils.js

+ * @param {Object|null} policy - the workspace the report is on, null if the user isn't a member of the workspace
+ * @returns {Boolean}
+ */
+function canEditWriteCapability(report, policy) {


Why are we modifying the write capability conditions? Is this relevant to the issue?

@Ollyws I included it in my proposal and it is modified to have consistency as it is not shown for normal tasks

Ahh I see. Makes sense, thanks.

Ollyws · 2023-11-09T13:16:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws · 2023-11-09T13:16:32Z

@esh-g We have some merge conflicts if you could take a look, thanks!

esh-g · 2023-11-09T13:20:59Z

@Ollyws Fixed the conflict!

Ollyws

Just to be clear this PR will disable room rename and write capability editing in the settings of any thread.
LGTM.

stitesExpensify · 2023-11-10T23:50:58Z

src/libs/ReportUtils.js

+ * @param {Object|null} policy - the workspace the report is on, null if the user isn't a member of the workspace
+ * @returns {Boolean}
+ */
+function canEditWriteCapability(report, policy) {


Does the API already check for this? Or are we only checking this on the front end?

It seems to be determined by the front end, I can seemingly change the write-capability for a workspace room that I'm not admin of if I change the front-end to allow it.

OSBotify · 2023-11-20T21:24:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-22T01:02:39Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.2-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-23T16:54:11Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.2-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Restrict room rename for Task

f0b46b6

esh-g requested a review from a team as a code owner November 4, 2023 17:34

melvin-bot bot requested review from Ollyws and removed request for a team November 4, 2023 17:34

esh-g mentioned this pull request Nov 4, 2023

[COMPLETE CHECKLIST][$500] Task - Room name option is shown for task report settings and task name is replaced with # #30001

Closed

6 tasks

Ollyws reviewed Nov 7, 2023

View reviewed changes

Merge branch 'main' into task-room-name

d420bc6

Ollyws approved these changes Nov 9, 2023

View reviewed changes

melvin-bot bot requested a review from stitesExpensify November 9, 2023 13:27

stitesExpensify reviewed Nov 10, 2023

View reviewed changes

Merge branch 'main' into task-room-name

b6aefc8

stitesExpensify approved these changes Nov 20, 2023

View reviewed changes

stitesExpensify merged commit 1991736 into Expensify:main Nov 20, 2023

github-actions bot mentioned this pull request Nov 22, 2023

Deploy Checklist: New Expensify 2023-11-22 #31667

Closed

62 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restrict room rename for Task #30886

Restrict room rename for Task #30886

esh-g commented Nov 4, 2023 •

edited by github-actions bot

Loading

melvin-bot bot commented Nov 4, 2023

Ollyws Nov 7, 2023

esh-g Nov 7, 2023

Ollyws Nov 7, 2023

Ollyws commented Nov 9, 2023

Ollyws commented Nov 9, 2023

esh-g commented Nov 9, 2023

Ollyws left a comment

stitesExpensify Nov 10, 2023

Ollyws Nov 15, 2023 •

edited

Loading

OSBotify commented Nov 20, 2023

OSBotify commented Nov 22, 2023

OSBotify commented Nov 23, 2023

Restrict room rename for Task #30886

Restrict room rename for Task #30886

Conversation

esh-g commented Nov 4, 2023 • edited by github-actions bot Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 4, 2023

Ollyws Nov 7, 2023

Choose a reason for hiding this comment

esh-g Nov 7, 2023

Choose a reason for hiding this comment

Ollyws Nov 7, 2023

Choose a reason for hiding this comment

Ollyws commented Nov 9, 2023

Reviewer Checklist

Screenshots/Videos

Ollyws commented Nov 9, 2023

esh-g commented Nov 9, 2023

Ollyws left a comment

Choose a reason for hiding this comment

stitesExpensify Nov 10, 2023

Choose a reason for hiding this comment

Ollyws Nov 15, 2023 • edited Loading

Choose a reason for hiding this comment

OSBotify commented Nov 20, 2023

OSBotify commented Nov 22, 2023

OSBotify commented Nov 23, 2023

esh-g commented Nov 4, 2023 •

edited by github-actions bot

Loading

Ollyws Nov 15, 2023 •

edited

Loading