fix:: not focus the composer when file picker is opened #31421

dummy-1111 · 2023-11-16T07:41:25Z

Details

Don't focus the composer when file picker is opened

Fixed Issues

$ #22447
PROPOSAL: #22447 (comment)

Tests

Open ND and log in with any account
Navigate to any chat
Type :he(for example) to trigger emoji suggestions
Tap + button near the composer and select Add attachment
Verify that emoji suggestions isn't displayed for a brief moment
[WEB AND DESKTOP]Tap cancel and verify that emoji suggestions is opened again
[WEB AND DESKTOP]Tap + button near the composer and select Add attachment
[WEB AND DESKTOP]Select any image and close preview
[WEB AND DESKTOP]Verify that emoji suggestions is opened again
Type @ to trigger mention suggestions
Tap + button near the composer and select Add attachment
Verify that mention suggestions isn't displayed for a brief moment

Verify that no errors appear in the JS console

Offline tests

Open ND and log in with any account
Navigate to any chat
Type :he(for example) to trigger emoji suggestions
Tap + button near the composer and select Add attachment
Verify that emoji suggestions isn't displayed for a brief moment
[WEB AND DESKTOP]Tap cancel and verify that emoji suggestions is opened again
[WEB AND DESKTOP]Tap + button near the composer and select Add attachment
[WEB AND DESKTOP]Select any image and close preview
[WEB AND DESKTOP]Verify that emoji suggestions is opened again
Type @ to trigger mention suggestions
Tap + button near the composer and select Add attachment
Verify that mention suggestions isn't displayed for a brief moment

QA Steps

Open ND and log in with any account
Navigate to any chat
Type :he(for example) to trigger emoji suggestions
Tap + button near the composer and select Add attachment
Verify that emoji suggestions isn't displayed for a brief moment
[WEB AND DESKTOP]Tap cancel and verify that emoji suggestions is opened again
[WEB AND DESKTOP]Tap + button near the composer and select Add attachment
[WEB AND DESKTOP]Select any image and close preview
[WEB AND DESKTOP]Verify that emoji suggestions is opened again
Type @ to trigger mention suggestions
Tap + button near the composer and select Add attachment
Verify that mention suggestions isn't displayed for a brief moment

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

22447_android_native.mp4

Android: mWeb Chrome

22447_android_chrome.mp4

iOS: Native

22447_ios_native.mp4

iOS: mWeb Safari

22447_ios_safari.mp4

MacOS: Chrome / Safari

22447_mac_chrome.mp4

MacOS: Desktop

22447_mac_desktop.mp4

melvin-bot · 2023-11-16T07:52:29Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2023-11-21T12:33:28Z

@s-alves10 Please merge main.

dummy-1111 · 2023-11-21T12:56:01Z

@parasharrajat

merged. Please check

parasharrajat · 2023-11-21T13:40:34Z

src/pages/home/report/ReportActionCompose/ReportActionCompose.js

@@ -195,8 +195,9 @@ function ReportActionCompose({
    };

    const isKeyboardVisibleWhenShowingModalRef = useRef(false);
+    const isNextModalWillOpenRef = useRef(false);


I am trying to understand how this works. We are not setting this ref to true anywhere.

Please check. We set true when next modal will open

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Line 281 in 0cca90a

isNextModalWillOpenRef.current = true;

dummy-1111 · 2023-11-23T14:14:10Z

@parasharrajat

Can you please tell me what is blocking you here?

parasharrajat · 2023-11-28T17:18:15Z

I was on Vacay. Will get back on it soon.

parasharrajat · 2023-11-30T13:26:32Z

On my today's list.

parasharrajat · 2023-12-01T17:49:32Z

@s-alves10 This is looking good. But there are some bugs that I noticed on this PR but not on staging. Can you please merge main into this?

dummy-1111 · 2023-12-02T02:37:30Z

@parasharrajat

Will you check again?

parasharrajat · 2023-12-03T10:42:57Z

On it.

parasharrajat · 2023-12-03T14:25:24Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-12-03.at.11.21.06.PM.mov

🔲 iOS / Safari

Screen.Recording.2023-12-03.at.11.05.58.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-12-03.at.7.56.48.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-12-03.at.7.55.37.PM.mov

🔲 Android / Chrome

Screen.Recording.2023-12-03.at.11.16.39.PM.mov

🔲 Android / native

Screen.Recording.2023-12-03.at.11.22.24.PM.mov

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

OSBotify · 2023-12-04T18:22:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-05T02:55:35Z

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-05T13:40:40Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.4.8-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T20:30:45Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T20:40:17Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix:: not focus the composer when file picker is opened

b44a777

dummy-1111 marked this pull request as ready for review November 16, 2023 07:52

dummy-1111 requested a review from a team as a code owner November 16, 2023 07:52

melvin-bot bot requested review from parasharrajat and removed request for a team November 16, 2023 07:52

dummy-1111 mentioned this pull request Nov 16, 2023

[Hold for payment 12-14-2023][$1000] Mention options are not displayed on focus if we cancel add attachment #22447

Closed

6 tasks

Merge branch 'main' into fix/issue-22447

1b95a7a

parasharrajat reviewed Nov 21, 2023

View reviewed changes

Merge branch 'main' into fix/issue-22447

b0f6e6a

Merge branch 'main' into fix/issue-22447

c7bbdd3

parasharrajat approved these changes Dec 3, 2023

View reviewed changes

melvin-bot bot requested a review from aldo-expensify December 3, 2023 17:53

aldo-expensify approved these changes Dec 4, 2023

View reviewed changes

aldo-expensify merged commit 65a6e23 into Expensify:main Dec 4, 2023
14 checks passed

github-actions bot mentioned this pull request Dec 5, 2023

Deploy Checklist: New Expensify 2023-12-05 #32463

Closed

66 tasks

dummy-1111 deleted the fix/issue-22447 branch December 21, 2023 07:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix:: not focus the composer when file picker is opened #31421

fix:: not focus the composer when file picker is opened #31421

dummy-1111 commented Nov 16, 2023

melvin-bot bot commented Nov 16, 2023

parasharrajat commented Nov 21, 2023

dummy-1111 commented Nov 21, 2023

parasharrajat Nov 21, 2023

dummy-1111 Nov 21, 2023

dummy-1111 commented Nov 23, 2023

parasharrajat commented Nov 28, 2023

parasharrajat commented Nov 30, 2023

parasharrajat commented Dec 1, 2023

dummy-1111 commented Dec 2, 2023

parasharrajat commented Dec 3, 2023

parasharrajat commented Dec 3, 2023 •

edited

Loading

parasharrajat left a comment

OSBotify commented Dec 4, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

fix:: not focus the composer when file picker is opened #31421

fix:: not focus the composer when file picker is opened #31421

Conversation

dummy-1111 commented Nov 16, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 16, 2023

parasharrajat commented Nov 21, 2023

dummy-1111 commented Nov 21, 2023

parasharrajat Nov 21, 2023

Choose a reason for hiding this comment

dummy-1111 Nov 21, 2023

Choose a reason for hiding this comment

dummy-1111 commented Nov 23, 2023

parasharrajat commented Nov 28, 2023

parasharrajat commented Nov 30, 2023

parasharrajat commented Dec 1, 2023

dummy-1111 commented Dec 2, 2023

parasharrajat commented Dec 3, 2023

parasharrajat commented Dec 3, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

OSBotify commented Dec 4, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

parasharrajat commented Dec 3, 2023 •

edited

Loading