Code

Implement ViolationUtils lib#31656

Code

Merged

cead22 merged 78 commits intoExpensify:mainExpensify/App:mainfrom infinitered:violation-utilsinfinitered/ExpensifyApp:violation-utilsCopy head branch name to clipboardDec 4, 2023

+475-1

Commits

Commits on Nov 17, 2023

• feat(Violations): Add PolicyCategories type to match PolicyTags

  trevor-coleman

  committed
  f251978

  Copy full SHA for f251978

• feat(Violations): Create stub for ViolationUtils

  trevor-coleman

  committed
  51c2e7e

  Copy full SHA for 51c2e7e

• feat(Violations): Add TRANSACTION_VIOLATION to ONYXKEYS.COLLECTIONS

  trevor-coleman

  committed
  f001066

  Copy full SHA for f001066

• feat(Violations): Add TransactionViolation and related types to src/types/onyx

  trevor-coleman

  committed
  2705280

  Copy full SHA for 2705280

• feat(Violations): create possibleViolationsByField lookup

  trevor-coleman

  committed
  e2aaa6a

  Copy full SHA for e2aaa6a

• feat(Violations): implement getViolationForField and getViolationsOnyxData

  trevor-coleman

  committed
  7f39f5a

  Copy full SHA for 7f39f5a

Commits on Nov 20, 2023

• prettier

  trevor-coleman

  committed
  ccb4206

  Copy full SHA for ccb4206

Commits on Nov 21, 2023

• Merge pull request #73 from infinitered/trevorcoleman/violations/violation-utils

  Show description for 6a67fb8
  trevor-coleman

  authored
  6a67fb8

  Copy full SHA for 6a67fb8

• feat(Violations): remove unnecessary callback

  trevor-coleman

  committed
  0a04347

  Copy full SHA for 0a04347

Commits on Nov 22, 2023

• Merge remote-tracking branch 'origin/main' into trevorcoleman/violations/violation-utils

  Show description for 15f43ba
  trevor-coleman

  committed
  15f43ba

  Copy full SHA for 15f43ba

• update package-lock.json

  trevor-coleman

  committed
  575ea9b

  Copy full SHA for 575ea9b

• Merge remote-tracking branch 'upstream/main' into trevorcoleman/violations/violation-utils

  trevor-coleman

  committed
  17ef290

  Copy full SHA for 17ef290

• Merge remote-tracking branch 'upstream/main' into violation-utils

  Show description for cf65dbe
  trevor-coleman

  committed
  cf65dbe

  Copy full SHA for cf65dbe

• restore package-lock.json

  trevor-coleman

  committed
  0353afa

  Copy full SHA for 0353afa

• Merge remote-tracking branch 'upstream/main' into violation-utils

  trevor-coleman

  committed
  8c16f79

  Copy full SHA for 8c16f79

Commits on Nov 28, 2023

• Update src/types/onyx/TransactionViolation.ts

  Show description for 1e2e7c8
  

  trevor-coleman

  and

  cead22

  authored
  1e2e7c8

  Copy full SHA for 1e2e7c8

• Update src/libs/Violations/ViolationsUtils.ts

  Show description for 0c8d067
  

  trevor-coleman

  and

  cead22

  authored
  0c8d067

  Copy full SHA for 0c8d067

• Update src/types/onyx/TransactionViolation.ts

  Show description for 434fd9f
  

  trevor-coleman

  and

  cead22

  authored
  434fd9f

  Copy full SHA for 434fd9f

• Update src/types/onyx/TransactionViolation.ts

  Show description for d251b9a
  

  trevor-coleman

  and

  cead22

  authored
  d251b9a

  Copy full SHA for d251b9a

• Merge branch 'Expensify:main' into violation-utils

  trevor-coleman

  authored
  19b11b1

  Copy full SHA for 19b11b1

• feat(Violations): remove ViolationType, sort violation names

  trevor-coleman

  committed
  7f83963

  Copy full SHA for 7f83963

• feat(Violations): add dummy translations for complete list

  trevor-coleman

  committed
  e4a56b9

  Copy full SHA for e4a56b9

• feat(Violations): remove barrel file

  trevor-coleman

  committed
  12a2aa3

  Copy full SHA for 12a2aa3

• feat(Violations): extract getViolationsForField into useViolations hook

  trevor-coleman

  committed
  12682bb

  Copy full SHA for 12682bb

• Merge branch 'violation-utils' into trevorcoleman/violations/violation-utils

  Show description for d7ca133
  trevor-coleman

  authored
  d7ca133

  Copy full SHA for d7ca133

• feat(Violations): export violationFields for testing

  trevor-coleman

  committed
  58ea8d8

  Copy full SHA for 58ea8d8

• feat(Violations): add tests for useViolations

  trevor-coleman

  committed
  8f951e0

  Copy full SHA for 8f951e0

• feat(Violations): remove comments on arguments and replace with JSDoc

  trevor-coleman

  committed
  04c23f6

  Copy full SHA for 04c23f6

• Merge remote-tracking branch 'origin/trevorcoleman/violations/violation-utils' into trevorcoleman/violations/violation-utils

  trevor-coleman

  committed
  d1c8792

  Copy full SHA for d1c8792

• feat(Violations): lint

  trevor-coleman

  committed
  ddbe029

  Copy full SHA for ddbe029

• package-lock

  trevor-coleman

  committed
  7054d05

  Copy full SHA for 7054d05

• prettier

  trevor-coleman

  committed
  532c96a

  Copy full SHA for 532c96a

• feat(Violations): remove possibleViolationsByField

  trevor-coleman

  committed
  6568133

  Copy full SHA for 6568133

Commits on Nov 29, 2023

• Merge pull request #77 from infinitered/trevorcoleman/violations/violation-utils

  Show description for 6aef0ba
  trevor-coleman

  authored
  6aef0ba

  Copy full SHA for 6aef0ba

• feat(Violations): update violationFields

  trevor-coleman

  committed
  dfb444b

  Copy full SHA for dfb444b

• feat(Violations): update translations for violations

  trevor-coleman

  committed
  ae8acc5

  Copy full SHA for ae8acc5

• feat(Violations): update spanish translations for violations

  trevor-coleman

  committed
  a796c2c

  Copy full SHA for a796c2c

• feat(Violations): create ViolationUtilsTest with stubs.

  trevor-coleman

  committed
  f2792e5

  Copy full SHA for f2792e5

• feat(Violations): fix missing tags and categories logic

  trevor-coleman

  committed
  3710f82

  Copy full SHA for 3710f82

• feat(Violations): add tests for ViolationUtils

  trevor-coleman

  committed
  5158f20

  Copy full SHA for 5158f20

• feat(Violations): remove test for case sensitivity

  trevor-coleman

  committed
  eaa9c85

  Copy full SHA for eaa9c85

• feat(Violations): add tests for ViolationUtils

  trevor-coleman

  committed
  4fcc994

  Copy full SHA for 4fcc994

• feat(Violations): return dummy translations

  trevor-coleman

  committed
  a66d253

  Copy full SHA for a66d253

• feat(Violations): remove unused imports

  trevor-coleman

  committed
  f504508

  Copy full SHA for f504508

• feat(Violations): memoize return values for hasViolations, and return violations objects

  trevor-coleman

  committed
  ae1731b

  Copy full SHA for ae1731b

• feat(Violations): update tests for new return values.

  trevor-coleman

  committed
  de45660

  Copy full SHA for de45660

• Merge pull request #78 from infinitered/trevor-coleman/violations/violation-utils

  Show description for e239e41
  trevor-coleman

  authored
  e239e41

  Copy full SHA for e239e41

• feat(Violations): remove index

  trevor-coleman

  committed
  2b27509

  Copy full SHA for 2b27509

Commits on Nov 30, 2023

• feat(Violations): add quotes

  Show description for 47afbe9
  

  trevor-coleman

  and

  cead22

  authored
  47afbe9

  Copy full SHA for 47afbe9

• feat(Violations): Remove unnecessary casts

  Show description for bc3b872
  

  trevor-coleman

  and

  cead22

  authored
  bc3b872

  Copy full SHA for bc3b872

• feat(Violations): capitalize

  Show description for 9fd9bf9
  

  trevor-coleman

  and

  cead22

  authored
  9fd9bf9

  Copy full SHA for 9fd9bf9

• feat(Violations): Add condition

  Show description for e72bacc
  

  trevor-coleman

  and

  cead22

  authored
  e72bacc

  Copy full SHA for e72bacc

• feat(Violations): Remove cast

  Show description for 2de9615
  

  trevor-coleman

  and

  cead22

  authored
  2de9615

  Copy full SHA for 2de9615

• feat(Violations): add condition

  Show description for 478f934
  

  trevor-coleman

  and

  cead22

  authored
  478f934

  Copy full SHA for 478f934

• feat(Violations): remove unused types

  trevor-coleman

  committed
  ef5ebb3

  Copy full SHA for ef5ebb3

• feat(Violations): harmonize tag and category handling

  trevor-coleman

  committed
  68c5485

  Copy full SHA for 68c5485

• feat(Violations): reorder types

  trevor-coleman

  committed
  75f003a

  Copy full SHA for 75f003a

• feat(Violations): Apply suggestions from code review

  Show description for 016b438
  

  trevor-coleman

  and

  cead22

  authored
  016b438

  Copy full SHA for 016b438

• feat(Violations): remove hasViolationsMap

  trevor-coleman

  committed
  9c356f2

  Copy full SHA for 9c356f2

• feat(Violations): refactor useViolations tests

  trevor-coleman

  committed
  9b0c88a

  Copy full SHA for 9b0c88a

Commits on Dec 1, 2023

• feat(Violations): refactor ViolationUtils tests

  trevor-coleman

  committed
  e0d8d97

  Copy full SHA for e0d8d97

• Merge remote-tracking branch 'origin/violation-utils' into violation-utils

  Show description for 96544c9
  trevor-coleman

  committed
  96544c9

  Copy full SHA for 96544c9

• Merge branch 'main' into violation-utils

  trevor-coleman

  committed
  06b7012

  Copy full SHA for 06b7012

• feat(Violations): revert package.json

  trevor-coleman

  committed
  ebb5751

  Copy full SHA for ebb5751

• prettier

  trevor-coleman

  committed
  74b80df

  Copy full SHA for 74b80df

• feat(Violations): remove execute

  trevor-coleman

  committed
  d3be1f6

  Copy full SHA for d3be1f6

• feat(Violations): refactor tests

  trevor-coleman

  committed
  4ab9931

  Copy full SHA for 4ab9931

• feat(Violations): refactor tests

  trevor-coleman

  committed
  3737752

  Copy full SHA for 3737752

• feat(Violations): refactor tests

  trevor-coleman

  committed
  1876a0b

  Copy full SHA for 1876a0b

• feat(Violations): refactor tests to have simpler base case

  trevor-coleman

  committed
  72667ec

  Copy full SHA for 72667ec

Commits on Dec 4, 2023

• Update tests/unit/ViolationUtilsTest.js

  Show description for 27cfac1
  

  trevor-coleman

  and

  cead22

  authored
  27cfac1

  Copy full SHA for 27cfac1

• feat(Violations): Suggested changes from PR Review

  Show description for e5ae614
  

  trevor-coleman

  and

  cead22

  authored
  e5ae614

  Copy full SHA for e5ae614

• feat(Violations): remove useViolationsTest

  trevor-coleman

  committed
  8498e80

  Copy full SHA for 8498e80

• feat(Violations): fixes from PR Comments

  trevor-coleman

  committed
  e6e7612

  Copy full SHA for e6e7612

• Merge remote-tracking branch 'origin/violation-utils' into violation-utils

  trevor-coleman

  committed
  0aa36b8

  Copy full SHA for 0aa36b8

• prettier

  trevor-coleman

  committed
  391822c

  Copy full SHA for 391822c

• Merge remote-tracking branch 'upstream/main' into violation-utils

  trevor-coleman

  committed
  dd48fe1

  Copy full SHA for dd48fe1

• feat(Violations): remove useViolationsTest

  trevor-coleman

  committed
  d2cfd33

  Copy full SHA for d2cfd33