Chat - Send money text displayed in workspace chat #33520

ZhenjaHorbach · 2023-12-22T19:34:54Z

Details

Chat - Send money text displayed in workspace chat

Fixed Issues

$ #33003
PROPOSAL: #33003 (comment)

Tests

Open the app
Open any workspace chat and scroll on top
Observe the text 'You can also use the + button to send money, request money, or assign a task!' has synchronized with available money options in + menu

Verify that no errors appear in the JS console

Offline tests

Open the app
Open any workspace chat and scroll on top
Observe the text 'You can also use the + button to send money, request money, or assign a task!' has synchronized with available money options in + menu

QA Steps

Open the app
Open any workspace chat and scroll on top
Observe the text 'You can also use the + button to send money, request money, or assign a task!' has synchronized with available money options in + menu

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2023-12-22T19:34:59Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2023-12-22T19:39:05Z

@Ollyws
Hello )
PR is ready

The only thing
That we now have a split option in the text
I think it's logical
But if necessary
I can delete )

ZhenjaHorbach · 2024-01-02T07:41:58Z

@Ollyws
Hello )
Friendly bump )

Ollyws · 2024-01-03T14:44:02Z

src/languages/es.ts

+        iouTypes: {
+            send: 'enviar dinero',
+            split: 'dividir factura',
+            request: 'redir dinero',


Suggested change

request: 'redir dinero',

request: 'pedir dinero',

Oh
Good catch )
Fixed it )

Ollyws · 2024-01-03T14:59:18Z

src/languages/en.ts

+        usePlusButton: ({additionalText}: UsePlusButtonParams) => `\n\nYou can also use the + button to ${additionalText}, or assign a task!`,
+        iouTypes: {
+            send: 'send money',
+            split: 'split bill',


Suggested change

split: 'split bill',

split: 'split a bill',

Or perhaps Split bills would be preferable here. Let me confirm.

I think one bill looks logical
Same as on the menu
We split one bill

Yeah I tend to agree.

Ollyws · 2024-01-03T15:00:01Z

src/languages/es.ts

+        usePlusButton: ({additionalText}: UsePlusButtonParams) => `\n\n¡También puedes usar el botón + de abajo para ${additionalText}, o asignar una tarea!`,
+        iouTypes: {
+            send: 'enviar dinero',
+            split: 'dividir factura',


Suggested change

split: 'dividir factura',

split: 'dividir una factura',

Ollyws · 2024-01-05T15:21:38Z

src/components/ReportWelcomeText.tsx

@@ -111,7 +111,7 @@ function ReportWelcomeText({report, policy, personalDetails}: ReportWelcomeTextP
                        ))}
                    </Text>
                )}
-                {(moneyRequestOptions.includes(CONST.IOU.TYPE.SEND) || moneyRequestOptions.includes(CONST.IOU.TYPE.REQUEST)) && <Text>{translate('reportActionsView.usePlusButton')}</Text>}


Removing this condition displays the text in some places where it shouldn't be, for example in a user created #room only Split bill is availble so the text is not displayed on staging/production.

ZhenjaHorbach · 2024-01-08T08:37:45Z

@Ollyws
Hello )
PR is ready)

Ollyws · 2024-01-08T11:42:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Ollyws

LGTM.

OSBotify · 2024-01-08T16:31:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-09T05:37:00Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.23-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-10T06:04:15Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.23-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Fix bug with Send money text displayed in workspace chat

a2fd4f8

ZhenjaHorbach requested a review from a team as a code owner December 22, 2023 19:34

melvin-bot bot requested review from Ollyws and removed request for a team December 22, 2023 19:34

ZhenjaHorbach added 2 commits January 2, 2024 09:54

Update branch

2be7be3

Fix lint issue

05dd041

Ollyws reviewed Jan 3, 2024

View reviewed changes

ZhenjaHorbach added 2 commits January 3, 2024 17:55

Update branch

e40500e

Update translate

342cdc5

Ollyws reviewed Jan 3, 2024

View reviewed changes

ZhenjaHorbach added 2 commits January 3, 2024 18:01

Fix eslint issue

6ce3bce

Update translates

bc0b7a1

Ollyws reviewed Jan 5, 2024

View reviewed changes

ZhenjaHorbach added 2 commits January 5, 2024 18:35

Update branch

f32bf8b

Update condition for text

e12f067

Ollyws approved these changes Jan 8, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath January 8, 2024 11:43

puneetlath approved these changes Jan 8, 2024

View reviewed changes

puneetlath merged commit b9c2514 into Expensify:main Jan 8, 2024
2 checks passed

github-actions bot mentioned this pull request Jan 9, 2024

Deploy Checklist: New Expensify 2024-01-09 #34121

Closed

87 tasks

melvin-bot bot mentioned this pull request Jan 10, 2024

[HOLD for payment 2024-01-17] [$500] Chat - Send money text displayed in workspace chat #33003

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chat - Send money text displayed in workspace chat #33520

Chat - Send money text displayed in workspace chat #33520

ZhenjaHorbach commented Dec 22, 2023 •

edited

Loading

melvin-bot bot commented Dec 22, 2023

ZhenjaHorbach commented Dec 22, 2023 •

edited

Loading

ZhenjaHorbach commented Jan 2, 2024 •

edited

Loading

Ollyws Jan 3, 2024

ZhenjaHorbach Jan 3, 2024

Ollyws Jan 3, 2024

Ollyws Jan 3, 2024

ZhenjaHorbach Jan 3, 2024

Ollyws Jan 3, 2024

Ollyws Jan 3, 2024

Ollyws Jan 5, 2024

ZhenjaHorbach Jan 5, 2024

ZhenjaHorbach commented Jan 8, 2024

Ollyws commented Jan 8, 2024

Ollyws left a comment

OSBotify commented Jan 8, 2024

OSBotify commented Jan 9, 2024

OSBotify commented Jan 10, 2024

Chat - Send money text displayed in workspace chat #33520

Chat - Send money text displayed in workspace chat #33520

Conversation

ZhenjaHorbach commented Dec 22, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 22, 2023

ZhenjaHorbach commented Dec 22, 2023 • edited Loading

ZhenjaHorbach commented Jan 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZhenjaHorbach commented Jan 8, 2024

Ollyws commented Jan 8, 2024

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 8, 2024

OSBotify commented Jan 9, 2024

OSBotify commented Jan 10, 2024

ZhenjaHorbach commented Dec 22, 2023 •

edited

Loading

ZhenjaHorbach commented Dec 22, 2023 •

edited

Loading

ZhenjaHorbach commented Jan 2, 2024 •

edited

Loading