fix: The back and forward keys are not working properly for navigating back to a characters #36303

Krishna2323 · 2024-02-11T07:07:54Z

Details

Fixed Issues

$ #36059
PROPOSAL: #36059 (comment)

Tests

Open the emoji picker
Enter characters in the search field
Type something in the input box & use the left/right arrow keys
Verify the cursor is placed at the right place using left/right arrow keys
While focused on input use down keys & verify focus moves from input to emoji
When emoji is focused try to use left/right, up/down keys, verify that works correctly

Verify that no errors appear in the JS console

Offline tests

Open the emoji picker
Enter characters in the search field
Type something in the input box & use the left/right arrow keys
Verify the cursor is placed at the right place using left/right arrow keys
While focused on input use down keys & verify focus moves from input to emoji
When emoji is focused try to use left/right, up/down keys, verify that works correctly

QA Steps

Open the emoji picker
Enter characters in the search field
Type something in the input box & use the left/right arrow keys
Verify the cursor is placed at the right place using left/right arrow keys
While focused on input use down keys & verify focus moves from input to emoji
When emoji is focused try to use left/right, up/down keys, verify that works correctly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…g back to a characters. Signed-off-by: Krishna Gupta <[email protected]>

melvin-bot · 2024-02-11T07:07:59Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jjcoffee · 2024-02-12T10:02:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native-2024-02-12_14.56.54.mp4

Android: mWeb Chrome

android-chrome-2024-02-12_15.01.48.mp4

iOS: Native

ios-native-2024-02-12_17.04.10.mp4

iOS: mWeb Safari

ios-safari-2024-02-12_16.48.57.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-02-12_12.55.13.mp4

MacOS: Desktop

desktop-app-2024-02-12_12.57.05.mp4

jjcoffee · 2024-02-12T11:50:08Z

src/components/EmojiPicker/EmojiPickerMenu/index.js

@@ -109,6 +109,9 @@ function EmojiPickerMenu({forwardedRef, onEmojiSelected, activeEmoji}) {
        initialFocusedIndex: -1,
        disableCyclicTraversal: true,
        onFocusedIndexChange,
+        disableHorizontalKeys: isFocused,
+        // We need to pass isActive, we can pass true without checking visibility of the component because if the popover is not visible this picker won't be mounted


Suggested change

// We need to pass isActive, we can pass true without checking visibility of the component because if the popover is not visible this picker won't be mounted

// We pass true without checking visibility of the component because if the popover is not visible this picker won't be mounted

@jjcoffee, done!

Signed-off-by: Krishna Gupta <[email protected]>

jjcoffee

LGTM!

OSBotify · 2024-02-12T17:54:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-15T05:25:49Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.41-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Krishna2323 added 2 commits February 10, 2024 20:49

fix: The back and forward keys are not working properly for navigatin…

978bcee

…g back to a characters. Signed-off-by: Krishna Gupta <[email protected]>

Merge branch 'Expensify:main' into krishna2323/issue/36059

70275e7

Krishna2323 requested a review from a team as a code owner February 11, 2024 07:07

melvin-bot bot requested review from jjcoffee and removed request for a team February 11, 2024 07:07

jjcoffee reviewed Feb 12, 2024

View reviewed changes

update comment.

7a65931

Signed-off-by: Krishna Gupta <[email protected]>

jjcoffee approved these changes Feb 12, 2024

View reviewed changes

melvin-bot bot requested a review from amyevans February 12, 2024 16:05

amyevans approved these changes Feb 12, 2024

View reviewed changes

amyevans merged commit 84a6cda into Expensify:main Feb 12, 2024
16 of 17 checks passed

github-actions bot mentioned this pull request Feb 13, 2024

Deploy Checklist: New Expensify 2024-02-13 #36429

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: The back and forward keys are not working properly for navigating back to a characters #36303

fix: The back and forward keys are not working properly for navigating back to a characters #36303

Krishna2323 commented Feb 11, 2024 •

edited

Loading

melvin-bot bot commented Feb 11, 2024

jjcoffee commented Feb 12, 2024 •

edited

Loading

jjcoffee Feb 12, 2024

Krishna2323 Feb 12, 2024

jjcoffee left a comment

OSBotify commented Feb 12, 2024

OSBotify commented Feb 15, 2024

	// We need to pass isActive, we can pass true without checking visibility of the component because if the popover is not visible this picker won't be mounted
	// We pass true without checking visibility of the component because if the popover is not visible this picker won't be mounted

fix: The back and forward keys are not working properly for navigating back to a characters #36303

fix: The back and forward keys are not working properly for navigating back to a characters #36303

Conversation

Krishna2323 commented Feb 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 11, 2024

jjcoffee commented Feb 12, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee Feb 12, 2024

Choose a reason for hiding this comment

Krishna2323 Feb 12, 2024

Choose a reason for hiding this comment

jjcoffee left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 12, 2024

OSBotify commented Feb 15, 2024

Krishna2323 commented Feb 11, 2024 •

edited

Loading

jjcoffee commented Feb 12, 2024 •

edited

Loading