Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO QA] Set up the request call API functions #3695

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Jun 21, 2021

Details

This PR includes some utility functions that will be used when implementing Adding Guides Calling to Expensify.cash. Specifically, it includes an API function that calls Inbox_CallUser, and a corresponding action that calls this API function.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/167897

Tests

N/A

QA Steps

N/A

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

N/A

@jasperhuangg jasperhuangg self-assigned this Jun 21, 2021
@jasperhuangg jasperhuangg marked this pull request as ready for review June 21, 2021 02:15
@jasperhuangg jasperhuangg requested a review from a team as a code owner June 21, 2021 02:15
@MelvinBot MelvinBot requested review from deetergp and removed request for a team June 21, 2021 02:15
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deetergp deetergp merged commit c1536a8 into main Jun 21, 2021
@deetergp deetergp deleted the jasper-requestCallAPI branch June 21, 2021 20:57
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.73-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.74-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants