-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Make lonely emojis bigger #3738
Conversation
Just a note: while #3730 isn't fixed, the only way to test this is by sending messages while offline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.73-4🚀
|
🚀 Deployed to production in version: 1.0.74-0🚀
|
Details
Increases the fontSize of the
ReportActionItemFragment
of typeCOMMENT
when it's composed of a single emoji. To do that, we:singleEmojiText
, with custom fontSize and lineHeightCONST.REGEX.EMOJIS
isSingleEmoji
, a function that validates if a string is composed of a single emojiReportActionItemFragment
we check if theCOMMENT
passes ourisSingleEmoji
validation. If it passes, we use thesingleEmojiText
style instead of our default.Fixed Issues
Fixes #3712
Tests
QA Steps
Tested On
Screenshots
Web
Web.mov
Mobile Web
mWeb.mp4
Desktop
desktop.mov
iOS
iOS.mp4
Android
android.mp4