Allow those in defaultRooms beta to also load policies #3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcaaron
approved these changes
Jun 28, 2021
|
Ah yep that'll do it 🤦 LGTM thanks for catching this! |
yuwenmemon
approved these changes
Jun 28, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
72 tasks
6 tasks
22 tasks
|
🚀 Deployed to staging in version: 1.0.74-1🚀
|
|
Just QA'ed this one. Can verify it's working on my phone and on web: |
|
Nice! @trjExpensify or @TomatoToaster you wanna make an inaugural post in that room? 😏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Jag96, please review when you get the chance
CC: @marcaaron, @yuwenmemon
Details
We recently restricted loading policy data to those in the freePlan beta, but this is also necessary for defaultRooms so let's let both users access this.
ALSO, we aren't looking for the
allflag in some of the newer betas, so this fixes that too. This will allow expensifail (including applause) accounts to access all betas as intended in ecash.Fixed Issues
related to https://github.com/Expensify/Expensify/issues/161777
Tests
This isn't something you can really test locally without manually editing the beta code anyway. This will be really quick to test in staging/prod.
QA Steps
This needs to be tested internally (reach out to @TomatoToaster or [email protected] on ecash and he can do it quickly).
Unknown Policy, but actually have the right policy name on them (see screenshots).Tested On
Screenshots
Web
GOOD:
BAD:
